Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEstelle Foisy2023-01-19 15:24:10 +0000
committerMatthew Khouzam2023-02-01 15:25:08 +0000
commit942caa61edf2097199c16c24c11804960996ba34 (patch)
tree257a591c8db509f7cf82295333297a98bf929de3
parentb73a5463b02b356f022add66aea9435994bb40ce (diff)
downloadorg.eclipse.tracecompass.incubator-942caa61edf2097199c16c24c11804960996ba34.tar.gz
org.eclipse.tracecompass.incubator-942caa61edf2097199c16c24c11804960996ba34.tar.xz
org.eclipse.tracecompass.incubator-942caa61edf2097199c16c24c11804960996ba34.zip
Change system.out.println to Activator.logWarning or Activator.logInfo
This change is done in order to have all the warning store in the warning log of the workspace. Also changed some of system.out.println to be logInfo. Change-Id: I65aa04cce27cd39cccbdb322c377c58bfb9bcc0a Signed-off-by: Estelle Foisy <estelle.foisy@ericsson.com> Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/199478 Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org> Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com> Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com> Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
-rw-r--r--analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/builder/BuilderInstanceGroup.java21
-rw-r--r--analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableAnalysis.java6
-rw-r--r--analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableCounter.java4
-rw-r--r--analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableDeadline.java4
-rw-r--r--analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableTimer.java8
-rw-r--r--analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/Activator.java21
-rw-r--r--analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineAnalysis.java14
-rw-r--r--analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineUtils.java6
-rw-r--r--scripting/org.eclipse.tracecompass.incubator.scripting.ui.tests/perf/org/eclipse/tracecompass/incubator/scripting/core/tests/perf/ScriptingBenchmark.java7
-rw-r--r--tracetypes/org.eclipse.tracecompass.incubator.ros.core/src/org/eclipse/tracecompass/incubator/internal/ros/core/analysis/AbstractRosStateProvider.java3
-rw-r--r--vm/org.eclipse.tracecompass.incubator.virtual.machine.analysis.ui/src/org/eclipse/tracecompass/incubator/internal/virtual/machine/analysis/ui/views/vresources/VirtualResourcesView.java5
11 files changed, 61 insertions, 38 deletions
diff --git a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/builder/BuilderInstanceGroup.java b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/builder/BuilderInstanceGroup.java
index 8e53d854c..eae391413 100644
--- a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/builder/BuilderInstanceGroup.java
+++ b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/builder/BuilderInstanceGroup.java
@@ -277,12 +277,12 @@ public class BuilderInstanceGroup {
eventListPerGroup.add(st.getLongestNonOverlappingRepeatedSubstringWithoutRepeat());
} else {
Collection<List<BuilderEventInfo>> lcsGroups = getLCSgroups();
- System.out.println("DEBUG: Group NB = " + lcsGroups.size()); //$NON-NLS-1$ //
+ Activator.logInfo("DEBUG: Group NB = " + lcsGroups.size()); //$NON-NLS-1$ //
// FIXME:
// DEBUG
// OUTPUT
double groupingRate = (eventsPerTid.size() - lcsGroups.size()) * 1. / eventsPerTid.size();
- System.out.println("DEBUG: Grouping rate = " + groupingRate); //$NON-NLS-1$ //
+ Activator.logInfo("DEBUG: Grouping rate = " + groupingRate); //$NON-NLS-1$ //
// FIXME:
// DEBUG
// OUTPUT
@@ -299,7 +299,7 @@ public class BuilderInstanceGroup {
.max((s0, s1) -> Integer.compare(s0, s1))
.orElse(0);
- System.out.println("DEBUG: Max number of content = " + maxNumberOfContent); //$NON-NLS-1$ //
+ Activator.logInfo("DEBUG: Max number of content = " + maxNumberOfContent); //$NON-NLS-1$ //
// FIXME:
// DEBUG
// OUTPUT
@@ -308,11 +308,11 @@ public class BuilderInstanceGroup {
// names
Collection<List<BuilderEventInfo>> idealLcsGroups = getLCSgroups(new BuilderEventInfoNameEqualityRunner());
double idealGroupingRate = (eventsPerTid.size() - idealLcsGroups.size()) * 1. / eventsPerTid.size();
- System.out.println("DEBUG: Ideal group NB = " + idealLcsGroups.size()); //$NON-NLS-1$ //
+ Activator.logInfo("DEBUG: Ideal group NB = " + idealLcsGroups.size()); //$NON-NLS-1$ //
// FIXME:
// DEBUG
// OUTPUT
- System.out.println("DEBUG: Ideal grouping rate = " + idealGroupingRate); //$NON-NLS-1$ //
+ Activator.logInfo("DEBUG: Ideal grouping rate = " + idealGroupingRate); //$NON-NLS-1$ //
// FIXME:
// DEBUG
// OUTPUT
@@ -346,11 +346,11 @@ public class BuilderInstanceGroup {
}
}
- System.out.println("DEBUG: Final group NB = " + lcsGroups.size()); //$NON-NLS-1$ //
+ Activator.logInfo("DEBUG: Final group NB = " + lcsGroups.size()); //$NON-NLS-1$ //
// FIXME:
// DEBUG
// OUTPUT
- System.out.println("DEBUG: Final grouping rate = " + groupingRate); //$NON-NLS-1$ //
+ Activator.logInfo("DEBUG: Final grouping rate = " + groupingRate); //$NON-NLS-1$ //
// FIXME:
// DEBUG
// OUTPUT
@@ -367,10 +367,11 @@ public class BuilderInstanceGroup {
/**
* Test
*/
+ @SuppressWarnings("null")
public void doTest() {
- System.out.println("DEBUG: Number of instances: " + eventsPerTid.size()); //$NON-NLS-1$
+ Activator.logInfo("DEBUG: Number of instances: " + eventsPerTid.size()); //$NON-NLS-1$
for (Entry<Integer, List<BuilderEventInfo>> entry : eventsPerTid.entrySet()) {
- System.out.println("DEBUG: - instance " + entry.getKey() + ": " + entry.getValue().size() + " events"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
+ Activator.logInfo("DEBUG: - instance " + entry.getKey() + ": " + entry.getValue().size() + " events"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
/*
* for (int i = 0; i < entry.getValue().size(); i++) {
* System.out.println(" - event "+i+": " +
@@ -419,7 +420,7 @@ public class BuilderInstanceGroup {
StateMachineInstanceGroup smig = new StateMachineInstanceGroup(initialTransitions, stateMachineBackendAnalysis, lttngKernelExecutionGraphModules);
smig.buildOn(fExperiment);
- System.out.println(
+ Activator.logInfo(
StateMachineToDot.drawStateMachine(initialTransitions));
System.exit(0);
diff --git a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableAnalysis.java b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableAnalysis.java
index f04074d1e..9243b1422 100644
--- a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableAnalysis.java
+++ b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableAnalysis.java
@@ -1156,7 +1156,7 @@ public class StateMachineVariableAnalysis {
}
if (validIds == null || iis.isEmpty()) {
- System.out.println("Not enough information for a comparison"); //$NON-NLS-1$
+ Activator.getInstance().logWarning("Not enough information for a comparison"); //$NON-NLS-1$
continue;
}
@@ -1286,7 +1286,7 @@ public class StateMachineVariableAnalysis {
// Get the general graph for the trace
TmfGraph graph = g.getGraph();
if (graph == null) {
- System.out.println("graph == null"); //$NON-NLS-1$
+ Activator.getInstance().logWarning("graph == null"); //$NON-NLS-1$
continue;
}
graphFound = true;
@@ -1304,7 +1304,7 @@ public class StateMachineVariableAnalysis {
}
if (lw == null) {
- System.out.println("lw == null"); //$NON-NLS-1$
+ Activator.getInstance().logWarning("lw == null"); //$NON-NLS-1$
continue;
}
workerFound = true;
diff --git a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableCounter.java b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableCounter.java
index a5e9e2a64..4181c660d 100644
--- a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableCounter.java
+++ b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableCounter.java
@@ -185,7 +185,7 @@ public abstract class StateMachineVariableCounter extends StateMachineVariable {
// Treat only constants for now
// TODO: treat comparison between variables
if (constraint.getValueType() != ValueType.CONSTANT) {
- System.out.println("TODO"); //$NON-NLS-1$
+ Activator.logWarning("TODO"); //$NON-NLS-1$
return null;
}
@@ -219,7 +219,7 @@ public abstract class StateMachineVariableCounter extends StateMachineVariable {
}
} else {
if (validIsiList == null || validIsiList.isEmpty()) {
- System.out.print("No valid instance for a full analysis"); //$NON-NLS-1$
+ Activator.logWarning("No valid instance for a full analysis"); //$NON-NLS-1$
return null;
}
diff --git a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableDeadline.java b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableDeadline.java
index a1a815b9c..78e0f5980 100644
--- a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableDeadline.java
+++ b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableDeadline.java
@@ -159,11 +159,11 @@ public class StateMachineVariableDeadline extends StateMachineVariable {
// Treat only constants for now
// TODO: treat comparison between variables
if (constraint.getValueType() != ValueType.CONSTANT) {
- System.out.println("TODO"); //$NON-NLS-1$
+ Activator.logWarning("TODO"); //$NON-NLS-1$
return null;
}
if (validIsiList == null || validIsiList.isEmpty()) {
- System.out.print("No valid instance"); //$NON-NLS-1$
+ Activator.logWarning("No valid instance"); //$NON-NLS-1$
return null;
}
diff --git a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableTimer.java b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableTimer.java
index 266964c95..093792f60 100644
--- a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableTimer.java
+++ b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/core/statemachine/variable/StateMachineVariableTimer.java
@@ -262,7 +262,7 @@ public abstract class StateMachineVariableTimer extends StateMachineVariable {
// Can't happen
if (e == null) {
- System.out.println("e is null and can't be null... what happened?!"); //$NON-NLS-1$
+ Activator.logWarning("e is null and can't be null... what happened?!"); //$NON-NLS-1$
return null;
}
@@ -312,7 +312,7 @@ public abstract class StateMachineVariableTimer extends StateMachineVariable {
* error. If not, add it to the list.
*/
if (e.getTimestamp().getValue() > seek) {
- System.out.println("Didn't find the event at " + seek); //$NON-NLS-1$
+ Activator.logWarning("Didn't find the event at " + seek); //$NON-NLS-1$
} else {
ITmfEventField content = e.getContent();
int tasktid = Integer.parseInt(content.getField(layout.fieldNextTid()).getFormattedValue());
@@ -390,7 +390,7 @@ public abstract class StateMachineVariableTimer extends StateMachineVariable {
// Treat only constants for now
// TODO: treat comparison between variables
if (constraint.getValueType() != ValueType.CONSTANT) {
- System.out.println("TODO"); //$NON-NLS-1$
+ Activator.logWarning("TODO"); //$NON-NLS-1$
return null;
}
@@ -418,7 +418,7 @@ public abstract class StateMachineVariableTimer extends StateMachineVariable {
}
} else {
if (validIsiList == null || validIsiList.isEmpty()) {
- System.out.print("No valid instance for a full analysis"); //$NON-NLS-1$
+ Activator.logWarning("No valid instance for a full analysis"); //$NON-NLS-1$
return null;
}
diff --git a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/Activator.java b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/Activator.java
index ea5561c2c..7f38eb85e 100644
--- a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/Activator.java
+++ b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/Activator.java
@@ -84,6 +84,27 @@ public class Activator extends AbstractUIPlugin {
}
/**
+ * Logs a message with severity INFO in the runtime log of the plug-in.
+ *
+ * @param message
+ * A message to log
+ */
+ public static void logInfo(String message) {
+ Objects.requireNonNull(plugin).getLog().log(new Status(IStatus.INFO, PLUGIN_ID, message));
+ }
+
+ /**
+ * Logs a message and exception with severity WARNING in the runtime log of
+ * the plug-in.
+ *
+ * @param message
+ * A message to log
+ */
+ public static void logWarning(@Nullable String message) {
+ Objects.requireNonNull(plugin).getLog().log(new Status(IStatus.WARNING, PLUGIN_ID, message));
+ }
+
+ /**
* Logs a message and exception with severity ERROR in the runtime log of
* the plug-in.
*
diff --git a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineAnalysis.java b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineAnalysis.java
index 1f0d7367b..f33aee196 100644
--- a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineAnalysis.java
+++ b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineAnalysis.java
@@ -165,11 +165,11 @@ public class StateMachineAnalysis extends AbstractSegmentStoreAnalysisModule {
if (kernelAnalysisModule != null) {
IStatus status = kernelAnalysisModule.schedule();
if (!status.isOK()) {
- System.out.println("kernelAnalysisModule status is not ok");
+ Activator.logWarning("kernelAnalysisModule status is not ok");
}
} else {
- System.out.println("kernelAnalysisModule is null");
+ Activator.logWarning("kernelAnalysisModule is null");
}
}
@@ -184,10 +184,10 @@ public class StateMachineAnalysis extends AbstractSegmentStoreAnalysisModule {
if (status.isOK()) {
stateMachineBackendAnalysis.waitForCompletion();
} else {
- System.out.println("stateMachineAnalysisModule status is not ok");
+ Activator.logWarning("stateMachineAnalysisModule status is not ok");
}
} else {
- System.out.println("stateMachineAnalysisModule is null");
+ Activator.logWarning("stateMachineAnalysisModule is null");
}
}
@@ -201,10 +201,10 @@ public class StateMachineAnalysis extends AbstractSegmentStoreAnalysisModule {
if (criticalPathAnalysisModule != null) {
IStatus status = criticalPathAnalysisModule.schedule();
if (!status.isOK()) {
- System.out.println("fModuleCriticalPath status is not ok");
+ Activator.logWarning("fModuleCriticalPath status is not ok");
}
} else {
- System.out.println("fModuleCriticalPath is null");
+ Activator.logWarning("fModuleCriticalPath is null");
}
}
@@ -454,7 +454,7 @@ public class StateMachineAnalysis extends AbstractSegmentStoreAnalysisModule {
}
}
if (print) {
- System.out.println(smig.toString());
+ Activator.logWarning(smig.toString());
}
benchmarkObject.stop();
diff --git a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineUtils.java b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineUtils.java
index 9477d524c..bf4d70c75 100644
--- a/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineUtils.java
+++ b/analyses/org.eclipse.tracecompass.incubator.xaf.ui/src/org/eclipse/tracecompass/incubator/internal/xaf/ui/statemachine/StateMachineUtils.java
@@ -102,7 +102,7 @@ public final class StateMachineUtils {
String targetNode = targetAttribute.getNodeValue();
StateMachineNode nextNode = nodeList.get(targetNode);
if (nextNode == null) {
- System.out.println("Transition to unknown node: "+targetNode); //$NON-NLS-1$
+ Activator.logWarning("Transition to unknown node: "+targetNode); //$NON-NLS-1$
continue;
}
@@ -117,7 +117,7 @@ public final class StateMachineUtils {
Matcher m = CONDITION_PATTERN.matcher(condition);
if (!m.find()) {
- System.out.println("Unmatching condition: "+condition); //$NON-NLS-1$
+ Activator.logWarning("Unmatching condition: "+condition); //$NON-NLS-1$
continue;
}
@@ -182,7 +182,7 @@ public final class StateMachineUtils {
String name = id.getNodeValue();
if (nodeList.containsKey(name)) {
- System.out.println("Node "+name+" already exists"); //$NON-NLS-1$ //$NON-NLS-2$
+ Activator.logWarning("Node "+name+" already exists"); //$NON-NLS-1$ //$NON-NLS-2$
}
nodeList.put(name, new StateMachineNode(name));
diff --git a/scripting/org.eclipse.tracecompass.incubator.scripting.ui.tests/perf/org/eclipse/tracecompass/incubator/scripting/core/tests/perf/ScriptingBenchmark.java b/scripting/org.eclipse.tracecompass.incubator.scripting.ui.tests/perf/org/eclipse/tracecompass/incubator/scripting/core/tests/perf/ScriptingBenchmark.java
index e32ef4c79..53bda2144 100644
--- a/scripting/org.eclipse.tracecompass.incubator.scripting.ui.tests/perf/org/eclipse/tracecompass/incubator/scripting/core/tests/perf/ScriptingBenchmark.java
+++ b/scripting/org.eclipse.tracecompass.incubator.scripting.ui.tests/perf/org/eclipse/tracecompass/incubator/scripting/core/tests/perf/ScriptingBenchmark.java
@@ -35,6 +35,7 @@ import org.eclipse.test.performance.Performance;
import org.eclipse.test.performance.PerformanceMeter;
import org.eclipse.tracecompass.analysis.os.linux.core.tid.TidAnalysisModule;
import org.eclipse.tracecompass.ctf.core.tests.shared.CtfBenchmarkTrace;
+import org.eclipse.tracecompass.incubator.internal.scripting.core.Activator;
import org.eclipse.tracecompass.incubator.internal.scripting.core.ScriptExecutionHelper;
import org.eclipse.tracecompass.incubator.scripting.core.trace.ScriptEventsIterator;
import org.eclipse.tracecompass.incubator.scripting.core.trace.TraceScriptingModule;
@@ -139,7 +140,7 @@ public class ScriptingBenchmark {
private static final Runnable EMPTY = () -> {
// Do nothing much, to benchmark script initialization
int i = 0;
- System.out.println(i);
+ Activator.getInstance().logInfo(Integer.toString(i));
};
private static final Runnable SIMPLE_COMPUTATION = () -> {
@@ -201,7 +202,7 @@ public class ScriptingBenchmark {
schedSwitchCnt++;
}
}
- System.out.println("Count sched switch: " + schedSwitchCnt);
+ Activator.getInstance().logInfo("Count sched switch: " + schedSwitchCnt);
} catch (TmfTraceException e) {
fail(e.getMessage());
} finally {
@@ -459,7 +460,7 @@ public class ScriptingBenchmark {
pmPython.start();
ScriptExecutionHelper.executeScript(Objects.requireNonNull(absoluteFilePath.toOSString()), JYTHON_ENGINE, fArguments);
pmPython.stop();
- System.out.println("Did iteration " + i);
+ Activator.getInstance().logInfo("Did iteration " + i);
}
pmPython.commit();
}
diff --git a/tracetypes/org.eclipse.tracecompass.incubator.ros.core/src/org/eclipse/tracecompass/incubator/internal/ros/core/analysis/AbstractRosStateProvider.java b/tracetypes/org.eclipse.tracecompass.incubator.ros.core/src/org/eclipse/tracecompass/incubator/internal/ros/core/analysis/AbstractRosStateProvider.java
index 021dc3c4b..277dc8b69 100644
--- a/tracetypes/org.eclipse.tracecompass.incubator.ros.core/src/org/eclipse/tracecompass/incubator/internal/ros/core/analysis/AbstractRosStateProvider.java
+++ b/tracetypes/org.eclipse.tracecompass.incubator.ros.core/src/org/eclipse/tracecompass/incubator/internal/ros/core/analysis/AbstractRosStateProvider.java
@@ -17,6 +17,7 @@ import java.util.Objects;
import org.apache.commons.lang3.StringUtils;
import org.eclipse.jdt.annotation.NonNull;
import org.eclipse.jdt.annotation.Nullable;
+import org.eclipse.tracecompass.incubator.internal.ros.core.Activator;
import org.eclipse.tracecompass.incubator.internal.ros.core.trace.layout.IRosEventLayout;
import org.eclipse.tracecompass.tmf.core.event.ITmfEvent;
import org.eclipse.tracecompass.tmf.core.statesystem.AbstractTmfStateProvider;
@@ -133,7 +134,7 @@ public abstract class AbstractRosStateProvider extends AbstractTmfStateProvider
protected static Object getField(@NonNull ITmfEvent event, @NonNull String fieldName) {
Object val = event.getContent().getFieldValue(Object.class, fieldName);
if (val == null) {
- System.out.println("woops"); //$NON-NLS-1$
+ Activator.getInstance().logWarning("woops"); //$NON-NLS-1$
}
return val;
}
diff --git a/vm/org.eclipse.tracecompass.incubator.virtual.machine.analysis.ui/src/org/eclipse/tracecompass/incubator/internal/virtual/machine/analysis/ui/views/vresources/VirtualResourcesView.java b/vm/org.eclipse.tracecompass.incubator.virtual.machine.analysis.ui/src/org/eclipse/tracecompass/incubator/internal/virtual/machine/analysis/ui/views/vresources/VirtualResourcesView.java
index bb4a421ab..f8cd1bc93 100644
--- a/vm/org.eclipse.tracecompass.incubator.virtual.machine.analysis.ui/src/org/eclipse/tracecompass/incubator/internal/virtual/machine/analysis/ui/views/vresources/VirtualResourcesView.java
+++ b/vm/org.eclipse.tracecompass.incubator.virtual.machine.analysis.ui/src/org/eclipse/tracecompass/incubator/internal/virtual/machine/analysis/ui/views/vresources/VirtualResourcesView.java
@@ -862,9 +862,8 @@ public class VirtualResourcesView extends AbstractStateSystemTimeGraphView {
long begin = getBeginSelectedTime();
long end = getEndSelectedTime();
- System.out.println("Begin time: " + FormatTimeUtils.formatTime(begin, FormatTimeUtils.TimeFormat.CALENDAR, FormatTimeUtils.Resolution.NANOSEC)); //$NON-NLS-1$
- System.out.println("End time: " + FormatTimeUtils.formatTime(end, FormatTimeUtils.TimeFormat.CALENDAR, FormatTimeUtils.Resolution.NANOSEC)); //$NON-NLS-1$
- System.out.println();
+ Activator.getDefault().logInfo("Begin time: " + FormatTimeUtils.formatTime(begin, FormatTimeUtils.TimeFormat.CALENDAR, FormatTimeUtils.Resolution.NANOSEC)); //$NON-NLS-1$
+ Activator.getDefault().logInfo("End time: " + FormatTimeUtils.formatTime(end, FormatTimeUtils.TimeFormat.CALENDAR, FormatTimeUtils.Resolution.NANOSEC)); //$NON-NLS-1$
}

Back to the top