Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-05-03Stop using jaxb's DatatypeConverterJonah Graham1-3/+8
jaxb is not standard anymore, and having a dependency just for this simple method is overkill. This is also a workaround for Bug 579817. Change-Id: Ic0db6e595b8faa9323c26d29f8caedc0ac4b089e
2021-12-05Fix usage or reserved symbols (<>&) in javadocTorbjörn Svensson2-11/+11
Contributed by STMicroelectronics Change-Id: Ifdf90e316d7537848bea8253973864f070b19b1c Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2021-02-25Bug 571472: Don't resolve multi-line stringsJonah Graham1-0/+8
Change-Id: Id6a8b208cb6bc965a2c8d781ba41bca3b3094685
2021-02-03[releng] Fixup API error due to missing verion bumpJonah Graham1-1/+1
Change-Id: I149aeb8f148f0f223e7ec09a73e153df5be68836
2021-01-14Bug 569581 - Rethrow IOException in ElfParser.hasInterpProgramHeader()Simeon Andreev2-3/+19
This change adjusts behavior in ElfParser.hasInterpProgramHeader() (added for bug 512822) to throw an IOException that occurred, as opposed to logging the exception and continuing. This excludes exceptions thrown by Elf.getSections() indicating that ELFhdr.ELFCLASSNONE is read; a new, more specific IOException type is defined to allow handling this as a special case. A "generic" IOException indicates an I/O problem with the binary. E.g. the binary can be deleted by the user or by Eclipse, while being visited in CModelManager. If hasInterpProgramHeader() returns instead of throwing, more problems can occur "later on". Change-Id: I8852d9cbaa17dc97f668bb1666e9b046bbde1fca Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2020-11-03Bug 530194: Don't assume that dwarf headers have valid positionsJonah Graham1-2/+6
In cases where the dwarf headers say there is data at a position that does not exist, the position call throws an exception. Prior to this patch that exception, being a runtime exception, can cause the whole IDE to exit in the case that the standalone debugger is used. Change-Id: I7e12667890490a49ecd63785ea2cc7c02c08679d
2020-09-01Bug 553674: Make Binary parsers and related classes AutocloseableJonah Graham27-141/+176
And prepare to make it an error in CDT to not have properly handled an Autocloseable which means a number of fixes to make sure handles are closed. Change-Id: I36cd46017bbce6ece1703d688d7754e523eca68f
2020-08-30bug 560330 remove \${ "to not resolve" functionalityjantje1-29/+15
This change causes incompatibility for users using the \${ to not expand environment variables. Tested with sloeber (700+ projects) Change-Id: If327f055a41c309c475e17e0239a30e7518c3b23 Signed-off-by: jantje <eclipse@baeyens.it>
2020-08-18Bug 564123 Treat environment and build variable case sensitivelyjantje2-7/+0
Remove all equalIgnoreCase and equal with uppercasing for environment variables Change-Id: Ic15974b5fb62413c7b1826ced544ff6d4a8eba2f Signed-off-by: jantje <eclipse@baeyens.it>
2020-06-16Bug 564232 - Add cpu risc for RISC-V need to support.Aijun Shi1-0/+6
Change-Id: Ib62ed14f3c0dbe4375da41dba7209b27e034c53e Signed-off-by: Aijun Shi <Aijun.Shi@windriver.com>
2020-06-13Bug 564272: Increment major version of org.eclipse.cdt.core to 7.0.0Jonah Graham2-3/+3
Change-Id: I9124dd406c5981435a72ff4aaa7033f1c3d1979b
2020-06-13Bug 564123 delete org.eclipse.cdt.utils.Platformjantje2-114/+1
The class overrode org.eclipse.core.runtime.Platform to workaround bugs in the platform that have since been fixed. As 32-bit x86 and PPC support has been removed this class is no longer needed as all the code is now unreachable anyway. Change-Id: I01bb00b9203aa02663ff25ce36c4c14f22dadee5 Signed-off-by: jantje <eclipse@baeyens.it>
2020-05-11Bug 561789 - Introduce ElfSymbolIteratorMatthew Khouzam2-41/+131
This allows symbol reading on larger executables without hitting an out of memory error Note: this should not close the bug, it is just a first step. Change-Id: I62bb252ff67d88d9bef686760fdc0e9b8240fd02 Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
2020-04-17Bug 561788 - Convert fields into variables in ElfMatthew Khouzam1-2/+2
The fields are not used outside of the loadSymbols section, and they are written before being read, so they should be safely inlineable. Change-Id: I68388227074d80ace283395b48c88c59700dd9da Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
2020-04-11Bug 561992 - Remove dependency to com.ibm.icu from CDT CoreAlexander Fedorov3-10/+10
Switch to JVM classes Remove commented code from CProjectDescriptionManager Change-Id: I53431ba1d5c015b3192fff7249c73e816b8b49ea Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-04-10Bug 561787 - Make Elf parser names inline with java coding styleMatthew Khouzam1-21/+23
Replace under_score with camelCase for private non-api fields Change-Id: Ica0dece19aaaf79d979588266f4c9552ea6d1224 Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
2020-04-10Bug 561788 - Remove useless field in ElfMatthew Khouzam1-5/+0
The syms field is only set and never read outside of getSections. It can safely be removed. Change-Id: I40be61c4d6fab0131bd47134fc444b4306f8b322 Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
2020-04-09Bug 561787 - Declare modifiers in correct order for ElfMatthew Khouzam1-153/+153
The modifiers should be public static final. Change-Id: Iaaede29a68891ab8aeb297b08db78ac13acbc1b8 Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
2020-03-02Revert "Bug 560614 - Drop dependency on ICU4J"Jonah Graham3-3/+6
This reverts commit 87b627bf02eaab28cdb64f6ebe203ac64d18fe94. Change-Id: I54ea1ac766437deb174eeba571a7a5094c180828
2020-03-02Bug 560614 - Drop dependency on ICU4JAlexander Kurtakov3-6/+3
Straightforward conversion. Still usages left that need deeper investigation how to be done proper. Some long time commented code removed as java formatter breaks trailing whitespaces on save. Change-Id: If74259bed5735b0d4cc98fc2cfa609c9c53c80c9 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-02-15Generify some getAdapter implementations.Alexander Kurtakov2-6/+4
Change-Id: I2cd3dad7821e3c6ae3f0371edda5e511beff4014 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-02-14Get rid of some annoying non-Javadoc comments.Alexander Kurtakov29-314/+0
Change-Id: I55b5fcce4948ec17a97a199bb75627e8e7a4c462 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-02-05Bug 559800 - Content in cdt.doc.isv badly outdated and brokenAlexander Kurtakov22-90/+25
Fix javadoc tags. Change-Id: I95a6720777797b4449509f29d00ce836a7c9e103 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-12-02Bug 553667 - Resource leak in ElfParserSimeon Andreev1-1/+10
This change fixes a file descriptor leak in ElfParser.hasInterpProgramHeader(). An Elf object is created without calling its Elf.dispose(). This results in a created RandomAccessFile object, without a respective RandomAccessFile.close() call. Change-Id: I6d2a0911857eb6fcb388b352801c2259ae19171c Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2019-09-03Bug 550076 - Added new parser for PE executablesAdrien Thierry28-2/+3053
This new parser is compatible with both 32 bit and 64 bit executables. Change-Id: Ief9db7c6fcc10ea9e92d5ca58186eb50100d39f6 Signed-off-by: Adrien Thierry <adrien.thierry@spacecodesign.com>
2019-08-12Convert new Runnable to lambda. Alexander Kurtakov4-53/+37
Change-Id: I8b827013a29802a3f3ae6400ddce8d8753eb6399 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-11-22Bug 540373: Remove '(non-Javadoc)' commentsJonah Graham12-232/+0
These were inserted in the past automatically by Eclipse but newer tooling makes them redundant. These were removed by doing a global find/replace on *.java files using the following regular expression: \t/\*\n\t \* \(non-Javadoc\)[^/]*/\n Change-Id: I59d3248020f10934fde1dda5b5a31e20bb188e19
2018-11-22Bug 540373: Cleanup: Remove redundant type argumentsJonah Graham44-113/+113
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Remove redundant type arguments and completing the wizard Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
2018-11-22Bug 540373: Cleanup: Organize ImportsJonah Graham15-22/+23
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Organize Imports and completing the wizard Change-Id: Ia7b305a4c967d0e6f4e8fb8c1041e7028b24006c
2018-11-22Bug 540373: Cleanup: Format & Remove trailing whitespaceJonah Graham132-6005/+5689
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Format source code - Remove trailing white spaces on all lines and completing the wizard Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
2018-11-22Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.shJonah Graham133-399/+798
Change-Id: Ifbb1d5af2a00bd5634dea200320e8c4303ffca6c
2018-11-20Bug 540373: Normalize newlines with .gitattributesJonah Graham1-27/+27
There is also a new script to verify completeness of .gitattributes: releng/scripts/verify_gitattributes.sh Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
2018-09-27Bug 512822: "Launch failed. Binary not found" even after buildingHansruedi Patzen2-18/+70
Builds upon https://git.eclipse.org/r/#/c/92129/ but also uses the hints to only read the file if necessary. I further reverted some of the changes done with the patch for 'Bug 510987 - Properly support PIE executables as build output' since the binary will now be seen as an executable anyway. Change-Id: I075fef67f3b101ddbc64786dcbc2ca41cc114e25 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
2018-07-23Bug 535911: Better error in the presence of compressed ELF sectionMarc-Andre Laperle1-1/+17
This doesn't implement reading compressed ELF section, but at least it gives a more useful error instead of a simple "IllegalArgumentException" with no clue. Change-Id: Ib0ee1ab9e3aed7aeba184f13262b59ef21afcd32 Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
2017-05-31Bug 517581 Keep env var operation on merged vars the same.Doug Schaefer1-8/+12
If we are merging two env vars and the operations are both append or prepend, keep that as the operation instead of replace. Change-Id: I758a54b8903eabafac38bf2f3f7d7065c0373e70
2017-03-23Generify ListenerList.Alexander Kurtakov1-4/+4
Generified, some lamnda conversions and some non-javadoc removal. Change-Id: Ibf0493917ac3da7531de1ca591a9bfdc250ddf2a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-11-15Bug 494246: prepare command line arguments properly for Windows GDBJonah Graham1-2/+162
Includes splitting out and expanding CommandLineArgsTest from LaunchConfigurationAndRestartTest. Change-Id: I19fa97a847d908c1c780ca767cf688f26a51d684 Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2016-11-15CosmeticsJonah Graham1-132/+139
Change-Id: I8036046d2e755de2e77ef5bf6502008d4ada0e49
2016-05-09fixed elf parsing of 2G+ filesAlena Laskavaia2-16/+25
32 bit elf parser of 2G+ elf files does not read some field properties because it does signed extension when reading unsigned integer Change-Id: I64b47cc0849d4fb41daec258b2a595003b9de734
2016-04-25Bug 492304 - Fix NLS warningsAlex Blewitt5-8/+8
Eclipse warns if a String literal does not have a `//$NON-NLS-<n>$` entry at the end of the line. However, for historic or formatting reasons, many such occurrences in the CDT source have an intermediate whitespace, such as `// $NON-NLS-<n>$` Fix these so that the whitespace is removed between the // and $ characters. Change-Id: Idc12398fe6e9d619af1d0b1b73fb8b6180da223c Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-25Bug 492230 - Replace buffer.append(a+b) callsAlex Blewitt2-8/+8
When using a `StringBuilder` or `StringBuffer` to create a string message, using implicit string concatenation inside an `.append()` call will create a nested StringBuilder for the purposes of creating the arguments, which will subsequently be converted to a String and then passed to the outer StringBuilder. Skip the creation of the intermediate object and String by simply replacing such calls with `buffer.append(a).append(b)`. Where values are compile time String constants, leave as is so that the javac compiler can perform compile-time String concatenation. Ensure that NEWLINE isn't appended in such a way since it is not a compile time constant `System.getProperty("line.separator")` Change-Id: I4126aefb2272f06b08332e004d7ea76b6f02cdba Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-21Bug 492200 - Replace StringBuffer with StringBuilderAlex Blewitt30-95/+95
There are many opportunities for replacing `StringBuffer` with `StringBuilder` provided that the type isn't visible from the public API and is used only in internal methods. Replace these where appropriate. Change-Id: I2634593603eef88dd68e127de9319377f43e7436 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-19Bug 491984 - Replace .equals("") with .isEmpty()Alex Blewitt2-4/+4
In many cases a String's empty status is tested with `.equals("")`. However, Java 1.6 added `.isEmpty()` which can be more efficient since it compares the internal length parameter only for testing. Replace code using the `.isEmpty()` variant instead. Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()` where it is already known that the `expr` is not null; however, these have to be reviewed on a case-by-case basis. Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-18Bug 491945 - Remove new String() literalsAlex Blewitt3-6/+6
Occurrences of `new String("...")` have been replaced with a direct reference to the literal it was wrapping. Change-Id: Iefb49a009f210db59e5724e0a232dba2e13292b1 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-18Bug 491945 - Remove new String()Alex Blewitt5-12/+12
Occurrences of `new String()` have been replaced with the equivalent `""` and additional NON-NLS tags have been inserted in where appropriate. Change-Id: I54cf71dcd0d5a92a675a71166d66949533de502b Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-16Bug 491825 - Remove primitive wrapper creationAlex Blewitt6-34/+34
Using `new Integer` and other wrapper types such as `new Character` results in potential extra heap utilisation as the values are not cached. The built-in `Integer.valueOf` will perform caching on numbers in the range -128..127 (at least) using a flyweight pattern. In addition, parsing `int` values can be done with `Integer.parseInt` which avoids object construction. Adjust tests such as `"true".equals(expr)` to `Boolean.parseBoolean(expr)`. Change-Id: I0408a5c69afc4ca6ede71acaf6cc4abd67538006 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-15Bug 491825 - Remove uses of new Boolean and friendsSergey Prigogin2-4/+4
Change-Id: Ie358c8385c278472f3b86851f6fc219007bb9b5c
2016-02-17Incremented version of org.eclipse.cdt.core to 6.0.Sergey Prigogin1-9/+9
Change-Id: I059e7eba9eff7f24c84e08a1cbf658381aaaf19d
2016-01-04Fix copyright of all CDT plugins using the copyright tool from platform.Marc Khouzam55-55/+55
This commit does not add missing copyrights, just updates the date on the existing ones. Change-Id: I646f5afd533a1fcc539bdf2e0686b22f406ecf65
2015-11-13Generify getAdapter methods.Alexander Kurtakov11-89/+47
Not all instances handled but the patch is big enough already. Drop the useless casts thanks to the generification too. Change-Id: I608c93a317135a8738ad770de71d9c3cda24791a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>

Back to the top