Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimeon Andreev2021-08-26 11:00:59 +0000
committerAndrey Loskutov2021-09-10 13:24:45 +0000
commitda794b14e7a65109b83b672b9bf6d1712395dcc5 (patch)
treefdf12e77604d3925758ff5cd1c24dd8522aa75d9 /bundles/org.eclipse.ui.workbench/Eclipse UI
parent5aad9b86427b36620726ce409778badb0bc81085 (diff)
downloadeclipse.platform.ui-da794b14e7a65109b83b672b9bf6d1712395dcc5.tar.gz
eclipse.platform.ui-da794b14e7a65109b83b672b9bf6d1712395dcc5.tar.xz
eclipse.platform.ui-da794b14e7a65109b83b672b9bf6d1712395dcc5.zip
Bug 575616 - OutOfMemoryError on part create causes more exceptions/hang
This change makes CompatibilityPart.create() catch not only RuntimeException, but also Throwable, to avoid a broken UI if e.g. an OutOfMemoryError is thrown. Change-Id: I6ef8de45862297b673c75d44b0fa12a777157e63 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/184447 Tested-by: Andrey Loskutov <loskutov@gmx.de> Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
Diffstat (limited to 'bundles/org.eclipse.ui.workbench/Eclipse UI')
-rw-r--r--bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/compatibility/CompatibilityPart.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/compatibility/CompatibilityPart.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/compatibility/CompatibilityPart.java
index c1e7e8b6013..89e328bb2ec 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/compatibility/CompatibilityPart.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/compatibility/CompatibilityPart.java
@@ -346,7 +346,7 @@ public abstract class CompatibilityPart implements ISelectionChangedListener {
if (!handlePartInitException(e)) {
return;
}
- } catch (RuntimeException e) {
+ } catch (Throwable e) {
if (!handlePartInitException(new PartInitException(e.getMessage(), e))) {
return;
}

Back to the top