diff options
| author | Lars Vogel | 2020-10-23 08:26:48 +0000 |
|---|---|---|
| committer | Lars Vogel | 2020-10-23 14:04:21 +0000 |
| commit | abb39f27b214586ab408f1a8fec20c769b6fe7d0 (patch) | |
| tree | e2457b3827e17fe285894838caac092a224f79d1 | |
| parent | c402d54c3aca05bc617898a66916766bc857d5a9 (diff) | |
| download | eclipse.platform.ui-abb39f27b214586ab408f1a8fec20c769b6fe7d0.tar.gz eclipse.platform.ui-abb39f27b214586ab408f1a8fec20c769b6fe7d0.tar.xz eclipse.platform.ui-abb39f27b214586ab408f1a8fec20c769b6fe7d0.zip | |
Bug 378488 - "Open With > ..." should not store the default editorY20201023-1200I20201023-1800
"Open With > ..." currently stores the selected editor as default editor
for the selected file. This is wrong in 99.9% of usages according to the
Bug report to which I agree.
The main usage scenarios for Open With > ... are:
1.) Open the file with a different editor this time (but keep the
default).
2.) Always open similar files with the chosen editor.
Scenario 2 can be supported with bug 378485 if the "Open With >
Other..." dialog comes up with the current default editor pre-selected.
This simply removes this option without trying to add yet another power
user option via additional control key or additional menu items as we
already have too many of these hard to discover features.
Change-Id: Idb9a80309ffb408a3448a1f752a4ceb40aa0fdf9
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
| -rw-r--r-- | bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/OpenWithMenu.java | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/OpenWithMenu.java b/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/OpenWithMenu.java index b5fdee2bc78..35757102d55 100644 --- a/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/OpenWithMenu.java +++ b/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/OpenWithMenu.java @@ -322,8 +322,6 @@ public class OpenWithMenu extends ContributionItem { : editorDescriptor.getId(); page.openEditor(new FileEditorInput(file), editorId, true, MATCH_BOTH); - // only remember the default editor if the open succeeds - IDE.setDefaultEditor(file, editorId); } } catch (PartInitException e) { DialogUtil.openError(page.getWorkbenchWindow().getShell(), |