Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBoris Bokowski2007-02-02 04:23:08 +0000
committerBoris Bokowski2007-02-02 04:23:08 +0000
commit78fab6e1435da15485c9cb7155593635fee0979d (patch)
treedc49f6a6c3e5b510dfc0f167b9d205bfcd2d307d
parent278f0378adab90e1d8846b9a8d5a4b23eb96320d (diff)
downloadeclipse.platform.ui-78fab6e1435da15485c9cb7155593635fee0979d.tar.gz
eclipse.platform.ui-78fab6e1435da15485c9cb7155593635fee0979d.tar.xz
eclipse.platform.ui-78fab6e1435da15485c9cb7155593635fee0979d.zip
Fix for Bug 172475 [DataBinding] databinding javadoc warnings in N20070201-0010
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/IObservableCollection.java3
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableEvent.java4
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java3
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java6
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/WritableList.java1
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java1
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapDiff.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ObservableMap.java1
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/WritableSet.java4
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreePath.java3
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/util/ILogger.java4
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java1
-rw-r--r--bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java1
-rwxr-xr-xbundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java2
-rwxr-xr-xbundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java1
-rw-r--r--bundles/org.eclipse.core.databinding/.settings/org.eclipse.jdt.core.prefs7
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java52
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindSpec.java3
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/Binding.java6
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindingEvent.java3
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DefaultBindSpec.java16
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/DateConversionSupport.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/IObservableCollection.java3
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/ObservableEvent.java4
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/Observables.java3
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java6
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/WritableList.java1
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java1
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapDiff.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ObservableMap.java1
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/WritableSet.java4
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreePath.java3
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ComputedValue.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java2
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/util/ILogger.java4
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/ObjectToPrimitiveValidator.java9
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ListBinding.java3
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java1
-rw-r--r--bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java1
-rwxr-xr-xbundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java2
-rwxr-xr-xbundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java1
55 files changed, 60 insertions, 147 deletions
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/IObservableCollection.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/IObservableCollection.java
index 7f228d0d60e..d12c384fb00 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/IObservableCollection.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/IObservableCollection.java
@@ -34,7 +34,8 @@ import org.eclipse.core.databinding.observable.set.IObservableSet;
public interface IObservableCollection extends IObservable, Collection {
/**
- * @return
+ * @return the element type of this observable value, or <code>null</code>
+ * if this observable collection is untyped.
*/
Object getElementType();
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableEvent.java
index 938e4bc4a3a..f1926592571 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableEvent.java
@@ -32,7 +32,7 @@ public abstract class ObservableEvent extends EventObject {
private static final long serialVersionUID = 7693906965267871813L;
/**
- * @return
+ * @return the observable that generated this event
*/
public IObservable getObservable() {
return (IObservable) getSource();
@@ -45,7 +45,7 @@ public abstract class ObservableEvent extends EventObject {
protected abstract void dispatch(IObservablesListener listener);
/**
- * @return
+ * @return a unique object representing the concrete type of this event.
*/
protected abstract Object getListenerType();
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java
index 6b5cbce9f85..9a5abfa347b 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java
@@ -72,7 +72,6 @@ public class Observables {
* Returns an empty observable set. The returned set continues to work after
* it has been disposed of and can be disposed of multiple times.
*
- * @param realm
* @return an empty observable set.
*/
public static IObservableSet emptyObservableSet() {
@@ -91,7 +90,6 @@ public class Observables {
}
/**
- * @param realm
* @param set
* @return Returns an observableSet backed by the given set
*/
@@ -140,7 +138,6 @@ public class Observables {
}
/**
- * @param realm
* @param list
* @return an observable list that never fires events
*/
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
index 5b5bd73e09d..46d9c1fe2d4 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
@@ -24,7 +24,7 @@ public class ListChangeEvent extends ObservableEvent {
*
*/
private static final long serialVersionUID = -9154315534258776672L;
-
+
static final Object TYPE = new Object();
/**
*
@@ -41,14 +41,14 @@ public class ListChangeEvent extends ObservableEvent {
}
/**
- * @return
+ * @return the observable list from which this event originated
*/
public IObservableList getObservableList() {
return (IObservableList) getSource();
}
protected void dispatch(IObservablesListener listener) {
- ((IListChangeListener)listener).handleListChange(this);
+ ((IListChangeListener) listener).handleListChange(this);
}
protected Object getListenerType() {
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/WritableList.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/WritableList.java
index 514d7dd8289..891b983030d 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/WritableList.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/WritableList.java
@@ -34,7 +34,6 @@ public class WritableList extends ObservableList {
* Creates an empty writable list in the default realm with a
* <code>null</code> element type.
*
- * @param realm
*/
public WritableList() {
this(Realm.getDefault());
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java
index 85050c6e02b..207066d85cf 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java
@@ -79,7 +79,6 @@ public class BidirectionalMap extends ObservableMap {
/**
* @param functionValue
* @param element
- * @param b
*/
private void removeMapping(Object functionValue, Object element) {
Object elementOrSet = valueToElements.get(functionValue);
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java
index d1b365d91f4..64690d34ae3 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java
@@ -100,9 +100,7 @@ public abstract class ComputedObservableMap extends AbstractObservableMap {
}
/**
- * @param realm
* @param keySet
- * @param wrappedMap
*/
public ComputedObservableMap(IObservableSet keySet) {
super(keySet.getRealm());
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
index 29165d327b3..959c1bc86c0 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
@@ -40,7 +40,7 @@ public class MapChangeEvent extends ObservableEvent {
}
/**
- * @return
+ * @return the observable map from which this event originated
*/
public IObservableMap getObservableMap() {
return (IObservableMap) getSource();
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapDiff.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapDiff.java
index 828e7a4846e..8aa633f36c5 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapDiff.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapDiff.java
@@ -39,7 +39,6 @@ public abstract class MapDiff {
* {@link #getRemovedKeys()} or {@link #getChangedKeys()}.
*
* @param key
- * @param indices
* @return the old value for the given key.
*/
public abstract Object getOldValue(Object key);
@@ -49,7 +48,6 @@ public abstract class MapDiff {
* {@link #getChangedKeys()} or {@link #getAddedKeys()}.
*
* @param key
- * @param indices
* @return the new value for the given key.
*/
public abstract Object getNewValue(Object key);
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ObservableMap.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ObservableMap.java
index 8edabf0e985..a802d5440a4 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ObservableMap.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/ObservableMap.java
@@ -31,7 +31,6 @@ public class ObservableMap extends AbstractObservable implements IObservableMap
private boolean stale = false;
/**
- * @param realm
* @param wrappedMap
*/
public ObservableMap(Map wrappedMap) {
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
index 95f75f518b0..c0399143226 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
@@ -40,7 +40,7 @@ public class SetChangeEvent extends ObservableEvent {
}
/**
- * @return
+ * @return the observable set from which this event originated
*/
public IObservableSet getObservableSet() {
return (IObservableSet) getSource();
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/WritableSet.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/WritableSet.java
index e4c7e1e7dfd..4f77afe2c3f 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/WritableSet.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/WritableSet.java
@@ -31,8 +31,6 @@ public class WritableSet extends ObservableSet {
* Constructs a new instance with the default realm, empty list, and a
* <code>null</code> element type.
*
- * @param realm
- * @param wrappedSet
*/
public WritableSet() {
this(Realm.getDefault());
@@ -41,7 +39,6 @@ public class WritableSet extends ObservableSet {
/**
* Construts a new instance with the default realm.
*
- * @param realm
* @param c
* @param elementType
* can be <code>null</code>
@@ -54,7 +51,6 @@ public class WritableSet extends ObservableSet {
* Constructs a new instance with an empty list and a <code>null</code> element type.
*
* @param realm
- * @param wrappedSet
*/
public WritableSet(Realm realm) {
this(realm, new HashSet(), null);
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java
index 3a510b5fe03..0290a6c6cc2 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java
@@ -38,7 +38,7 @@ public class TreeChangeEvent extends EventObject {
}
/**
- * @return
+ * @return the observable tree from which this event originated
*/
public IObservableTree getObservable() {
return (IObservableTree) getSource();
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreePath.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreePath.java
index e614584d205..ebc986de551 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreePath.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/tree/TreePath.java
@@ -128,9 +128,6 @@ public final class TreePath {
*
* @param treePath
* path to compare to
- * @param comparer
- * the comparer to use, or <code>null</code> if equals() should
- * be used to compare segments
* @return whether the given path is a prefix of this path, or the same as
* this path
*/
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java
index 84b5c80afb9..7fdffef90e2 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java
@@ -22,7 +22,7 @@ public abstract class AbstractVetoableValue extends AbstractObservableValue
implements IVetoableValue {
/**
- * @param realm
+ * Creates a new vetoable value.
*/
public AbstractVetoableValue() {
this(Realm.getDefault());
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java
index bdaae5ab9ab..37bcf65dcfc 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java
@@ -43,7 +43,6 @@ public abstract class ComputedValue extends AbstractObservableValue {
private IObservable[] dependencies = new IObservable[0];
/**
- * @param realm
*
*/
public ComputedValue() {
@@ -51,7 +50,6 @@ public abstract class ComputedValue extends AbstractObservableValue {
}
/**
- * @param realm
* @param valueType can be <code>null</code>
*/
public ComputedValue(Object valueType) {
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
index 9f589b7bc46..8f0604e072d 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
@@ -42,7 +42,7 @@ public class ValueChangeEvent extends ObservableEvent {
}
/**
- * @return
+ * @return returns the observable value from which this event originated
*/
public IObservableValue getObservableValue() {
return (IObservableValue) source;
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
index 4d5676aaf67..eb3d1c92cfc 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
@@ -47,7 +47,7 @@ public class ValueChangingEvent extends ObservableEvent {
}
/**
- * @return
+ * @return the observable value from which this event originated
*/
public IObservableValue getObservableValue() {
return (IObservableValue) source;
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/util/ILogger.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/util/ILogger.java
index 56ee8f05bd0..6e794fc9713 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/util/ILogger.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/util/ILogger.java
@@ -21,8 +21,8 @@ import org.eclipse.core.runtime.IStatus;
* from within JFace Data Binding.
* </p>
*
- * @see org.eclipse.jface.util.Policy#getLog()
- * @see org.eclipse.jface.util.Policy#setLog(ILogger)
+ * @see Policy#getLog()
+ * @see Policy#setLog(ILogger)
* @since 1.1
*/
public interface ILogger {
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java
index ebf0d372220..93e1145aadb 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java
@@ -39,7 +39,6 @@ public final class ProxyObservableSet extends AbstractObservableSet {
/**
* Constructs a DelegatingObservableSet that tracks the state of the given set.
- * @param realm
*
* @param toDelegate
*/
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java
index 73d73761b7b..87ab6eaccf2 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java
@@ -60,7 +60,6 @@ public class UnmodifiableObservableList extends ObservableList {
/**
* Because this instance is immutable staleness cannot be changed.
*
- * @see org.eclipse.jface.internal.databinding.provisional.observable.list.ObservableList#setStale(boolean)
*/
public void setStale(boolean stale) {
throw new UnsupportedOperationException();
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java
index 6c71cac136f..2825d315193 100755
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java
@@ -53,10 +53,8 @@ public class DetailObservableList extends ObservableList {
private Object detailType;
/**
- * @param realm
* @param factory
* @param outerObservableValue
- * @param feature
* @param detailType
*/
public DetailObservableList(IObservableFactory factory,
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java
index 6e5a1fe3a9e..9e1abeb29ad 100755
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java
@@ -50,7 +50,6 @@ public class DetailObservableValue extends AbstractObservableValue {
* @param outerObservableValue
* @param factory
* @param detailType
- * @param realm
*/
public DetailObservableValue(IObservableValue outerObservableValue,
IObservableFactory factory, Object detailType) {
diff --git a/bundles/org.eclipse.core.databinding/.settings/org.eclipse.jdt.core.prefs b/bundles/org.eclipse.core.databinding/.settings/org.eclipse.jdt.core.prefs
index 5396a6ac659..f1b4e19280f 100644
--- a/bundles/org.eclipse.core.databinding/.settings/org.eclipse.jdt.core.prefs
+++ b/bundles/org.eclipse.core.databinding/.settings/org.eclipse.jdt.core.prefs
@@ -1,4 +1,4 @@
-#Fri Nov 10 16:02:51 EST 2006
+#Thu Feb 01 22:16:54 EST 2007
eclipse.preferences.version=1
org.eclipse.jdt.core.builder.cleanOutputFolder=clean
org.eclipse.jdt.core.builder.duplicateResourceTask=warning
@@ -30,7 +30,8 @@ org.eclipse.jdt.core.compiler.problem.forbiddenReference=error
org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=error
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=error
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=error
-org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=private
@@ -41,7 +42,7 @@ org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=disabled
org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=public
org.eclipse.jdt.core.compiler.problem.missingJavadocTags=error
org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=disabled
-org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=public
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=protected
org.eclipse.jdt.core.compiler.problem.missingSerialVersion=error
org.eclipse.jdt.core.compiler.problem.noEffectAssignment=error
org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=error
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java
index 979078acfa8..df9cbaac9b1 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java
@@ -98,81 +98,51 @@ public final class AggregateValidationStatus implements IObservableValue {
implementation.addValueChangeListener(listener);
}
- /**
- *
- * @see org.eclipse.core.databinding.observable.IObservable#dispose()
- */
public void dispose() {
implementation.dispose();
}
- /**
- * @return
- * @see org.eclipse.core.databinding.observable.IObservable#getRealm()
- */
public Realm getRealm() {
return implementation.getRealm();
}
- /**
- * @return
- * @see org.eclipse.core.databinding.observable.value.IObservableValue#getValue()
- */
public Object getValue() {
return implementation.getValue();
}
- /**
- * @return
- * @see org.eclipse.core.databinding.observable.value.IObservableValue#getValueType()
- */
public Object getValueType() {
return implementation.getValueType();
}
- /**
- * @return
- * @see org.eclipse.core.databinding.observable.IObservable#isStale()
- */
public boolean isStale() {
return implementation.isStale();
}
- /**
- * @param listener
- * @see org.eclipse.core.databinding.observable.IObservable#removeChangeListener(org.eclipse.core.databinding.observable.IChangeListener)
- */
public void removeChangeListener(IChangeListener listener) {
implementation.removeChangeListener(listener);
}
- /**
- * @param listener
- * @see org.eclipse.core.databinding.observable.IObservable#removeStaleListener(org.eclipse.core.databinding.observable.IStaleListener)
- */
public void removeStaleListener(IStaleListener listener) {
implementation.removeStaleListener(listener);
}
- /**
- * @param listener
- * @see org.eclipse.core.databinding.observable.value.IObservableValue#removeValueChangeListener(org.eclipse.core.databinding.observable.value.IValueChangeListener)
- */
public void removeValueChangeListener(IValueChangeListener listener) {
implementation.removeValueChangeListener(listener);
}
- /**
- * @param value
- * @see org.eclipse.core.databinding.observable.value.IObservableValue#setValue(java.lang.Object)
- */
public void setValue(Object value) {
implementation.setValue(value);
}
/**
+ * Returns a status object that merges multiple non-OK status objects in a
+ * {@link MultiStatus}. Returns an OK status result if all statuses from
+ * the given bindings are the an OK status. Returns a single status if there
+ * is only one non-OK status.
+ *
* @param bindings
- * @return
+ * a collection of bindings
+ * @return a merged status
*/
public static IStatus getStatusMerged(Collection bindings) {
List statuses = new ArrayList();
@@ -204,8 +174,14 @@ public final class AggregateValidationStatus implements IObservableValue {
}
/**
+ * Returns a status that always returns the most severe status from the
+ * given bindings. If there is more than one status at the same severity
+ * level, it picks the first one it encounters.
+ *
* @param bindings
- * @return
+ * a collection of bindings
+ * @return a single status reflecting the most severe status from the given
+ * bindings
*/
public static IStatus getStatusMaxSeverity(Collection bindings) {
int maxSeverity = IStatus.OK;
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindSpec.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindSpec.java
index a20cf619a20..4f00fc23f63 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindSpec.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindSpec.java
@@ -19,7 +19,6 @@ import java.util.Map;
import org.eclipse.core.databinding.conversion.IConverter;
import org.eclipse.core.databinding.observable.IObservable;
-import org.eclipse.core.databinding.observable.value.IObservableValue;
import org.eclipse.core.databinding.validation.IValidator;
import org.eclipse.core.runtime.Assert;
import org.eclipse.core.runtime.IStatus;
@@ -248,7 +247,7 @@ public class BindSpec {
/**
* Fills any values not explicitly set with defaults. This implementation of
- * {@link #fillBindSpecDefaults(IObservableValue, IObservableValue)} creates
+ * {@link #fillBindSpecDefaults(IObservable, IObservable)} creates
* validators that always return {@link Status#OK_STATUS}, and converters
* that perform no conversion.
*
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/Binding.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/Binding.java
index 1d74c9bf8ba..03d1670df53 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/Binding.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/Binding.java
@@ -37,7 +37,6 @@ public abstract class Binding {
/**
* Creates a new binding.
*
- * @param context
*/
public Binding() {
}
@@ -213,10 +212,11 @@ public abstract class Binding {
/**
* Returns a new BindingEvent object.
*
- * @param model
- * @param target
* @param diff
+ * a diff object representing the change
* @param copyType
+ * one of {@link BindingEvent#EVENT_COPY_TO_MODEL} or
+ * {@link BindingEvent#EVENT_COPY_TO_TARGET}
* @param pipelinePosition
* The initial processing pipeline position.
* @return the new binding event
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindingEvent.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindingEvent.java
index f80e0aa675a..fd7ad44f406 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindingEvent.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindingEvent.java
@@ -169,8 +169,7 @@ public class BindingEvent extends EventObject {
/**
* (Non-API Method) Construct a BindingEvent.
*
- * @param model
- * @param target
+ * @param binding
* @param diff
* @param copyType
* @param pipelinePosition
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DefaultBindSpec.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DefaultBindSpec.java
index 9ae2d26d8be..136f6e509b7 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DefaultBindSpec.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DefaultBindSpec.java
@@ -215,10 +215,7 @@ public class DefaultBindSpec extends BindSpec {
* Tries to create a converter that can convert from values of type
* fromType. Returns <code>null</code> if no converter could be created.
* Either toType or modelDescription can be <code>null</code>, but not
- * both. The implementation of this method will iterate over the registered
- * bind support factories in reverse order, passing the given arguments to
- * {@link BindSupportFactory#createConverter(Object, Object)}. The first
- * non-null converter will be returned.
+ * both.
*
* @param fromType
* @param toType
@@ -289,7 +286,7 @@ public class DefaultBindSpec extends BindSpec {
}
/**
- * @param pipeline
+ * @param pipelinePosition
* position BindingEvent.PIPELINE_* constant
* @param modelType
* @return an IValidator, or null if unsuccessful
@@ -305,15 +302,10 @@ public class DefaultBindSpec extends BindSpec {
/**
* Tries to create a validator that can validate values of type fromType.
* Returns <code>null</code> if no validator could be created. Either
- * toType or modelDescription can be <code>null</code>, but not both. The
- * implementation of this method will iterate over the registered bind
- * support factories in reverse order, passing the given arguments to
- * {@link BindSupportFactory#createValidator(Class, Class, Object)}. The
- * first non-null validator will be returned.
+ * toType or modelDescription can be <code>null</code>, but not both.
*
* @param fromType
* @param toType
- * @param modelDescription
* @return an IValidator, or <code>null</code> if unsuccessful
*/
protected IValidator createValidator(Object fromType, Object toType) {
@@ -338,8 +330,6 @@ public class DefaultBindSpec extends BindSpec {
* This implementation of
* {@link #fillBindSpecDefaults(IObservable, IObservable)}
*
- * @param dataBindingContext
- * @param bindSpec
* @param target
* @param model
*/
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/DateConversionSupport.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/DateConversionSupport.java
index 610332b59d7..1c0e5e2517f 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/DateConversionSupport.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/DateConversionSupport.java
@@ -86,6 +86,8 @@ public abstract class DateConversionSupport {
/**
* Formats the given date with the default formatter according to the default locale.
+ * @param date a date
+ * @return a string representation of the given date according to the default locale
*/
protected String format(Date date) {
return format(date,DEFAULT_FORMATTER_INDEX);
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/IObservableCollection.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/IObservableCollection.java
index 7f228d0d60e..d12c384fb00 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/IObservableCollection.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/IObservableCollection.java
@@ -34,7 +34,8 @@ import org.eclipse.core.databinding.observable.set.IObservableSet;
public interface IObservableCollection extends IObservable, Collection {
/**
- * @return
+ * @return the element type of this observable value, or <code>null</code>
+ * if this observable collection is untyped.
*/
Object getElementType();
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/ObservableEvent.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/ObservableEvent.java
index 938e4bc4a3a..f1926592571 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/ObservableEvent.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/ObservableEvent.java
@@ -32,7 +32,7 @@ public abstract class ObservableEvent extends EventObject {
private static final long serialVersionUID = 7693906965267871813L;
/**
- * @return
+ * @return the observable that generated this event
*/
public IObservable getObservable() {
return (IObservable) getSource();
@@ -45,7 +45,7 @@ public abstract class ObservableEvent extends EventObject {
protected abstract void dispatch(IObservablesListener listener);
/**
- * @return
+ * @return a unique object representing the concrete type of this event.
*/
protected abstract Object getListenerType();
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/Observables.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/Observables.java
index 6b5cbce9f85..9a5abfa347b 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/Observables.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/Observables.java
@@ -72,7 +72,6 @@ public class Observables {
* Returns an empty observable set. The returned set continues to work after
* it has been disposed of and can be disposed of multiple times.
*
- * @param realm
* @return an empty observable set.
*/
public static IObservableSet emptyObservableSet() {
@@ -91,7 +90,6 @@ public class Observables {
}
/**
- * @param realm
* @param set
* @return Returns an observableSet backed by the given set
*/
@@ -140,7 +138,6 @@ public class Observables {
}
/**
- * @param realm
* @param list
* @return an observable list that never fires events
*/
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
index 5b5bd73e09d..46d9c1fe2d4 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
@@ -24,7 +24,7 @@ public class ListChangeEvent extends ObservableEvent {
*
*/
private static final long serialVersionUID = -9154315534258776672L;
-
+
static final Object TYPE = new Object();
/**
*
@@ -41,14 +41,14 @@ public class ListChangeEvent extends ObservableEvent {
}
/**
- * @return
+ * @return the observable list from which this event originated
*/
public IObservableList getObservableList() {
return (IObservableList) getSource();
}
protected void dispatch(IObservablesListener listener) {
- ((IListChangeListener)listener).handleListChange(this);
+ ((IListChangeListener) listener).handleListChange(this);
}
protected Object getListenerType() {
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/WritableList.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/WritableList.java
index 514d7dd8289..891b983030d 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/WritableList.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/WritableList.java
@@ -34,7 +34,6 @@ public class WritableList extends ObservableList {
* Creates an empty writable list in the default realm with a
* <code>null</code> element type.
*
- * @param realm
*/
public WritableList() {
this(Realm.getDefault());
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java
index 85050c6e02b..207066d85cf 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java
@@ -79,7 +79,6 @@ public class BidirectionalMap extends ObservableMap {
/**
* @param functionValue
* @param element
- * @param b
*/
private void removeMapping(Object functionValue, Object element) {
Object elementOrSet = valueToElements.get(functionValue);
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java
index d1b365d91f4..64690d34ae3 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ComputedObservableMap.java
@@ -100,9 +100,7 @@ public abstract class ComputedObservableMap extends AbstractObservableMap {
}
/**
- * @param realm
* @param keySet
- * @param wrappedMap
*/
public ComputedObservableMap(IObservableSet keySet) {
super(keySet.getRealm());
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
index 29165d327b3..959c1bc86c0 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
@@ -40,7 +40,7 @@ public class MapChangeEvent extends ObservableEvent {
}
/**
- * @return
+ * @return the observable map from which this event originated
*/
public IObservableMap getObservableMap() {
return (IObservableMap) getSource();
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapDiff.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapDiff.java
index 828e7a4846e..8aa633f36c5 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapDiff.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/MapDiff.java
@@ -39,7 +39,6 @@ public abstract class MapDiff {
* {@link #getRemovedKeys()} or {@link #getChangedKeys()}.
*
* @param key
- * @param indices
* @return the old value for the given key.
*/
public abstract Object getOldValue(Object key);
@@ -49,7 +48,6 @@ public abstract class MapDiff {
* {@link #getChangedKeys()} or {@link #getAddedKeys()}.
*
* @param key
- * @param indices
* @return the new value for the given key.
*/
public abstract Object getNewValue(Object key);
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ObservableMap.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ObservableMap.java
index 8edabf0e985..a802d5440a4 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ObservableMap.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/map/ObservableMap.java
@@ -31,7 +31,6 @@ public class ObservableMap extends AbstractObservable implements IObservableMap
private boolean stale = false;
/**
- * @param realm
* @param wrappedMap
*/
public ObservableMap(Map wrappedMap) {
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
index 95f75f518b0..c0399143226 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
@@ -40,7 +40,7 @@ public class SetChangeEvent extends ObservableEvent {
}
/**
- * @return
+ * @return the observable set from which this event originated
*/
public IObservableSet getObservableSet() {
return (IObservableSet) getSource();
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/WritableSet.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/WritableSet.java
index e4c7e1e7dfd..4f77afe2c3f 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/WritableSet.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/WritableSet.java
@@ -31,8 +31,6 @@ public class WritableSet extends ObservableSet {
* Constructs a new instance with the default realm, empty list, and a
* <code>null</code> element type.
*
- * @param realm
- * @param wrappedSet
*/
public WritableSet() {
this(Realm.getDefault());
@@ -41,7 +39,6 @@ public class WritableSet extends ObservableSet {
/**
* Construts a new instance with the default realm.
*
- * @param realm
* @param c
* @param elementType
* can be <code>null</code>
@@ -54,7 +51,6 @@ public class WritableSet extends ObservableSet {
* Constructs a new instance with an empty list and a <code>null</code> element type.
*
* @param realm
- * @param wrappedSet
*/
public WritableSet(Realm realm) {
this(realm, new HashSet(), null);
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java
index 3a510b5fe03..0290a6c6cc2 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreeChangeEvent.java
@@ -38,7 +38,7 @@ public class TreeChangeEvent extends EventObject {
}
/**
- * @return
+ * @return the observable tree from which this event originated
*/
public IObservableTree getObservable() {
return (IObservableTree) getSource();
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreePath.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreePath.java
index e614584d205..ebc986de551 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreePath.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/tree/TreePath.java
@@ -128,9 +128,6 @@ public final class TreePath {
*
* @param treePath
* path to compare to
- * @param comparer
- * the comparer to use, or <code>null</code> if equals() should
- * be used to compare segments
* @return whether the given path is a prefix of this path, or the same as
* this path
*/
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java
index 84b5c80afb9..7fdffef90e2 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/AbstractVetoableValue.java
@@ -22,7 +22,7 @@ public abstract class AbstractVetoableValue extends AbstractObservableValue
implements IVetoableValue {
/**
- * @param realm
+ * Creates a new vetoable value.
*/
public AbstractVetoableValue() {
this(Realm.getDefault());
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ComputedValue.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ComputedValue.java
index bdaae5ab9ab..37bcf65dcfc 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ComputedValue.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ComputedValue.java
@@ -43,7 +43,6 @@ public abstract class ComputedValue extends AbstractObservableValue {
private IObservable[] dependencies = new IObservable[0];
/**
- * @param realm
*
*/
public ComputedValue() {
@@ -51,7 +50,6 @@ public abstract class ComputedValue extends AbstractObservableValue {
}
/**
- * @param realm
* @param valueType can be <code>null</code>
*/
public ComputedValue(Object valueType) {
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
index 9f589b7bc46..8f0604e072d 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
@@ -42,7 +42,7 @@ public class ValueChangeEvent extends ObservableEvent {
}
/**
- * @return
+ * @return returns the observable value from which this event originated
*/
public IObservableValue getObservableValue() {
return (IObservableValue) source;
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
index 4d5676aaf67..eb3d1c92cfc 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
@@ -47,7 +47,7 @@ public class ValueChangingEvent extends ObservableEvent {
}
/**
- * @return
+ * @return the observable value from which this event originated
*/
public IObservableValue getObservableValue() {
return (IObservableValue) source;
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/util/ILogger.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/util/ILogger.java
index 56ee8f05bd0..6e794fc9713 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/util/ILogger.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/util/ILogger.java
@@ -21,8 +21,8 @@ import org.eclipse.core.runtime.IStatus;
* from within JFace Data Binding.
* </p>
*
- * @see org.eclipse.jface.util.Policy#getLog()
- * @see org.eclipse.jface.util.Policy#setLog(ILogger)
+ * @see Policy#getLog()
+ * @see Policy#setLog(ILogger)
* @since 1.1
*/
public interface ILogger {
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/ObjectToPrimitiveValidator.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/ObjectToPrimitiveValidator.java
index d21e58ec45c..3238247d900 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/ObjectToPrimitiveValidator.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/ObjectToPrimitiveValidator.java
@@ -54,11 +54,6 @@ public class ObjectToPrimitiveValidator implements IValidator {
return ValidationStatus.error(getNullHint());
}
- /**
- * @param toType2
- * @param class1
- * @return
- */
private boolean mapContainsValues(Class toType, Class fromType) {
for (int i = 0; i < primitiveMap.length; i++) {
if ((primitiveMap[i][0].equals(toType))
@@ -70,14 +65,14 @@ public class ObjectToPrimitiveValidator implements IValidator {
}
/**
- * @return
+ * @return a hint string
*/
public String getNullHint() {
return BindingMessages.getString("Validate_ConversionToPrimitive"); //$NON-NLS-1$
}
/**
- * @return
+ * @return a hint string
*/
public String getClassHint() {
return BindingMessages
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ListBinding.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ListBinding.java
index 8fd86c38090..4d36dfadf46 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ListBinding.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ListBinding.java
@@ -53,9 +53,7 @@ public class ListBinding extends Binding {
/**
* @param targetList
- * @param target
* @param modelList
- * @param model
* @param bindSpec
*/
public ListBinding(IObservableList targetList,
@@ -222,7 +220,6 @@ public class ListBinding extends Binding {
/**
* Performs the necessary processing for the position.
*
- * @param value
* @param pipelinePosition
* @param e
* @param lastPosition
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java
index ebf0d372220..93e1145aadb 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/ProxyObservableSet.java
@@ -39,7 +39,6 @@ public final class ProxyObservableSet extends AbstractObservableSet {
/**
* Constructs a DelegatingObservableSet that tracks the state of the given set.
- * @param realm
*
* @param toDelegate
*/
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java
index 73d73761b7b..87ab6eaccf2 100644
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableList.java
@@ -60,7 +60,6 @@ public class UnmodifiableObservableList extends ObservableList {
/**
* Because this instance is immutable staleness cannot be changed.
*
- * @see org.eclipse.jface.internal.databinding.provisional.observable.list.ObservableList#setStale(boolean)
*/
public void setStale(boolean stale) {
throw new UnsupportedOperationException();
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java
index 6c71cac136f..2825d315193 100755
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableList.java
@@ -53,10 +53,8 @@ public class DetailObservableList extends ObservableList {
private Object detailType;
/**
- * @param realm
* @param factory
* @param outerObservableValue
- * @param feature
* @param detailType
*/
public DetailObservableList(IObservableFactory factory,
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java
index 6e5a1fe3a9e..9e1abeb29ad 100755
--- a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java
+++ b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableValue.java
@@ -50,7 +50,6 @@ public class DetailObservableValue extends AbstractObservableValue {
* @param outerObservableValue
* @param factory
* @param detailType
- * @param realm
*/
public DetailObservableValue(IObservableValue outerObservableValue,
IObservableFactory factory, Object detailType) {

Back to the top