NEW - bug 231164: [api] review ITaskActivityListener interface and events

https://bugs.eclipse.org/bugs/show_bug.cgi?id=231164

1 files changed, 15 insertions, 4 deletions

diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskActivityManager.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskActivityManager.java
index a64820bcc..7ccefbd49 100644
--- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskActivityManager.java
+++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskActivityManager.java
@@ -27,6 +27,7 @@ import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
 import org.eclipse.mylyn.commons.core.StatusHandler;
 import org.eclipse.mylyn.tasks.core.ITask;
+import org.eclipse.mylyn.tasks.core.ITaskActivationListener;
 import org.eclipse.mylyn.tasks.core.ITaskActivityListener;
 import org.eclipse.mylyn.tasks.core.ITaskActivityManager;
 import org.eclipse.mylyn.tasks.core.ITaskListChangeListener;
@@ -46,6 +47,8 @@ public class TaskActivityManager implements ITaskActivityManager {
 
 	private final List<ITaskActivityListener> activityListeners = new ArrayList<ITaskActivityListener>();
 
+	private final List<ITaskActivationListener> activationListeners = new ArrayList<ITaskActivationListener>();
+
 	private final Set<ITask> allScheduledTasks = new HashSet<ITask>();
 
 	private final Set<ITask> allDueTasks = new HashSet<ITask>();
@@ -121,6 +124,14 @@ public class TaskActivityManager implements ITaskActivityManager {
 		activityListeners.remove(listener);
 	}
 
+	public void addActivationListener(ITaskActivationListener listener) {
+		activationListeners.add(listener);
+	}
+
+	public void removeActivationListener(ITaskActivationListener listener) {
+		activationListeners.remove(listener);
+	}
+
 	public void clear() {
 		dueTasks.clear();
 		allDueTasks.clear();
@@ -357,7 +368,7 @@ public class TaskActivityManager implements ITaskActivityManager {
 		deactivateActiveTask();
 
 		// notify that a task is about to be activated
-		for (ITaskActivityListener listener : new ArrayList<ITaskActivityListener>(activityListeners)) {
+		for (ITaskActivationListener listener : new ArrayList<ITaskActivationListener>(activationListeners)) {
 			try {
 				listener.preTaskActivated(task);
 			} catch (Throwable t) {
@@ -369,7 +380,7 @@ public class TaskActivityManager implements ITaskActivityManager {
 		activeTask = task;
 		((AbstractTask) activeTask).setActive(true);
 
-		for (ITaskActivityListener listener : new ArrayList<ITaskActivityListener>(activityListeners)) {
+		for (ITaskActivationListener listener : new ArrayList<ITaskActivationListener>(activationListeners)) {
 			try {
 				listener.taskActivated(task);
 			} catch (Throwable t) {
@@ -392,7 +403,7 @@ public class TaskActivityManager implements ITaskActivityManager {
 
 		if (task.isActive() && task == activeTask) {
 			// notify that a task is about to be deactivated
-			for (ITaskActivityListener listener : new ArrayList<ITaskActivityListener>(activityListeners)) {
+			for (ITaskActivationListener listener : new ArrayList<ITaskActivationListener>(activationListeners)) {
 				try {
 					listener.preTaskDeactivated(task);
 				} catch (Throwable t) {
@@ -404,7 +415,7 @@ public class TaskActivityManager implements ITaskActivityManager {
 			((AbstractTask) activeTask).setActive(false);
 			activeTask = null;
 
-			for (ITaskActivityListener listener : new ArrayList<ITaskActivityListener>(activityListeners)) {
+			for (ITaskActivationListener listener : new ArrayList<ITaskActivationListener>(activationListeners)) {
 				try {
 					listener.taskDeactivated(task);
 				} catch (Throwable t) {