RESOLVED - bug 278256: error when submitting a task twice

https://bugs.eclipse.org/bugs/show_bug.cgi?id=278256

1 files changed, 17 insertions, 8 deletions

diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/SingleSelectionAttributeEditor.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/SingleSelectionAttributeEditor.java
index 25146fba9..f8a77784c 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/SingleSelectionAttributeEditor.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/SingleSelectionAttributeEditor.java
@@ -40,6 +40,15 @@ public class SingleSelectionAttributeEditor extends AbstractAttributeEditor {
 
 	private String[] values;
 
+	private final TaskDataModelListener modelListener = new TaskDataModelListener() {
+		@Override
+		public void attributeChanged(TaskDataModelEvent event) {
+			if (getTaskAttribute().equals(event.getTaskAttribute())) {
+				refresh();
+			}
+		}
+	};
+
 	public SingleSelectionAttributeEditor(TaskDataModel manager, TaskAttribute taskAttribute) {
 		super(manager, taskAttribute);
 	}
@@ -74,14 +83,8 @@ public class SingleSelectionAttributeEditor extends AbstractAttributeEditor {
 			setControl(combo);
 		}
 		refresh();
-		getModel().addModelListener(new TaskDataModelListener() {
-			@Override
-			public void attributeChanged(TaskDataModelEvent event) {
-				if (getTaskAttribute().equals(event.getTaskAttribute())) {
-					refresh();
-				}
-			}
-		});
+
+		getModel().addModelListener(modelListener);
 	}
 
 	public String getValue() {
@@ -148,4 +151,10 @@ public class SingleSelectionAttributeEditor extends AbstractAttributeEditor {
 			attributeChanged();
 		}
 	}
+
+	@Override
+	public void dispose() {
+		getModel().removeModelListener(modelListener);
+		super.dispose();
+	}
 }