Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command
AgeCommit message (Collapse)AuthorFilesLines
2022-04-20[releng] Apply auto-clean of save to all files with Eclipse 4.23Jonah Graham2-2/+2
This mostly is using diamond operator, but includes adding missing @Override and organizing imports and applying formatting improvements in the JDT formatter. Change-Id: Id91cbff33b0a039cc5121945ffbc407ecba45866
2022-04-14Bug 579687: Reduce concurrent commands to 1 for GDB 9/10/11Torbjörn Svensson1-11/+58
Since the fault in GDB is triggered when there is more than one MI command sent before the response for the prior one is processed, limit the number of concurrent commands to 1 for the affected versions. Contributed by STMicroelectronics Change-Id: I5b47fc64d90eefdc44c1d2ead0da99b35aadfa39 Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2021-11-03Bug 561996 - Remove dependency to com.ibm.icu from CDT DSF GDBMat Booth1-2/+1
Switch to JRE implementations: * com.ibm.icu.text.MessageFormat -> java.text.MessageFormat Signed-off-by: Mat Booth <mat.booth@gmail.com> Change-Id: I823bcea99adad3decdfa29651b934b5902607f70
2021-05-13Bug 573506: Fix counting of opcode bytesJohn Dallaway1-2/+5
Change-Id: Ib5d1f1984e064099fc5cb357508359a5805f131c
2021-05-03Bug 573307: Correct since tagsJonah Graham2-2/+2
Change-Id: I7dd2bc0a98c36e9c4fd8db19a83a1b87c7fdd791
2021-04-23Bug 572880: show opcodes in disassembly view as byte sequenceMarc Ernst1-0/+7
Change-Id: Ib7ad37968ab23ff22cbb1fc110e85b47ffc37ab8
2021-04-10Bug 572742: Improve API by allowing "..." instead of String[]Jonah Graham1-3/+3
Change-Id: I4bc0a5c3807caaa012d1875b5ab68008503519b9
2021-04-10Bug 572581: reenable disabled DSF-GDB testsJonah Graham2-0/+34
Many of the disabled tests were failing because they were dependent on specific combinations of GDB + GCC and where exactly code stops and steps effect when entering functions. The old code mostly ran to a function and then stepped a known number of times. But what changes between GDB versions is how many steps are needed. Therefore for all failing tests update to run to a specific line number by using tags in the .cc file and running to them to make sure the test is precisely on that line. This partially reverts commit 8220215a2e35334b16ef48c76e9c9e33ba03d07e and 92272c64659b19bbc11c27cf1a1857b4f1f68e0e Reason for revert: These tests were "temporarily" disabled a while ago as part of the JIRO migration in Bug 545624. Change-Id: I703429c8a81c856360f1cb4e899026200527f7c6
2021-01-05Bug 569911: Stop allowing OOB records to accumulate foreverJonah Graham1-2/+3
Add a limit of 100,000 records to prevent OOM errors. Normally only a few OOB records are needed, but in some cases like with tdump, hundreds may be needed. Change-Id: I967e0facc1dc326d94fa67b1d647417ee3cd8891
2020-11-29Bug 569123 - Race condition on AbstractMIControl.fRxCommandsSimeon Andreev1-3/+8
This change adds synchronization to iterating over the map AbstractMIControl.fRxCommands during AbstractMIControl.cancelRxCommands(). This prevents potential ConcurrentModificationExceptions when elements are added or removed to the map in parallel during e.g. AbstractMIControl.TxThread.run() loop. The change also removes superfluous synchronization for method AbstractMIControl.cancelRxCommands(). Change-Id: Id7c01b3057e522cce324a002dce54f0fabe02623 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2020-11-29Bug 568228: Add a way for DSF Data Model to initiate refresh allTorbjörn Svensson1-0/+33
There is no way to predict what the user might do during for example the launch sequence, so as a last resort, tell the UI to drop all caches and refresh the data as the last step of the launch sequence. Change-Id: I97731c8286657a0fc1111ba41deb47863181a453 Also-by: Jonah Graham <jonah@kichwacoders.com> Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-03-02Revert "Bug 560614 - Drop dependency on ICU4J"Jonah Graham1-1/+2
This reverts commit 87b627bf02eaab28cdb64f6ebe203ac64d18fe94. Change-Id: I54ea1ac766437deb174eeba571a7a5094c180828
2020-03-02Bug 560614 - Drop dependency on ICU4JAlexander Kurtakov1-2/+1
Straightforward conversion. Still usages left that need deeper investigation how to be done proper. Some long time commented code removed as java formatter breaks trailing whitespaces on save. Change-Id: If74259bed5735b0d4cc98fc2cfa609c9c53c80c9 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-01-09Bug 551817: Write Kichwa Coders consistently in Copyright lineJonah Graham10-10/+10
Choice is one of: Kichwa Coders Ltd Kichwa Coders Canada Inc. depending if contributed by UK or Canadian company Change-Id: I5c9fb96ea6abf97858a6896911a71fa68b8400b1
2019-11-25Bug 530443: Add support for "info sources" MI equivalentBaha El Kassaby3-0/+210
*Implementation of -file-list-exec-source-files MI command. *Add new Debug Sources view with tree-like structure Change-Id: I6e734799712c059c8e53aa882777dfebd85aa0d5 Also-by: Jonah Graham <jonah@kichwacoders.com> Signed-off-by: Baha El Kassaby <baha.elkassaby@gmail.com>
2019-08-17Bug 550165: Debugging is stuck when "command aborts" on step returnUmair Sair1-2/+5
Command abort can occur for commands that are run not just in context of thread, instead stack frame is also present, e.g., step return in case of this bug. Updated the implementation to get IExecutionDMContext from the command context if it is not IExecutionDMContext itself. Change-Id: Ia6cccffba8bde28e22eca46211747de31084f25a Signed-off-by: Umair Sair <umair_sair@hotmail.com>
2019-08-10Remove redundant superinterfaces. Alexander Kurtakov1-1/+1
Change-Id: I0de3509b02a8ef6853f0053c9ee6edd304a05a86 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-11-26Bug 530443: Limit output to 10 lines per MI outputBaha El Kassaby3-34/+86
Some commands, such as -file-list-exec-source-files, can generate 10s of thousands of lines of output. Change-Id: I07fc3ef99bdd8e9247c75e2e9733e43b35657687 Signed-off-by: Baha El Kassaby <baha.elkassaby@gmail.com> Also-by: Jonah Graham <jonah@kichwacoders.com>
2018-11-22Bug 540373: Cleanup: Remove redundant semicolonsJonah Graham2-2/+2
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Remove redundant semicolons and completing the wizard Change-Id: I3d3175cfdfadec4f815c551d486e42c9f57b80ce
2018-11-22Bug 540373: Cleanup: Remove redundant type argumentsJonah Graham31-50/+50
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Remove redundant type arguments and completing the wizard Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
2018-11-22Bug 540373: Cleanup: Organize ImportsJonah Graham7-10/+5
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Organize Imports and completing the wizard Change-Id: Ia7b305a4c967d0e6f4e8fb8c1041e7028b24006c
2018-11-22Bug 540373: Cleanup: Format & Remove trailing whitespaceJonah Graham279-10449/+10451
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Format source code - Remove trailing white spaces on all lines and completing the wizard Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
2018-11-22Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.shJonah Graham289-867/+1734
Change-Id: Ifbb1d5af2a00bd5634dea200320e8c4303ffca6c
2018-11-20Bug 540373: Normalize newlines with .gitattributesJonah Graham12-807/+807
There is also a new script to verify completeness of .gitattributes: releng/scripts/verify_gitattributes.sh Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
2018-09-27Bug 539455: Report debug command errors via status handlerJohn Dallaway1-1/+3
Change-Id: I4c3abbb660e426580ce8f836e6e19a897fbaeefe Signed-off-by: John Dallaway <john@dallaway.org.uk>
2018-04-20Bug 533771 - Allow limit scope of MIStackListArgumentsSamuel Hultgren2-0/+13
Change-Id: Ibe63ea352fa4daae0d91989595d79b39c3ef92f0 Signed-off-by: Samuel Hultgren <samuel.hultgren@st.com>
2018-02-06Bug 530635: Add ability to do "set remotetimeout" via UIJonah Graham2-2/+31
Change-Id: Iaeaea1e8656d85cb854a5b27f5f212fa37a3159d
2017-11-18Bug 527419: Process async output with no variableJohn Dallaway1-8/+12
Change-Id: I4deb2b9db4421016b27e01353b0ae4745b139361 Signed-off-by: John Dallaway <john@dallaway.org.uk>
2017-11-13Serial Flash Target and Launch. Clean up Generic Launch.Doug Schaefer1-1/+4
Adds target, launch classes, and launch bar support for targets intended to upload their code to flash using a Serial Port. The port is co-ordinated with the Serial Terminal so that the terminal is paused during the upload. Also cleaned up the Generic Launch so it's not using the External Tools launch which has a number of UX issues. This simplifies the settings and gives us more control. And it's made reusable for the Serial Flash launch. Change-Id: I31e9970243fbf1cf22d027bbdb892fde104dbefe
2017-11-13Bug 520580: Implement new-console support on WindowsJonah Graham4-0/+125
A new checkbox on Windows only that starts inferiors in new window. Change-Id: If3efbe5e6b037e3b1c9528eed67068088702b0fe
2017-11-09Bug 522367: prevent hang of -target-attach on Ubuntu 16.04 / GDB 7.11Jonah Graham2-2/+42
-target-attach on Ubuntu 16.04 / GDB 7.11 does not flush its error response, leaving CDT hanging in final launch sequence. Sending a newline to GDB after the target-attach causes GDB to flush the buffer so CDT sees the error. Change-Id: I8816ac6c88eeaffc6d243ebdae9eb347cfdc5cf0
2017-05-23Bug 516227: solib-search-path with space failsVincent Guignot1-6/+10
If the solib-search-path path contains a space, CDT adds doubles quote to escape the space (in MIStandardParameterAdjustable class) . But Gdb client doesn’t understand the double quotes path. This patch do not add double quotes when the path contains spaces. Change-Id: I080be17023647dfac2b00296cdd54c7f9499102a Signed-off-by: Vincent Guignot <vincent.guignot@ingenico.com>
2017-05-05Bug 516244: Allow subclasses to provide the current CLI contextJonah Graham1-3/+18
Change-Id: I8138f16bb57433af1690dbd77a735c810cef052f
2017-05-05Bug 516053: Allow MIBreakpoint to be extendedJonah Graham4-12/+85
New API to allow third-parties to extend MIBreakpoint with their own custom Breakpoint handling. Change-Id: I64abfc41916a2053cfbed7e3db2357fbf2572050
2017-03-23Bug 379225: Address FindBugs issues for DSF-GDBMarc Khouzam1-16/+18
Change-Id: Id0bb91c7aaef0e356d1989e1dc949542813d2309
2017-03-07Bug 367256 - Debugger doesn't handle invalid breakpoints properlyMikhail Khodjaiants2-4/+135
Change-Id: I4a86015c61164edf9a7840acb40b7b74a4cf8e61
2017-01-24Bug 507950 - Answer query on MI channel to avoid GDB waiting foreverMarc Khouzam1-0/+58
With GDB 7.12, it is possible to receive queries on the dedicated MI channel. This channel is not accessible or shown to the user so if we don't answer, GDB will wait forever. This patch blindly answers 'y' to any query on the MI channel unless it has already been answered automatically (which happens when we don't use the full console). Change-Id: I0e208fc3495ce6ba57b3e477661f47e50680fd88
2016-11-15Bug 494246: prepare command line arguments properly for Windows GDBJonah Graham1-40/+11
Includes splitting out and expanding CommandLineArgsTest from LaunchConfigurationAndRestartTest. Change-Id: I19fa97a847d908c1c780ca767cf688f26a51d684 Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2016-11-15Bug 303808: Run all-stop mode with target async on GDB 7.12Alvaro Sanchez-Leon2-0/+28
The previous all-stop implementation use Ctrl-C (variants) to suspend the target program. This option is not supported when using the new GDB full CLI console provided in GDB 7.12. So the alternative is to send the mi command -exec-interrupt to suspend the target, however this option requires the use of target async-on mode (already in use for non stop mode). This update makes all-stop mode use target async mode when using versions higher or equal to GDB 7.12. This update also removes the non-stop mode restriction initially implemented for the use of the new GDB Full CLI console. Change-Id: Iabef20bdee814d413fc338f9ec8c2d99d6311c20
2016-11-14Bug 497166: Support the user using the 'run' command in the gdb consoleMarc Khouzam2-11/+31
This commit introduces a PersistentPTY. By using it, we now allow the user to restart the process from the GDB console (by pressing 'run'). In this case, the I/O will continue using the PersistentPTY. Previously, the PTY would have been closed, and GDB would fail to restart the process because it would fail to use the closed PTY. Change-Id: I395b402e297a2043af8fce33df163eddef9e6c7a
2016-11-14Bug 498782 - add synchronize of process selection between the DV and GDBMarc Khouzam2-2/+34
This patch synchronizes the GDB focus when the user selects a process node in the DV. When the user selects a new process (inferior) from the GDB console, we are already synchronizing the DV to the thread/frame that GDB selects from that process. Change-Id: I11dfd175d51ec49e969f4d07288f80f7ea72a3e1
2016-11-04Bug 499230 - Duplicated "-thread-select" and "-stack-select-frame" Marc Dumais2-10/+0
Most GDB MI commands support the "--thread" and "--frame" options, that tells GDB on which thread/stack frame the command is meant to act-on. For those that don't, CDT has a mechanism to first have GDB switch thread (MIThreadSelect) or frame (MIStackSelectFrame), before issuing the command that will act on that entity. Ironically, those two commands are wrongly identified as not supporting those parameters, and so are sometimes sent in duplicate, when a single command including the thread or frame would be possible. This commit correctly identifies those commands as supporting the thread/frame parameter. Change-Id: I6e7fc4e873abe36ad024c7131efda7c0aa89dc44
2016-09-21Bug 497693/ Sysroot with spacesVincent Guignot5-49/+69
If the sysroot path contains a space, CDT adds doubles quote to escape the space (in MIStandardParameterAdjustable class) . But Gdb client (7.5 and 7.11) doesn’t understand the double quotes path. This patch do not add double quotes when the path contains spaces. Add test case. Change-Id: I8c54fa625ce1fb1f1b9249361ca07060b56ba90c Signed-off-by: Vincent Guignot <vincent.guignot@ingenico.com>
2016-09-19Fix API as per the upcoming 9.1 releaseMarc Khouzam1-1/+2
Change-Id: I307f8f3239178415a66f0bed0b63e5b0d7ffe4cd
2016-09-07Bug 303808: Support for full GDB consoleMarc Khouzam2-40/+66
This patch provides a full GDB console in the standard Console view. The full console is disabled for Windows due to PTY limitations. The new console will be triggered automatically when using GDB 7.12 (or its pre-release) and running on Linux. Known issues with this patch: - Cloning the console view breaks the console - Pinning the console view is not supported - Interrupting execution in all-stop mode fails with the new console - Pagination causes some events to be lost (all-stop only) Change-Id: Iee6ef5228ca17bd829eb743cb41a142afe6714dc
2016-08-31Bug 500066 - Debug traces can be in the wrong orderMarc Khouzam1-2/+3
Change-Id: I4e28ade1df7d3f35f07bfb95870e7d9c449442fc
2016-07-20Bug 497167: Add support for =thread-group-added eventMarc Khouzam2-1/+55
This will allow us to eventually take action (like prepare the console) as soon as the user adds a new inferior using the gdb console and the command add-inferior. Change-Id: I24ff380b8442de6a88e3caa0fe6832e90e83ac99
2016-07-04Bug 496415. Show reason for crash when core debugging.Adam Ward2-0/+70
Changes: When a core debugging session starts a MIConsoleStreamOuput is received by MIRunControlEventProcessor or MIRunControlEventProcessor_7_0 which contains a string of the form "Program terminated with signal <signal>, <reason>". The signal and reason are parsed from the string and a new signal event created and dispatched. The label of the last executing thread (one that received the signal) in the debug view then shows the signal that caused the core file to be created Testing: Tested on Windows and a Lubuntu VM Change-Id: I02fa4b2fe458005f159341fcbcaaaa2fe57a7871 Signed-off-by: Adam Ward <award@blackberry.com>
2016-04-25Bug 492304 - Fix NLS warningsAlex Blewitt2-2/+2
Eclipse warns if a String literal does not have a `//$NON-NLS-<n>$` entry at the end of the line. However, for historic or formatting reasons, many such occurrences in the CDT source have an intermediate whitespace, such as `// $NON-NLS-<n>$` Fix these so that the whitespace is removed between the // and $ characters. Change-Id: Idc12398fe6e9d619af1d0b1b73fb8b6180da223c Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-25Bug 492230 - Replace buffer.append(a+b) callsAlex Blewitt5-15/+15
When using a `StringBuilder` or `StringBuffer` to create a string message, using implicit string concatenation inside an `.append()` call will create a nested StringBuilder for the purposes of creating the arguments, which will subsequently be converted to a String and then passed to the outer StringBuilder. Skip the creation of the intermediate object and String by simply replacing such calls with `buffer.append(a).append(b)`. Where values are compile time String constants, leave as is so that the javac compiler can perform compile-time String concatenation. Ensure that NEWLINE isn't appended in such a way since it is not a compile time constant `System.getProperty("line.separator")` Change-Id: I4126aefb2272f06b08332e004d7ea76b6f02cdba Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>

Back to the top