Bug 579463 - Welcome screen should not hide toolbar

Before this change, opening the welcome screen hides the toolbar. As the
welcome screen is the only view which does this, I suggest to remove
this due to a consistent behavior. Less special behavior in a tool is
better for the overall user experience.

Change-Id: I886bd80524cd3f09a753c4a3400d3a2276bb99fd
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/192306
Reviewed-by: Holger Voormann <eclipse@voormann.de>

1 files changed, 0 insertions, 34 deletions

diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewIntroAdapterPart.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewIntroAdapterPart.java
index 7eb37b094e4..578a19f4909 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewIntroAdapterPart.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewIntroAdapterPart.java
@@ -33,7 +33,6 @@ import org.eclipse.ui.IMemento;
 import org.eclipse.ui.IViewSite;
 import org.eclipse.ui.PartInitException;
 import org.eclipse.ui.internal.intro.IntroMessages;
-import org.eclipse.ui.internal.util.PrefUtil;
 import org.eclipse.ui.intro.IIntroPart;
 import org.eclipse.ui.intro.IIntroSite;
 import org.eclipse.ui.part.ViewPart;
@@ -116,7 +115,6 @@ public final class ViewIntroAdapterPart extends ViewPart {
 				control.setRedraw(true);
 			}
 
-			setBarVisibility(standby);
 		});
 	}
 
@@ -148,7 +146,6 @@ public final class ViewIntroAdapterPart extends ViewPart {
 	public void dispose() {
 		eventBroker.unsubscribe(zoomChangeListener);
 
-		setBarVisibility(true);
 		getSite().getWorkbenchWindow().getWorkbench().getIntroManager().closeIntro(introPart);
 		introPart.dispose();
 		super.dispose();
@@ -200,35 +197,4 @@ public final class ViewIntroAdapterPart extends ViewPart {
 	public void saveState(IMemento memento) {
 		introPart.saveState(memento);
 	}
-
-	/**
-	 * Sets whether the CoolBar/PerspectiveBar should be visible.
-	 *
-	 * @param visible whether the CoolBar/PerspectiveBar should be visible
-	 * @since 3.1
-	 */
-	private void setBarVisibility(final boolean visible) {
-		WorkbenchWindow window = (WorkbenchWindow) getSite().getWorkbenchWindow();
-
-		boolean layout = false; // don't layout unless things have actually changed
-		if (visible) {
-			// Restore the last 'saved' state
-			boolean coolbarVisible = PrefUtil.getInternalPreferenceStore()
-					.getBoolean(IPreferenceConstants.COOLBAR_VISIBLE);
-			boolean persBarVisible = PrefUtil.getInternalPreferenceStore()
-					.getBoolean(IPreferenceConstants.PERSPECTIVEBAR_VISIBLE);
-			layout = (coolbarVisible != window.getCoolBarVisible())
-					|| (persBarVisible != window.getPerspectiveBarVisible());
-			window.setCoolBarVisible(coolbarVisible);
-			window.setPerspectiveBarVisible(persBarVisible);
-		} else {
-			layout = !window.getCoolBarVisible() || !window.getPerspectiveBarVisible();
-			window.setCoolBarVisible(false);
-			window.setPerspectiveBarVisible(false);
-		}
-
-		if (layout) {
-			window.getShell().layout();
-		}
-	}
 }