diff options
| author | Leo Ufimtsev | 2017-03-21 19:03:27 +0000 |
|---|---|---|
| committer | Leo Ufimtsev | 2017-03-21 19:03:27 +0000 |
| commit | 3f92612774ff0dda4e8e9c86127bb0f3a880c329 (patch) | |
| tree | 349f12c3a4d7ff60e1675d7f5ace81b6baf08198 /bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.h | |
| parent | 8bd9620059daff78087c993d22fdbe714fe2d2ac (diff) | |
| download | eclipse.platform.swt-3f92612774ff0dda4e8e9c86127bb0f3a880c329.tar.gz eclipse.platform.swt-3f92612774ff0dda4e8e9c86127bb0f3a880c329.tar.xz eclipse.platform.swt-3f92612774ff0dda4e8e9c86127bb0f3a880c329.zip | |
Bug 503431 Mouse button release event memory leak fix
The previous patch introduced a memory leak as a new callback was
instantiated but never disposed.
After investigation, that callback is redundant as the only thing it did
was to return 'false'. This can be achieved by linking it to gtk_false()
instead.
Tasks performed:
1) Removed redundant callback in Display.java.
2) Linked Tree/Table/List to gtk_false() instead.
2.b) Implemented custom getter that gets the function pointer to
gtk_false.
Tested via DNDExample, with Table/List/Tree you can still select
multiple items and drag multiple items. (without the calls, you cannot).
Gtk3: all jUnits pass.
Change-Id: I9d144504acdf3548b2a11ca10dcc19d4fe42d3c6
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Diffstat (limited to 'bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.h')
| -rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.h b/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.h index 6b3143bd54..0a14caea6a 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.h +++ b/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.h @@ -118,6 +118,7 @@ typedef enum { _1GDK_1PIXMAP_1XID_FUNC, _1GDK_1TYPE_1COLOR_FUNC, _1GDK_1TYPE_1PIXBUF_FUNC, + _1GET_1FUNCTION_1POINTER_1gtk_1false_FUNC, _1GString_1len_FUNC, _1GString_1str_FUNC, _1GTK_1ACCESSIBLE_FUNC, |