407320: [Activity Diagram] Duplicate actions in the Activity Diagram when creating new elements

https://bugs.eclipse.org/bugs/show_bug.cgi?id=407320

- added some test in the view provider to test if the element can be created for the given container view
- updated tests (make the tests generic)
- updated code generator to take into account modification for view provider

1 files changed, 5 insertions, 5 deletions

diff --git a/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.activity/src/org/eclipse/papyrus/uml/diagram/activity/edit/commands/ValuePinInCallBeActCreateCommand.java b/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.activity/src/org/eclipse/papyrus/uml/diagram/activity/edit/commands/ValuePinInCallBeActCreateCommand.java
index 68a1b0b7f80..b6cab8f262f 100644
--- a/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.activity/src/org/eclipse/papyrus/uml/diagram/activity/edit/commands/ValuePinInCallBeActCreateCommand.java
+++ b/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.activity/src/org/eclipse/papyrus/uml/diagram/activity/edit/commands/ValuePinInCallBeActCreateCommand.java
@@ -1,5 +1,5 @@
 /*****************************************************************************

- * Copyright (c) 2009 Atos Origin.

+ * Copyright (c) 2009 Atos Origin and CEA LIST

  *

  *    

  * All rights reserved. This program and the accompanying materials

@@ -9,6 +9,7 @@
  *

  * Contributors:

  *   Atos Origin - Initial API and implementation

+ *   Patrick Tessier (CEA LIST ) - modification

  *

  *****************************************************************************/

 package org.eclipse.papyrus.uml.diagram.activity.edit.commands;

@@ -92,7 +93,7 @@ public class ValuePinInCallBeActCreateCommand extends EditElementCommand {
 	}

 

 	/**

-	 * @generated NOT do not set new element which may change after validation

+	 * @generated

 	 */

 	protected CommandResult doExecuteWithResult(IProgressMonitor monitor, IAdaptable info) throws ExecutionException {

 		ValuePin newElement = UMLFactory.eINSTANCE.createValuePin();

@@ -100,9 +101,8 @@ public class ValuePinInCallBeActCreateCommand extends EditElementCommand {
 		owner.getArguments().add(newElement);

 		ElementInitializers.getInstance().init_ValuePin_3017(newElement);

 		doConfigure(newElement, monitor, info);

-		// do not set new element which may change after validation

-		//((CreateElementRequest)getRequest()).setNewElement(newElement);

-		return CommandResult.newOKCommandResult();//newElement);

+		((CreateElementRequest)getRequest()).setNewElement(newElement);

+		return CommandResult.newOKCommandResult(newElement);

 	}

 

 	/**