refinement: Remove set methods from IAtsWorkDefinitions

3 files changed, 9 insertions, 13 deletions

diff --git a/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/config/store/TeamDefinitionArtifactStore.java b/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/config/store/TeamDefinitionArtifactStore.java
index fb49c675000..0ca52a668e8 100644
--- a/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/config/store/TeamDefinitionArtifactStore.java
+++ b/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/config/store/TeamDefinitionArtifactStore.java
@@ -178,7 +178,6 @@ public class TeamDefinitionArtifactStore extends ArtifactAtsObjectStore {
          atsObject = teamDef;
          teamDef.setActive(teamDefArt.getSoleAttributeValue(AtsAttributeTypes.Active, true));
          teamDef.setActionable(teamDefArt.getSoleAttributeValue(AtsAttributeTypes.Actionable, true));
-         String actionDetailsFormat = teamDefArt.getSoleAttributeValue(AtsAttributeTypes.ActionDetailsFormat, "");
          teamDef.setTeamUsesVersions(teamDefArt.getSoleAttributeValue(AtsAttributeTypes.TeamUsesVersions, true));
          teamDef.setAllowCommitBranch(teamDefArt.getSoleAttributeValue(AtsAttributeTypes.AllowCommitBranch, true));
          teamDef.setAllowCreateBranch(teamDefArt.getSoleAttributeValue(AtsAttributeTypes.AllowCreateBranch, true));
diff --git a/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/review/DecisionReviewManager.java b/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/review/DecisionReviewManager.java
index 5e9adce50d5..d6b07d5da11 100644
--- a/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/review/DecisionReviewManager.java
+++ b/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/review/DecisionReviewManager.java
@@ -27,7 +27,7 @@ import org.eclipse.osee.ats.core.client.workflow.transition.TransitionManager;
 import org.eclipse.osee.ats.core.client.workflow.transition.TransitionOption;
 import org.eclipse.osee.ats.core.client.workflow.transition.TransitionResults;
 import org.eclipse.osee.ats.core.model.IAtsUser;
-import org.eclipse.osee.ats.core.workdef.AtsWorkDefinitionService;
+import org.eclipse.osee.ats.core.workdef.SimpleDecisionReviewOption;
 import org.eclipse.osee.ats.workdef.api.IAtsDecisionReviewOption;
 import org.eclipse.osee.ats.workdef.api.IStateToken;
 import org.eclipse.osee.ats.workdef.api.ReviewBlockType;
@@ -65,8 +65,7 @@ public class DecisionReviewManager {
             return result;
          }
          result =
-            transitionToState(toState.getStateType(), popup, DecisionReviewState.Decision, reviewArt, user,
-               transaction);
+            transitionToState(toState.getStateType(), popup, DecisionReviewState.Decision, reviewArt, user, transaction);
          if (result.isFalse()) {
             return result;
          }
@@ -104,8 +103,7 @@ public class DecisionReviewManager {
 
    public static Result transitionToState(StateType StateType, boolean popup, IStateToken toState, DecisionReviewArtifact reviewArt, IAtsUser user, SkynetTransaction transaction) throws OseeCoreException {
       TransitionHelper helper =
-         new TransitionHelper("Transition to " + toState.getName(), Arrays.asList(reviewArt),
-            toState.getName(),
+         new TransitionHelper("Transition to " + toState.getName(), Arrays.asList(reviewArt), toState.getName(),
             Arrays.asList((user == null ? reviewArt.getStateMgr().getAssignees().iterator().next() : user)), null,
             TransitionOption.None);
       TransitionManager transitionMgr = new TransitionManager(helper, transaction);
@@ -137,8 +135,8 @@ public class DecisionReviewManager {
 
       // transition to decision
       TransitionHelper helper =
-         new TransitionHelper("Transition to Decision", Arrays.asList(decRev),
-            DecisionReviewState.Decision.getName(), assignees, null, TransitionOption.OverrideAssigneeCheck);
+         new TransitionHelper("Transition to Decision", Arrays.asList(decRev), DecisionReviewState.Decision.getName(),
+            assignees, null, TransitionOption.OverrideAssigneeCheck);
       TransitionManager transitionMgr = new TransitionManager(helper, transaction);
       TransitionResults results = transitionMgr.handleAll();
 
@@ -161,9 +159,8 @@ public class DecisionReviewManager {
 
    public static List<IAtsDecisionReviewOption> getDefaultDecisionReviewOptions() throws OseeCoreException {
       List<IAtsDecisionReviewOption> options = new ArrayList<IAtsDecisionReviewOption>();
-      options.add(AtsWorkDefinitionService.getService().createDecisionReviewOption("Yes", true,
-         Arrays.asList(AtsUsersClient.getUser().getUserId())));
-      options.add(AtsWorkDefinitionService.getService().createDecisionReviewOption("No", false, null));
+      options.add(new SimpleDecisionReviewOption("Yes", true, Arrays.asList(AtsUsersClient.getUser().getUserId())));
+      options.add(new SimpleDecisionReviewOption("No", false, null));
       return options;
    }
 
diff --git a/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/workdef/WorkDefinitionFactory.java b/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/workdef/WorkDefinitionFactory.java
index 1dd7d6b44ca..a8b6e4ff484 100644
--- a/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/workdef/WorkDefinitionFactory.java
+++ b/plugins/org.eclipse.osee.ats.core.client/src/org/eclipse/osee/ats/core/client/workdef/WorkDefinitionFactory.java
@@ -124,7 +124,7 @@ public class WorkDefinitionFactory {
       return match;
    }
 
-   private static WorkDefinitionMatch getWorkDefinitionFromArtifactsAttributeValue(IAtsTeamDefinition teamDef) throws OseeCoreException {
+   private static WorkDefinitionMatch getWorkDefinitionFromArtifactsAttributeValue(IAtsTeamDefinition teamDef) {
       // If this artifact specifies it's own workflow definition, use it
       String workFlowDefId = teamDef.getWorkflowDefinition();
       if (Strings.isValid(workFlowDefId)) {
@@ -137,7 +137,7 @@ public class WorkDefinitionFactory {
       return new WorkDefinitionMatch();
    }
 
-   private static WorkDefinitionMatch getTaskWorkDefinitionFromArtifactsAttributeValue(IAtsTeamDefinition teamDef) throws OseeCoreException {
+   private static WorkDefinitionMatch getTaskWorkDefinitionFromArtifactsAttributeValue(IAtsTeamDefinition teamDef) {
       // If this artifact specifies it's own workflow definition, use it
       String workFlowDefId = teamDef.getRelatedTaskWorkDefinition();
       if (Strings.isValid(workFlowDefId)) {