refinement: Remove error logging during tests

2 files changed, 16 insertions, 4 deletions

diff --git a/plugins/org.eclipse.osee.ats.core.test/src/org/eclipse/osee/ats/core/model/impl/WorkStateProviderImplTest.java b/plugins/org.eclipse.osee.ats.core.test/src/org/eclipse/osee/ats/core/model/impl/WorkStateProviderImplTest.java
index 5d9cd42571b..befd23c0d70 100644
--- a/plugins/org.eclipse.osee.ats.core.test/src/org/eclipse/osee/ats/core/model/impl/WorkStateProviderImplTest.java
+++ b/plugins/org.eclipse.osee.ats.core.test/src/org/eclipse/osee/ats/core/model/impl/WorkStateProviderImplTest.java
@@ -133,7 +133,7 @@ public class WorkStateProviderImplTest {
       WorkStateProviderImpl provider = new WorkStateProviderImpl(new MockWorkStateFactory());
       provider.addState(new WorkStateImpl("endorse"));
 
-      provider.addState(new WorkStateImpl("endorse"));
+      provider.addState(new WorkStateImpl("endorse"), false);
    }
 
    @Test
@@ -141,7 +141,7 @@ public class WorkStateProviderImplTest {
       WorkStateProviderImpl provider = new WorkStateProviderImpl(new MockWorkStateFactory());
       provider.addState(new WorkStateImpl("endorse"));
 
-      provider.addState("endorse", new LinkedList<IAtsUser>(), 34, 23);
+      provider.addState("endorse", new LinkedList<IAtsUser>(), 34, 23, false);
    }
 
    @Test(expected = OseeArgumentException.class)
diff --git a/plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/model/impl/WorkStateProviderImpl.java b/plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/model/impl/WorkStateProviderImpl.java
index 8ee100d30c8..26dff8af9fc 100644
--- a/plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/model/impl/WorkStateProviderImpl.java
+++ b/plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/model/impl/WorkStateProviderImpl.java
@@ -220,9 +220,15 @@ public class WorkStateProviderImpl implements WorkStateProvider {
 
    @Override
    public void addState(String name, List<? extends IAtsUser> assignees, double hoursSpent, int percentComplete) {
+      addState(name, assignees, hoursSpent, percentComplete, true);
+   }
+
+   protected void addState(String name, List<? extends IAtsUser> assignees, double hoursSpent, int percentComplete, boolean logError) {
       if (getVisitedStateNames().contains(name)) {
          String errorStr = String.format("Error: Duplicate state [%s] for [%s]", name, factory.getId());
-         OseeLog.log(Activator.class, Level.SEVERE, errorStr);
+         if (logError) {
+            OseeLog.log(Activator.class, Level.SEVERE, errorStr);
+         }
          return;
       } else {
          addState(factory.createStateData(name, assignees, hoursSpent, percentComplete));
@@ -274,9 +280,15 @@ public class WorkStateProviderImpl implements WorkStateProvider {
 
    @Override
    public void addState(WorkState state) {
+      addState(state, true);
+   }
+
+   protected void addState(WorkState state, boolean logError) {
       if (getVisitedStateNames().contains(state.getName())) {
          String errorStr = String.format("Error: Duplicate state [%s] for [%s]", state.getName(), factory.getId());
-         OseeLog.log(Activator.class, Level.SEVERE, errorStr);
+         if (logError) {
+            OseeLog.log(Activator.class, Level.SEVERE, errorStr);
+         }
          return;
       } else {
          states.add(state);