[Releng] Add API analysis

17 files changed, 77 insertions, 21 deletions

diff --git a/org.eclipse.userstorage.tests/.project b/org.eclipse.userstorage.tests/.project
index b8dc3bb..78104fb 100644
--- a/org.eclipse.userstorage.tests/.project
+++ b/org.eclipse.userstorage.tests/.project
@@ -20,10 +20,16 @@
 			<arguments>
 			</arguments>
 		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.api.tools.apiAnalysisBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
 	</buildSpec>
 	<natures>
 		<nature>org.eclipse.pde.PluginNature</nature>
 		<nature>org.eclipse.jdt.core.javanature</nature>
+		<nature>org.eclipse.pde.api.tools.apiAnalysisNature</nature>
 	</natures>
 	<filteredResources>
 		<filter>
diff --git a/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/StorageTests.java b/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/StorageTests.java
index 48a742e..15bcc1d 100644
--- a/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/StorageTests.java
+++ b/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/StorageTests.java
@@ -15,10 +15,10 @@ import static org.hamcrest.MatcherAssert.assertThat;
 import org.eclipse.userstorage.IBlob;
 import org.eclipse.userstorage.IStorage;
 import org.eclipse.userstorage.StorageFactory;
-import org.eclipse.userstorage.internal.Credentials;
 import org.eclipse.userstorage.internal.Session;
 import org.eclipse.userstorage.internal.StorageService;
 import org.eclipse.userstorage.internal.util.IOUtil;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.tests.util.ClientFixture;
 import org.eclipse.userstorage.tests.util.ClientFixture.TestCache;
 import org.eclipse.userstorage.tests.util.FixedCredentialsProvider;
diff --git a/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/FixedCredentialsProvider.java b/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/FixedCredentialsProvider.java
index 8a8d68d..938f1ca 100644
--- a/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/FixedCredentialsProvider.java
+++ b/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/FixedCredentialsProvider.java
@@ -11,7 +11,7 @@
 package org.eclipse.userstorage.tests.util;
 
 import org.eclipse.userstorage.IStorageService;
-import org.eclipse.userstorage.internal.Credentials;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.spi.ICredentialsProvider;
 
 /**
diff --git a/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/TestCredentialsProvider.java b/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/TestCredentialsProvider.java
index 3383e08..9bf6b36 100644
--- a/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/TestCredentialsProvider.java
+++ b/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/TestCredentialsProvider.java
@@ -11,8 +11,8 @@
 package org.eclipse.userstorage.tests.util;
 
 import org.eclipse.userstorage.IStorageService;
-import org.eclipse.userstorage.internal.Credentials;
 import org.eclipse.userstorage.internal.util.IOUtil;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.spi.ICredentialsProvider;
 
 import javax.swing.JButton;
diff --git a/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/USSServer.java b/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/USSServer.java
index 8c6ecee..a3b9211 100644
--- a/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/USSServer.java
+++ b/org.eclipse.userstorage.tests/src/org/eclipse/userstorage/tests/util/USSServer.java
@@ -10,10 +10,10 @@
  */
 package org.eclipse.userstorage.tests.util;
 
-import org.eclipse.userstorage.internal.Credentials;
 import org.eclipse.userstorage.internal.util.IOUtil;
 import org.eclipse.userstorage.internal.util.JSONUtil;
 import org.eclipse.userstorage.internal.util.StringUtil;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.tests.StorageTests;
 
 import org.eclipse.core.runtime.Path;
diff --git a/org.eclipse.userstorage.ui/.project b/org.eclipse.userstorage.ui/.project
index 9252c02..e8649ab 100644
--- a/org.eclipse.userstorage.ui/.project
+++ b/org.eclipse.userstorage.ui/.project
@@ -20,10 +20,16 @@
 			<arguments>
 			</arguments>
 		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.api.tools.apiAnalysisBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
 	</buildSpec>
 	<natures>
 		<nature>org.eclipse.pde.PluginNature</nature>
 		<nature>org.eclipse.jdt.core.javanature</nature>
+		<nature>org.eclipse.pde.api.tools.apiAnalysisNature</nature>
 	</natures>
 	<filteredResources>
 		<filter>
diff --git a/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/CredentialsDialog.java b/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/CredentialsDialog.java
index 82c04d9..745ed95 100644
--- a/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/CredentialsDialog.java
+++ b/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/CredentialsDialog.java
@@ -11,8 +11,8 @@
 package org.eclipse.userstorage.ui;
 
 import org.eclipse.userstorage.IStorageService;
-import org.eclipse.userstorage.internal.Credentials;
 import org.eclipse.userstorage.internal.util.StringUtil;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.ui.internal.CredentialsComposite;
 
 import org.eclipse.jface.dialogs.Dialog;
diff --git a/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/CredentialsComposite.java b/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/CredentialsComposite.java
index ec1aa1b..5d9faa4 100644
--- a/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/CredentialsComposite.java
+++ b/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/CredentialsComposite.java
@@ -11,9 +11,9 @@
 package org.eclipse.userstorage.ui.internal;
 
 import org.eclipse.userstorage.IStorageService;
-import org.eclipse.userstorage.internal.Credentials;
 import org.eclipse.userstorage.internal.StorageService;
 import org.eclipse.userstorage.internal.util.StringUtil;
+import org.eclipse.userstorage.spi.Credentials;
 
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.events.ModifyEvent;
diff --git a/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/DialogCredentialsProvider.java b/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/DialogCredentialsProvider.java
index c440cac..08266f7 100644
--- a/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/DialogCredentialsProvider.java
+++ b/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/DialogCredentialsProvider.java
@@ -11,7 +11,7 @@
 package org.eclipse.userstorage.ui.internal;
 
 import org.eclipse.userstorage.IStorageService;
-import org.eclipse.userstorage.internal.Credentials;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.spi.ICredentialsProvider;
 import org.eclipse.userstorage.ui.CredentialsDialog;
 
diff --git a/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/ServicesPreferencePage.java b/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/ServicesPreferencePage.java
index 4e18dcf..a154ae2 100644
--- a/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/ServicesPreferencePage.java
+++ b/org.eclipse.userstorage.ui/src/org/eclipse/userstorage/ui/internal/ServicesPreferencePage.java
@@ -15,9 +15,9 @@ import org.eclipse.userstorage.IStorage;
 import org.eclipse.userstorage.IStorageService;
 import org.eclipse.userstorage.IStorageService.Registry;
 import org.eclipse.userstorage.StorageFactory;
-import org.eclipse.userstorage.internal.Credentials;
 import org.eclipse.userstorage.internal.StorageService;
 import org.eclipse.userstorage.internal.util.StringUtil;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.ui.ServiceSelectorComposite;
 
 import org.eclipse.jface.dialogs.ErrorDialog;
diff --git a/org.eclipse.userstorage/.project b/org.eclipse.userstorage/.project
index 91063ce..c949cd3 100644
--- a/org.eclipse.userstorage/.project
+++ b/org.eclipse.userstorage/.project
@@ -20,20 +20,26 @@
 			<arguments>
 			</arguments>
 		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.api.tools.apiAnalysisBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
 	</buildSpec>
 	<natures>
 		<nature>org.eclipse.pde.PluginNature</nature>
 		<nature>org.eclipse.jdt.core.javanature</nature>
+		<nature>org.eclipse.pde.api.tools.apiAnalysisNature</nature>
 	</natures>
-  <filteredResources>
-    <filter>
-      <id>1396938000000</id>
-      <name></name>
-      <type>10</type>
-      <matcher>
-        <id>org.eclipse.ui.ide.multiFilter</id>
-        <arguments>1.0-projectRelativePath-matches-true-false-target</arguments>
-      </matcher>
-    </filter>
-  </filteredResources>
+	<filteredResources>
+		<filter>
+			<id>1396938000000</id>
+			<name></name>
+			<type>10</type>
+			<matcher>
+				<id>org.eclipse.ui.ide.multiFilter</id>
+				<arguments>1.0-projectRelativePath-matches-true-false-target</arguments>
+			</matcher>
+		</filter>
+	</filteredResources>
 </projectDescription>
diff --git a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Activator.java b/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Activator.java
index 9ca0d79..f2f28fc 100644
--- a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Activator.java
+++ b/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Activator.java
@@ -12,6 +12,7 @@ package org.eclipse.userstorage.internal;
 
 import org.eclipse.userstorage.IStorageService;
 import org.eclipse.userstorage.internal.util.StringUtil;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.spi.ICredentialsProvider;
 
 import org.eclipse.core.runtime.CoreException;
diff --git a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Session.java b/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Session.java
index 04ae3f0..050a36d 100644
--- a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Session.java
+++ b/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Session.java
@@ -15,6 +15,7 @@ import org.eclipse.userstorage.internal.util.IOUtil;
 import org.eclipse.userstorage.internal.util.JSONUtil;
 import org.eclipse.userstorage.internal.util.ProxyUtil;
 import org.eclipse.userstorage.internal.util.StringUtil;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.spi.ICredentialsProvider;
 import org.eclipse.userstorage.util.ConflictException;
 import org.eclipse.userstorage.util.NotFoundException;
diff --git a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Storage.java b/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Storage.java
index 1cd0fa6..e7c7230 100644
--- a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Storage.java
+++ b/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Storage.java
@@ -227,6 +227,12 @@ public final class Storage implements IStorage
 
             return chunk.next();
           }
+
+          @Override
+          public void remove()
+          {
+            throw new UnsupportedOperationException();
+          }
         };
       }
     };
diff --git a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/StorageService.java b/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/StorageService.java
index 33eafdc..eb5dcb1 100644
--- a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/StorageService.java
+++ b/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/StorageService.java
@@ -12,6 +12,7 @@ package org.eclipse.userstorage.internal;
 
 import org.eclipse.userstorage.IStorageService;
 import org.eclipse.userstorage.internal.util.StringUtil;
+import org.eclipse.userstorage.spi.Credentials;
 import org.eclipse.userstorage.spi.ICredentialsProvider;
 import org.eclipse.userstorage.util.ConflictException;
 
diff --git a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Credentials.java b/org.eclipse.userstorage/src/org/eclipse/userstorage/spi/Credentials.java
index 579a57a..9e78cbe 100644
--- a/org.eclipse.userstorage/src/org/eclipse/userstorage/internal/Credentials.java
+++ b/org.eclipse.userstorage/src/org/eclipse/userstorage/spi/Credentials.java
@@ -8,7 +8,7 @@
  * Contributors:
  *    Eike Stepper - initial API and implementation
  */
-package org.eclipse.userstorage.internal;
+package org.eclipse.userstorage.spi;
 
 import org.eclipse.userstorage.internal.util.StringUtil;
 
@@ -16,6 +16,8 @@ import java.io.Serializable;
 import java.util.Arrays;
 
 /**
+ * Represents the credentials of a user.
+ *
  * @author Eike Stepper
  */
 public final class Credentials implements Serializable
@@ -26,26 +28,48 @@ public final class Credentials implements Serializable
 
   private byte[] password;
 
+  /**
+   * Public constructor to make this class {@link Serializable}.
+   */
   public Credentials()
   {
   }
 
+  /**
+   * Constructs these credentials with the given parameters.
+   *
+   * @param username The user name of the user.<p>
+   * @param password The password of the user.<p>
+   */
   public Credentials(String username, String password)
   {
     this.username = username;
     this.password = StringUtil.encrypt(password);
   }
 
+  /**
+   * Returns the user name of this user.
+   *
+   * @return the user name of this user.<p>
+   */
   public String getUsername()
   {
     return username;
   }
 
+  /**
+   * Returns the password of this user.
+   *
+   * @return the password of this user.<p>
+   */
   public String getPassword()
   {
     return StringUtil.decrypt(password);
   }
 
+  /**
+   * {@inheritDoc}
+   */
   @Override
   public int hashCode()
   {
@@ -56,6 +80,9 @@ public final class Credentials implements Serializable
     return result;
   }
 
+  /**
+   * {@inheritDoc}
+   */
   @Override
   public boolean equals(Object obj)
   {
@@ -95,6 +122,9 @@ public final class Credentials implements Serializable
     return true;
   }
 
+  /**
+  * {@inheritDoc}
+  */
   @Override
   public String toString()
   {
diff --git a/org.eclipse.userstorage/src/org/eclipse/userstorage/spi/ICredentialsProvider.java b/org.eclipse.userstorage/src/org/eclipse/userstorage/spi/ICredentialsProvider.java
index 222c590..006b8de 100644
--- a/org.eclipse.userstorage/src/org/eclipse/userstorage/spi/ICredentialsProvider.java
+++ b/org.eclipse.userstorage/src/org/eclipse/userstorage/spi/ICredentialsProvider.java
@@ -12,7 +12,6 @@ package org.eclipse.userstorage.spi;
 
 import org.eclipse.userstorage.IStorageService;
 import org.eclipse.userstorage.internal.Activator;
-import org.eclipse.userstorage.internal.Credentials;
 
 /**
  * Provides the user's credentials for a given {@link IStorageService storage service}.