fixed javadoc

14 files changed, 118 insertions, 71 deletions

diff --git a/bundles/runtime/org.eclipse.fx.osgi.util/src/org/eclipse/fx/osgi/util/OSGiFXMLLoader.java b/bundles/runtime/org.eclipse.fx.osgi.util/src/org/eclipse/fx/osgi/util/OSGiFXMLLoader.java
index 03cdf56e8..5c2a24514 100755
--- a/bundles/runtime/org.eclipse.fx.osgi.util/src/org/eclipse/fx/osgi/util/OSGiFXMLLoader.java
+++ b/bundles/runtime/org.eclipse.fx.osgi.util/src/org/eclipse/fx/osgi/util/OSGiFXMLLoader.java
@@ -51,6 +51,8 @@ public class OSGiFXMLLoader {
 	 *            the translation to be used

 	 * @param builderFactory

 	 *            the builder factory to use

+	 * @param <O>

+	 *            the loaded root object type

 	 * @return the created scene graph

 	 * @throws IOException

 	 *             if the FXML could not be loaded

@@ -75,6 +77,8 @@ public class OSGiFXMLLoader {
 	 *            the translation to be used

 	 * @param builderFactory

 	 *            the builder factory to use

+	 * @param <O>

+	 *            the loaded root object type

 	 * @return the created scene graph

 	 * @throws IOException

 	 *             if the FXML could not be loaded

@@ -98,6 +102,8 @@ public class OSGiFXMLLoader {
 	 *            the translation to be used

 	 * @param builderFactory

 	 *            the builder factory to use

+	 * @param <O>

+	 *            the loaded root object type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -121,6 +127,10 @@ public class OSGiFXMLLoader {
 	 *            the translation to be used

 	 * @param builderFactory

 	 *            the builder factory to use

+	 * @param <O>

+	 *            the loaded root object type

+	 * @param <C>

+	 *            the loaded controller type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -143,6 +153,8 @@ public class OSGiFXMLLoader {
 	 *            the translations

 	 * @param builderFactory

 	 *            the builder factory

+	 * @param <O>

+	 *            the loaded root object type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -162,6 +174,10 @@ public class OSGiFXMLLoader {
 	 *            the translations

 	 * @param builderFactory

 	 *            the builder factory

+	 * @param <O>

+	 *            the loaded root object type

+	 * @param <C>

+	 *            the loaded controller type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -182,6 +198,8 @@ public class OSGiFXMLLoader {
 	 *            the builder factory to use

 	 * @param controllerFactory

 	 *            the controller factory

+	 * @param <O>

+	 *            the loaded root object type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -207,6 +225,10 @@ public class OSGiFXMLLoader {
 	 *            the builder factory to use

 	 * @param controllerFactory

 	 *            the controller factory

+	 * @param <O>

+	 *            the loaded root object type

+	 * @param <C>

+	 *            the loaded controller type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -231,6 +253,8 @@ public class OSGiFXMLLoader {
 	 *            the builder factory to use

 	 * @param controllerFactory

 	 *            the controller factory

+	 * @param <O>

+	 *            the loaded root object type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -256,6 +280,10 @@ public class OSGiFXMLLoader {
 	 *            the builder factory to use

 	 * @param controllerFactory

 	 *            the controller factory

+	 * @param <O>

+	 *            the loaded root object type

+	 * @param <C>

+	 *            the loaded controller type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -280,6 +308,8 @@ public class OSGiFXMLLoader {
 	 *            the builder factory

 	 * @param controllerFactory

 	 *            the controller factory

+	 * @param <O>

+	 *            the loaded root object type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

@@ -301,6 +331,10 @@ public class OSGiFXMLLoader {
 	 *            the builder factory

 	 * @param controllerFactory

 	 *            the controller factory

+	 * @param <O>

+	 *            the loaded root object type

+	 * @param <C>

+	 *            the loaded controller type

 	 * @return the created scene graph

 	 * @throws IOException

 	 */

diff --git a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/image/FontIconView.java b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/image/FontIconView.java
index 9787bb3f3..56aff711f 100644
--- a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/image/FontIconView.java
+++ b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/image/FontIconView.java
@@ -55,14 +55,6 @@ public class FontIconView extends Control {
 		return uri;
 	}
 
-	/**
-	 * Most Controls return true for focusTraversable, so Control overrides this
-	 * method to return true, but Label returns false for focusTraversable's
-	 * initial value; hence the override of the override. This method is called
-	 * from CSS code to get the correct initial value.
-	 * 
-	 * @treatAsPrivate implementation detail
-	 */
 	@Deprecated
 	@Override
 	protected/* do not make final */Boolean impl_cssGetFocusTraversableInitialValue() {
diff --git a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/markers/TabOutlineMarker.java b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/markers/TabOutlineMarker.java
index 50a2dd5ad..0eb89da77 100644
--- a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/markers/TabOutlineMarker.java
+++ b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/markers/TabOutlineMarker.java
@@ -138,7 +138,6 @@ public final class TabOutlineMarker extends Group {
 
 	/**
 	 * The fill property
-	 * <p>
 	 * <table>
 	 * <tr>
 	 * <td>The default value is {@link Color#ORANGE}</td>
@@ -147,7 +146,6 @@ public final class TabOutlineMarker extends Group {
 	 * ></div></td>
 	 * </tr>
 	 * </table>
-	 * </p>
 	 * 
 	 * @return the property
 	 */
@@ -157,7 +155,6 @@ public final class TabOutlineMarker extends Group {
 
 	/**
 	 * Set a new fill
-	 * <p>
 	 * <table>
 	 * <tr>
 	 * <td>The default value is {@link Color#ORANGE}</td>
@@ -166,7 +163,6 @@ public final class TabOutlineMarker extends Group {
 	 * ></div></td>
 	 * </tr>
 	 * </table>
-	 * </p>
 	 * 
 	 * @param fill
 	 *            the fill
@@ -177,7 +173,6 @@ public final class TabOutlineMarker extends Group {
 
 	/**
 	 * Get the current fill
-	 * <p>
 	 * <table>
 	 * <tr>
 	 * <td>The default value is {@link Color#ORANGE}</td>
@@ -186,7 +181,6 @@ public final class TabOutlineMarker extends Group {
 	 * ></div></td>
 	 * </tr>
 	 * </table>
-	 * </p>
 	 * 
 	 * @return the current fill
 	 */
diff --git a/bundles/runtime/org.eclipse.fx.ui.databinding/.classpath b/bundles/runtime/org.eclipse.fx.ui.databinding/.classpath
index eca7bdba8..22f30643c 100644
--- a/bundles/runtime/org.eclipse.fx.ui.databinding/.classpath
+++ b/bundles/runtime/org.eclipse.fx.ui.databinding/.classpath
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
+	<classpathentry kind="src" path="src"/>
 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
 	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
-	<classpathentry kind="src" path="src"/>
 	<classpathentry kind="output" path="bin"/>
 </classpath>
diff --git a/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/PropertyListCellFaytory.java b/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/PropertyListCellFaytory.java
index 3c701c7b4..7ea055941 100644
--- a/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/PropertyListCellFaytory.java
+++ b/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/PropertyListCellFaytory.java
@@ -28,19 +28,19 @@ import org.eclipse.jdt.annotation.NonNull;
  * @param <O>
  *            the type
  */
-public interface PropertyListCellFaytory<O> extends
-		Callback<ListView<O>, ListCell<O>> {
+public interface PropertyListCellFaytory<O> extends Callback<ListView<O>, ListCell<O>> {
 	/**
 	 * Create a factory who uses the given property as the cells text content
 	 * 
 	 * @param textProperty
 	 *            the property
+	 * @param <O>
+	 *            the type
 	 * @return a factory instance
 	 * @see #textCell(IValueProperty)
 	 */
 	@NonNull
-	public static <O> PropertyListCellFaytory<O> textFactory(
-			@NonNull final IValueProperty textProperty) {
+	public static <O> PropertyListCellFaytory<O> textFactory(@NonNull final IValueProperty textProperty) {
 		return (param) -> textCell(textProperty);
 	}
 
@@ -52,11 +52,12 @@ public interface PropertyListCellFaytory<O> extends
 	 *            the template
 	 * @param textProperties
 	 *            the properties
+	 * @param <O>
+	 *            the type
 	 * @return a factory instance
 	 */
 	@NonNull
-	public static <O> PropertyListCellFaytory<O> textFactory(
-			@NonNull final String template, @NonNull final IValueProperty... textProperties) {
+	public static <O> PropertyListCellFaytory<O> textFactory(@NonNull final String template, @NonNull final IValueProperty... textProperties) {
 		return (param) -> textCell(template, textProperties);
 	}
 
@@ -66,6 +67,8 @@ public interface PropertyListCellFaytory<O> extends
 	 * 
 	 * @param textProperty
 	 *            the text property
+	 * @param <O>
+	 *            the type
 	 * @return the list cell
 	 */
 	@NonNull
@@ -82,12 +85,13 @@ public interface PropertyListCellFaytory<O> extends
 	 *            the template
 	 * @param textProperties
 	 *            the properties
+	 * @param <O>
+	 *            the type
 	 * @return the list cell
 	 */
 	@NonNull
-	public static <O> ListCell<O> textCell(@NonNull String template,
-			@NonNull IValueProperty... textProperties) {
+	public static <O> ListCell<O> textCell(@NonNull String template, @NonNull IValueProperty... textProperties) {
 		return new TemplateTextOnlyPropertyListCell<>(template, textProperties);
 	}
-	
+
 }
diff --git a/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/PropertyTableCellFactory.java b/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/PropertyTableCellFactory.java
index af8a474e8..1128d4001 100644
--- a/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/PropertyTableCellFactory.java
+++ b/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/PropertyTableCellFactory.java
@@ -29,19 +29,21 @@ import org.eclipse.jdt.annotation.NonNull;
  * @param <T>
  *            the cell value type
  */
-public interface PropertyTableCellFactory<S, T> extends
-		Callback<TableColumn<S, T>, TableCell<S, T>> {
+public interface PropertyTableCellFactory<S, T> extends Callback<TableColumn<S, T>, TableCell<S, T>> {
 	/**
 	 * Create a factory who uses the given property for the text
 	 * 
 	 * @param property
 	 *            the property
+	 * @param <S>
+	 *            the row value type
+	 * @param <T>
+	 *            the cell value type
 	 * @return the factory instance
 	 * @see #textCell(IValueProperty)
 	 */
 	@NonNull
-	public static <S, T> PropertyTableCellFactory<S, T> textFactory(
-			@NonNull final IValueProperty property) {
+	public static <S, T> PropertyTableCellFactory<S, T> textFactory(@NonNull final IValueProperty property) {
 		return (param) -> textCell(property);
 	}
 
@@ -53,12 +55,15 @@ public interface PropertyTableCellFactory<S, T> extends
 	 *            the template
 	 * @param property
 	 *            the property
+	 * @param <S>
+	 *            the row value type
+	 * @param <T>
+	 *            the cell value type
 	 * @return the factory instance
 	 * @see #textCell(String, IValueProperty...)
 	 */
 	@NonNull
-	public static <S, T> PropertyTableCellFactory<S, T> textFactory(
-			@NonNull final String template, @NonNull final IValueProperty... property) {
+	public static <S, T> PropertyTableCellFactory<S, T> textFactory(@NonNull final String template, @NonNull final IValueProperty... property) {
 		return (param) -> textCell(template, property);
 	}
 
@@ -67,6 +72,10 @@ public interface PropertyTableCellFactory<S, T> extends
 	 * 
 	 * @param property
 	 *            the property
+	 * @param <S>
+	 *            the row value type
+	 * @param <T>
+	 *            the cell value type
 	 * @return the table cell
 	 */
 	@NonNull
@@ -82,11 +91,14 @@ public interface PropertyTableCellFactory<S, T> extends
 	 *            the template
 	 * @param property
 	 *            the property
+	 * @param <S>
+	 *            the row value type
+	 * @param <T>
+	 *            the cell value type
 	 * @return the table cell
 	 */
-	@NonNull 
-	public static <S, T> TableCell<S, T> textCell(@NonNull String template,
-			@NonNull IValueProperty... property) {
+	@NonNull
+	public static <S, T> TableCell<S, T> textCell(@NonNull String template, @NonNull IValueProperty... property) {
 		return new TemplateTextOnlyPropertyTableCell<>(template, property);
 	}
 }
diff --git a/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/TableUtil.java b/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/TableUtil.java
index 6687c2d97..2f47c01cc 100644
--- a/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/TableUtil.java
+++ b/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/TableUtil.java
@@ -30,13 +30,13 @@ public class TableUtil {
 	 *            the column
 	 * @param property
 	 *            the property
+	 * @param <S>
+	 *            row and cell type
 	 * @see PropertyTableCellFactory#textFactory(IValueProperty)
 	 */
-	public static <S> void setupColumn(@NonNull TableColumn<S, S> column,
-			@NonNull IValueProperty property) {
+	public static <S> void setupColumn(@NonNull TableColumn<S, S> column, @NonNull IValueProperty property) {
 		column.setCellValueFactory((param) -> new SimpleObjectProperty<S>(param.getValue()));
-		column.setCellFactory(PropertyTableCellFactory
-				.<S, S> textFactory(property));
+		column.setCellFactory(PropertyTableCellFactory.<S, S> textFactory(property));
 	}
 
 	/**
@@ -49,12 +49,12 @@ public class TableUtil {
 	 *            the template
 	 * @param property
 	 *            the properties
+	 * @param <S>
+	 *            row and cell type
 	 * @see PropertyTableCellFactory#textFactory(String, IValueProperty...)
 	 */
-	public static <S> void setupColumn(@NonNull TableColumn<S, S> column,
-			@NonNull String template, @NonNull IValueProperty... property) {
+	public static <S> void setupColumn(@NonNull TableColumn<S, S> column, @NonNull String template, @NonNull IValueProperty... property) {
 		column.setCellValueFactory((param) -> new SimpleObjectProperty<S>(param.getValue()));
-		column.setCellFactory(PropertyTableCellFactory.<S, S> textFactory(
-				template, property));
+		column.setCellFactory(PropertyTableCellFactory.<S, S> textFactory(template, property));
 	}
 }
diff --git a/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/TreeUtil.java b/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/TreeUtil.java
index 5a28120de..1f19203b0 100755
--- a/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/TreeUtil.java
+++ b/bundles/runtime/org.eclipse.fx.ui.databinding/src/org/eclipse/fx/ui/databinding/TreeUtil.java
@@ -32,23 +32,27 @@ public class TreeUtil {
 	 *            the root of the model
 	 * @param factory
 	 *            the factory to create children
+	 * @param <T>
+	 *            the the item value type
 	 * @return the tree item backed by the given root model instance
 	 */
-	@NonNull 
-	public static <T> TreeItem<T> createModel(@NonNull T root,
-			@NonNull ObservableFactory<T> factory) {
+	@NonNull
+	public static <T> TreeItem<T> createModel(@NonNull T root, @NonNull ObservableFactory<T> factory) {
 		return new TreeItemImpl<T>(root, factory);
 	}
 
 	/**
 	 * Factory to create child observables
 	 * 
-	 * @param <T> the type
+	 * @param <T>
+	 *            the type
 	 */
 	public interface ObservableFactory<T> {
 		/**
 		 * Create an observable list for the parent element
-		 * @param parent the parent
+		 * 
+		 * @param parent
+		 *            the parent
 		 * @return the list
 		 */
 		public IObservableList createObservable(@NonNull T parent);
@@ -74,12 +78,12 @@ public class TreeUtil {
 			return super.getChildren();
 		}
 
-//		public boolean isLeaf() {
-//			if (this.hasLoadedChildren == false) {
-//				loadChildren();
-//			}
-//			return super.getChildren().isEmpty();
-//		}
+		// public boolean isLeaf() {
+		// if (this.hasLoadedChildren == false) {
+		// loadChildren();
+		// }
+		// return super.getChildren().isEmpty();
+		// }
 
 		@SuppressWarnings("null")
 		private void loadChildren() {
@@ -99,8 +103,7 @@ public class TreeUtil {
 									if (t.getValue() == element) {
 										itemList.remove(index);
 									} else {
-										Iterator<TreeItem<T>> it = itemList
-												.iterator();
+										Iterator<TreeItem<T>> it = itemList.iterator();
 										while (it.hasNext()) {
 											if (it.next().getValue() == element) {
 												it.remove();
@@ -115,11 +118,9 @@ public class TreeUtil {
 							@Override
 							public void handleAdd(int index, Object element) {
 								if (itemList.size() > index) {
-									itemList.add(index, new TreeItemImpl<@NonNull T>(
-											(T) element, TreeItemImpl.this.factory));
+									itemList.add(index, new TreeItemImpl<@NonNull T>((T) element, TreeItemImpl.this.factory));
 								} else {
-									itemList.add(new TreeItemImpl<@NonNull T>(
-											(T) element, TreeItemImpl.this.factory));
+									itemList.add(new TreeItemImpl<@NonNull T>((T) element, TreeItemImpl.this.factory));
 								}
 							}
 						});
diff --git a/bundles/runtime/org.eclipse.fx.ui.panes/src/org/eclipse/fx/ui/panes/RowLayoutPane.java b/bundles/runtime/org.eclipse.fx.ui.panes/src/org/eclipse/fx/ui/panes/RowLayoutPane.java
index 46c31e2a1..7a562bb7b 100755
--- a/bundles/runtime/org.eclipse.fx.ui.panes/src/org/eclipse/fx/ui/panes/RowLayoutPane.java
+++ b/bundles/runtime/org.eclipse.fx.ui.panes/src/org/eclipse/fx/ui/panes/RowLayoutPane.java
@@ -829,7 +829,7 @@ public class RowLayoutPane extends AbstractLayoutPane<RowData> {
 	 * The default is 0

 	 * </p>

 	 * 

-	 * @param value

+	 * @param value the value

 	 */

 	public void setMarginBottom(int value) {

 		marginBottomProperty().set(value);

diff --git a/bundles/runtime/org.eclipse.fx.ui.panes/src/panes.cssext b/bundles/runtime/org.eclipse.fx.ui.panes/src/panes.cssext
index 7b9945f4f..31db67e12 100644
--- a/bundles/runtime/org.eclipse.fx.ui.panes/src/panes.cssext
+++ b/bundles/runtime/org.eclipse.fx.ui.panes/src/panes.cssext
@@ -1,4 +1,5 @@
 import javafx.scene.layout.Pane

+

 package org.eclipse.fx.ui.panes {

 	AbstractLayoutPane extends Pane {

 		

diff --git a/bundles/runtime/org.eclipse.fx.ui.workbench.base/src/org/eclipse/fx/ui/workbench/base/rendering/RendererFactory.java b/bundles/runtime/org.eclipse.fx.ui.workbench.base/src/org/eclipse/fx/ui/workbench/base/rendering/RendererFactory.java
index 6e37c4d9e..f1ce14b25 100755
--- a/bundles/runtime/org.eclipse.fx.ui.workbench.base/src/org/eclipse/fx/ui/workbench/base/rendering/RendererFactory.java
+++ b/bundles/runtime/org.eclipse.fx.ui.workbench.base/src/org/eclipse/fx/ui/workbench/base/rendering/RendererFactory.java
@@ -22,6 +22,8 @@ public interface RendererFactory {
 	 * 
 	 * @param element
 	 *            the model element
+	 * @param <R>
+	 *            the renderer type
 	 * @return the renderer
 	 */
 	public <R extends ElementRenderer<?, ?>> @Nullable R getRenderer(MUIElement element);
diff --git a/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseRenderer.java b/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseRenderer.java
index fe0f57e6c..63f0a35e5 100755
--- a/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseRenderer.java
+++ b/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseRenderer.java
@@ -88,7 +88,7 @@ public abstract class BaseRenderer<M extends MUIElement, W extends WWidget<M>> i
 
 	@Inject
 	EModelService modelService;
-	
+
 	@Inject
 	EModelStylingService modelStylingService;
 
@@ -122,7 +122,8 @@ public abstract class BaseRenderer<M extends MUIElement, W extends WWidget<M>> i
 	public static final String CALCULATED_VISIBILITY = "efx_calculated_visibility"; //$NON-NLS-1$
 
 	/**
-	 * Constant used to remember the current state of the visible when expression
+	 * Constant used to remember the current state of the visible when
+	 * expression
 	 */
 	public static final String CURRENT_VISIBLE_WHEN = "efx_current_visible_when"; //$NON-NLS-1$
 
@@ -387,23 +388,20 @@ public abstract class BaseRenderer<M extends MUIElement, W extends WWidget<M>> i
 
 			if (changedObj instanceof MUIElement) {
 				if (e.getRenderer() == BaseRenderer.this) {
-					
+
 					if (attributeName.equals(UIEvents.ApplicationElement.TAGS)) {
 						MUIElement m = (MUIElement) changedObj;
 						if (m.getWidget() != null) {
 							if (UIEvents.isADD(event)) {
-								Collection<String> addedTags = Util.<String>asCollection(event, UIEvents.EventTags.NEW_VALUE);
-								((WWidget<?>) m.getWidget()).addStyleClasses(
-										this.modelStylingService.getStylesFromTags(new ArrayList<String>(addedTags)));
+								Collection<String> addedTags = Util.<String> asCollection(event, UIEvents.EventTags.NEW_VALUE);
+								((WWidget<?>) m.getWidget()).addStyleClasses(this.modelStylingService.getStylesFromTags(new ArrayList<String>(addedTags)));
 							} else if (UIEvents.isREMOVE(event)) {
-								Collection<String> removedTags = Util.<String>asCollection(event, UIEvents.EventTags.OLD_VALUE);
-								((WWidget<?>) m.getWidget()).removeStyleClasses(
-										this.modelStylingService.getStylesFromTags(new ArrayList<String>(removedTags)));
+								Collection<String> removedTags = Util.<String> asCollection(event, UIEvents.EventTags.OLD_VALUE);
+								((WWidget<?>) m.getWidget()).removeStyleClasses(this.modelStylingService.getStylesFromTags(new ArrayList<String>(removedTags)));
 							}
 						}
 					}
 
-				
 					IEclipseContext ctx = (IEclipseContext) e.getTransientData().get(RENDERING_CONTEXT_KEY);
 					if (ctx != null) {
 						if (attributeName.equals(UIEvents.ApplicationElement.PERSISTEDSTATE) && newValue instanceof Entry) {
@@ -542,6 +540,10 @@ public abstract class BaseRenderer<M extends MUIElement, W extends WWidget<M>> i
 	 * 
 	 * @param pm
 	 *            the model element
+	 * @param <LW>
+	 *            the widget type
+	 * @param <PM>
+	 *            the model type
 	 * @return the widget
 	 */
 	@SuppressWarnings("unchecked")
@@ -558,6 +560,10 @@ public abstract class BaseRenderer<M extends MUIElement, W extends WWidget<M>> i
 	 *            the model element
 	 * @param context
 	 *            the context
+	 * @param <LW>
+	 *            the widget type
+	 * @param <PM>
+	 *            the model type
 	 * @return the widget
 	 */
 	@SuppressWarnings("unchecked")
diff --git a/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseWorkbenchRendererFactory.java b/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseWorkbenchRendererFactory.java
index 84d857283..814df48af 100755
--- a/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseWorkbenchRendererFactory.java
+++ b/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseWorkbenchRendererFactory.java
@@ -237,6 +237,7 @@ public abstract class BaseWorkbenchRendererFactory implements RendererFactory {
 	 * 
 	 * @param rendererClass
 	 *            The renderer class to be instantiated.
+	 * @param <R> the renderer type
 	 * @return a new instance of the given renderer class.
 	 */
 	@NonNull
diff --git a/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/widget/WWidget.java b/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/widget/WWidget.java
index 9f5383889..ada501874 100755
--- a/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/widget/WWidget.java
+++ b/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/widget/WWidget.java
@@ -112,12 +112,12 @@ public interface WWidget<M extends MUIElement> {
 	 *            the classnames to add
 	 */
 	public void removeStyleClasses(@NonNull String... classnames);
-	
-	
+
 	/**
 	 * Set a style id used for an CSS ID-Selector in your css
 	 * 
 	 * @param id
+	 *            the style id
 	 */
 	public void setStyleId(@NonNull String id);