diff options
author | Marc Khouzam | 2016-10-27 15:03:41 +0000 |
---|---|---|
committer | Marc Khouzam | 2016-10-31 15:18:41 +0000 |
commit | d04019eacd32b5adc07a535975529e24f179381f (patch) | |
tree | 0a2b3aa1bf22be4062a4469d209a61dcce6a141f /debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui | |
parent | b0833f9e0c50e3180473c80d87b05a443a866225 (diff) | |
download | org.eclipse.cdt-d04019eacd32b5adc07a535975529e24f179381f.tar.gz org.eclipse.cdt-d04019eacd32b5adc07a535975529e24f179381f.tar.xz org.eclipse.cdt-d04019eacd32b5adc07a535975529e24f179381f.zip |
Simplify API that opens the DebuggerConsole
IDebuggerConsoleManager.showConsoleView() was mimicked on
IConsoleManager.showConsoleView() which allows to specify which console
in the view should now be shown.
This makes sense for the generic platform Console view where extenders
could choose to display any kind of console when an event happens (e.g.,
a build console when the build is started). However, in our Debugger
Console case, it complicates things unnecessarily. In our case, we want
to be able to open the view, but the console to show is handled by other
logic such as a synchronizer service.
And if there is a need to change which console should be shown within
the Debugger Console view, then IDebuggerConsoleView.display() should be
used. I think having it in IConsoleManager.showConsoleView() is a
shortcut that is not very useful in our case.
Change-Id: Id66ea5c953e8a7ab603cfc23789a814c1ad821d2
Diffstat (limited to 'debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui')
-rw-r--r-- | debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/debuggerconsole/IDebuggerConsoleManager.java | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/debuggerconsole/IDebuggerConsoleManager.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/debuggerconsole/IDebuggerConsoleManager.java index a66c3cf6be6..870a25a8d6e 100644 --- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/debuggerconsole/IDebuggerConsoleManager.java +++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/debuggerconsole/IDebuggerConsoleManager.java @@ -52,11 +52,8 @@ public interface IDebuggerConsoleManager { public IDebuggerConsole[] getConsoles(); /** - * Opens the console view and displays given the console. + * Opens the console view. * If the view is already open, it is brought to the front. - * Has no effect if the given console is not currently registered. - * - * @param console console to display */ - public void showConsoleView(IDebuggerConsole console); + public void showConsoleView(); } |