Bug 491984 - Replace .equals("") with .isEmpty()

In many cases a String's empty status is tested with `.equals("")`.
However, Java 1.6 added `.isEmpty()` which can be more efficient since
it compares the internal length parameter only for testing. Replace
code using the `.isEmpty()` variant instead.

Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()`
where it is already known that the `expr` is not null; however,
these have to be reviewed on a case-by-case basis.

Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/build/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/internal/ui/MultipleInputDialog.java b/build/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/internal/ui/MultipleInputDialog.java
index 5d839eb42d3..1326d6c57d3 100644
--- a/build/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/internal/ui/MultipleInputDialog.java
+++ b/build/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/internal/ui/MultipleInputDialog.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2003, 2011 IBM Corporation and others.
+ * Copyright (c) 2003, 2016 IBM Corporation and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -148,7 +148,7 @@ public class MultipleInputDialog extends Dialog {
 			validators.add(new Validator() {
 				@Override
 				public boolean validate() {
-					return !text.getText().equals(""); //$NON-NLS-1$
+					return !text.getText().isEmpty();
 				}
 			});
 			text.addModifyListener(new ModifyListener() {
@@ -191,7 +191,7 @@ public class MultipleInputDialog extends Dialog {
 			validators.add(new Validator() {
 				@Override
 				public boolean validate() {
-					return !text.getText().equals(""); //$NON-NLS-1$
+					return !text.getText().isEmpty();
 				}
 			});
 
@@ -210,7 +210,7 @@ public class MultipleInputDialog extends Dialog {
 				DirectoryDialog dialog = new DirectoryDialog(getShell());
 				dialog.setMessage(MakeUIPlugin.getResourceString("MultipleInputDialog.1")); //$NON-NLS-1$
 				String currentWorkingDir = text.getText();
-				if (!currentWorkingDir.trim().equals("")) { //$NON-NLS-1$
+				if (!currentWorkingDir.trim().isEmpty()) {
 					File path = new File(currentWorkingDir);
 					if (path.exists()) {
 						dialog.setFilterPath(currentWorkingDir);
@@ -258,7 +258,7 @@ public class MultipleInputDialog extends Dialog {
 			validators.add(new Validator() {
 				@Override
 				public boolean validate() {
-					return !text.getText().equals(""); //$NON-NLS-1$
+					return !text.getText().isEmpty();
 				}
 			});