Bug 491984 - Replace .equals("") with .isEmpty()

In many cases a String's empty status is tested with `.equals("")`.
However, Java 1.6 added `.isEmpty()` which can be more efficient since
it compares the internal length parameter only for testing. Replace
code using the `.isEmpty()` variant instead.

Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()`
where it is already known that the `expr` is not null; however,
these have to be reviewed on a case-by-case basis.

Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>

2 files changed, 3 insertions, 3 deletions

diff --git a/build/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/core/MakeBuilder.java b/build/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/core/MakeBuilder.java
index 18a64ede80e..4d9b9ad51c1 100644
--- a/build/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/core/MakeBuilder.java
+++ b/build/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/core/MakeBuilder.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2012 QNX Software Systems and others.
+ * Copyright (c) 2000, 2016 QNX Software Systems and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -262,7 +262,7 @@ public class MakeBuilder extends ACBuilder {
 			}
 		} else {
 			String argsStr = info.getBuildArguments();
-			if (argsStr != null && !argsStr.equals("")) { //$NON-NLS-1$
+			if (argsStr != null && !argsStr.isEmpty()) {
 				String[] newArgs = makeArray(argsStr);
 				args = new String[targets.length + newArgs.length];
 				System.arraycopy(newArgs, 0, args, 0, newArgs.length);
diff --git a/build/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/ProjectTargets.java b/build/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/ProjectTargets.java
index 71c6150455b..6f4e705d052 100644
--- a/build/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/ProjectTargets.java
+++ b/build/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/ProjectTargets.java
@@ -256,7 +256,7 @@ public class ProjectTargets {
 					if (node.getName().equals(TARGET_ELEMENT)) {
 						IContainer container = null;
 						String path = node.getAttribute(TARGET_ATTR_PATH);
-						if (path != null && !path.equals("")) { //$NON-NLS-1$
+						if (path != null && !path.isEmpty()) {
 							container = project.getFolder(path);
 						} else {
 							container = project;