Target Explorer: fix possible npe

1 files changed, 194 insertions, 181 deletions

diff --git a/target_explorer/plugins/org.eclipse.tcf.te.ui.views/src/org/eclipse/tcf/te/ui/views/editor/pages/AbstractEditorPage.java b/target_explorer/plugins/org.eclipse.tcf.te.ui.views/src/org/eclipse/tcf/te/ui/views/editor/pages/AbstractEditorPage.java
index 744cba007..9e0d407c9 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.ui.views/src/org/eclipse/tcf/te/ui/views/editor/pages/AbstractEditorPage.java
+++ b/target_explorer/plugins/org.eclipse.tcf.te.ui.views/src/org/eclipse/tcf/te/ui/views/editor/pages/AbstractEditorPage.java
@@ -1,181 +1,194 @@
-/*******************************************************************************
- * Copyright (c) 2011, 2012 Wind River Systems, Inc. and others. All rights reserved.
- * This program and the accompanying materials are made available under the terms
- * of the Eclipse Public License v1.0 which accompanies this distribution, and is
- * available at http://www.eclipse.org/legal/epl-v10.html
- *
- * Contributors:
- * Wind River Systems - initial API and implementation
- *******************************************************************************/
-package org.eclipse.tcf.te.ui.views.editor.pages;
-
-import org.eclipse.core.runtime.Assert;
-import org.eclipse.core.runtime.IConfigurationElement;
-import org.eclipse.core.runtime.IProgressMonitor;
-import org.eclipse.core.runtime.IStatus;
-import org.eclipse.core.runtime.Status;
-import org.eclipse.jface.dialogs.IMessageProvider;
-import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.jface.viewers.SelectionChangedEvent;
-import org.eclipse.jface.viewers.StructuredSelection;
-import org.eclipse.osgi.util.NLS;
-import org.eclipse.tcf.te.runtime.nls.Messages;
-import org.eclipse.tcf.te.ui.jface.interfaces.IValidatingContainer;
-import org.eclipse.tcf.te.ui.views.activator.UIPlugin;
-import org.eclipse.tcf.te.ui.views.editor.Editor;
-import org.eclipse.tcf.te.ui.views.interfaces.IEditorPage;
-import org.eclipse.ui.IEditorInput;
-import org.eclipse.ui.forms.IManagedForm;
-import org.eclipse.ui.forms.editor.FormPage;
-import org.eclipse.ui.forms.widgets.ScrolledForm;
-import org.eclipse.ui.part.MultiPageSelectionProvider;
-
-
-/**
- * Abstract details editor page implementation.
- */
-public abstract class AbstractEditorPage extends FormPage implements IEditorPage, IValidatingContainer {
-	// The unique page id
-	private String id;
-
-	/**
-	 * Constructor.
-	 */
-	public AbstractEditorPage() {
-		super("", ""); // //$NON-NLS-1$ //$NON-NLS-2$
-	}
-
-	/* (non-Javadoc)
-	 * @see org.eclipse.ui.part.EditorPart#setInitializationData(org.eclipse.core.runtime.IConfigurationElement, java.lang.String, java.lang.Object)
-	 */
-	@Override
-	public void setInitializationData(IConfigurationElement config, String propertyName, Object data) {
-		super.setInitializationData(config, propertyName, data);
-
-		if (config != null) {
-			// Initialize the id field by reading the <id> extension attribute.
-			// Throws an exception if the id is empty or null.
-			id = config.getAttribute("id"); //$NON-NLS-1$
-			if (id == null || id.trim().length() == 0) {
-				IStatus status = new Status(IStatus.ERROR, UIPlugin.getUniqueIdentifier(),
-								NLS.bind(Messages.Extension_error_missingRequiredAttribute, "id", config.getContributor().getName())); //$NON-NLS-1$
-				UIPlugin.getDefault().getLog().log(status);
-			}
-		}
-	}
-
-	/* (non-Javadoc)
-	 * @see org.eclipse.ui.forms.editor.FormPage#getId()
-	 */
-	@Override
-	public String getId() {
-		return id;
-	}
-
-	/* (non-Javadoc)
-	 * @see org.eclipse.ui.forms.editor.FormPage#createFormContent(org.eclipse.ui.forms.IManagedForm)
-	 */
-	@Override
-	protected void createFormContent(IManagedForm managedForm) {
-		super.createFormContent(managedForm);
-		Assert.isNotNull(managedForm);
-		managedForm.setInput(getEditorInputNode());
-	}
-
-	/* (non-Javadoc)
-	 * @see org.eclipse.ui.part.EditorPart#setInput(org.eclipse.ui.IEditorInput)
-	 */
-	@Override
-	protected void setInput(IEditorInput input) {
-		super.setInput(input);
-		// Update the managed form too
-		if (getManagedForm() != null) {
-			getManagedForm().setInput(getEditorInputNode());
-		}
-		getSite().getSelectionProvider().setSelection(input != null ? new StructuredSelection(getEditorInputNode()) : null);
-	}
-
-	/* (non-Javadoc)
-	 * @see org.eclipse.ui.part.EditorPart#setInputWithNotify(org.eclipse.ui.IEditorInput)
-	 */
-	@Override
-	protected void setInputWithNotify(IEditorInput input) {
-		super.setInputWithNotify(input);
-		// Update the managed form too
-		if (getManagedForm() != null) {
-			getManagedForm().setInput(getEditorInputNode());
-		}
-		getSite().getSelectionProvider().setSelection(input != null ? new StructuredSelection(getEditorInputNode()) : null);
-	}
-
-	/* (non-Javadoc)
-	 * @see org.eclipse.ui.forms.editor.FormPage#setActive(boolean)
-	 */
-	@Override
-	public void setActive(boolean active) {
-		super.setActive(active);
-		if (!active) {
-			ISelection selection = getEditorInput() != null ? new StructuredSelection(getEditorInputNode()) : null;
-			getSite().getSelectionProvider().setSelection(selection);
-			if (getSite().getSelectionProvider() instanceof MultiPageSelectionProvider) {
-				SelectionChangedEvent changedEvent = new SelectionChangedEvent(getSite().getSelectionProvider(), selection);
-				((MultiPageSelectionProvider) getSite().getSelectionProvider()).firePostSelectionChanged(changedEvent);
-			}
-		}
-	}
-
-	/**
-	 * Returns the node associated with the current editor input.
-	 *
-	 * @return The node or <code>null</code>.
-	 */
-	public Object getEditorInputNode() {
-		IEditorInput input = getEditorInput();
-		return input != null ? input.getAdapter(Object.class) : null;
-	}
-
-	/**
-	 * Called from the parent properties editor <code>doSave(IProgressMonitor)</code>
-	 * method.
-	 *
-	 * @param monitor The progress monitor or <code>null</code>
-	 * @see Editor#doSave(IProgressMonitor)
-	 */
-	public void preDoSave(IProgressMonitor monitor) {
-		// do nothing
-	}
-
-	/**
-	 * Called from the parent properties editor <code>doSave(IProgressMonitor)</code>
-	 * method.
-	 *
-	 * @param monitor The progress monitor or <code>null</code>
-	 * @see Editor#doSave(IProgressMonitor)
-	 */
-	public void postDoSave(IProgressMonitor monitor) {
-		// do nothing
-	}
-
-	/* (non-Javadoc)
-	 * @see org.eclipse.tcf.te.ui.jface.interfaces.IValidatingContainer#validate()
-	 */
-	@Override
-	public final void validate() {
-		// Get the scrolled form
-		ScrolledForm form = getManagedForm().getForm();
-
-		ValidationResult result = doValidate();
-		if (result != null) {
-			form.setMessage(result.getMessage(), result.getMessageType());
-		}
-		else {
-			form.setMessage(null, IMessageProvider.NONE);
-		}
-	}
-
-	/**
-	 * Do the validation.
-	 * @return The validation result or <code>null</code>.
-	 */
-	protected abstract ValidationResult doValidate();
-}
+/*******************************************************************************

+ * Copyright (c) 2011, 2012 Wind River Systems, Inc. and others. All rights reserved.

+ * This program and the accompanying materials are made available under the terms

+ * of the Eclipse Public License v1.0 which accompanies this distribution, and is

+ * available at http://www.eclipse.org/legal/epl-v10.html

+ *

+ * Contributors:

+ * Wind River Systems - initial API and implementation

+ *******************************************************************************/

+package org.eclipse.tcf.te.ui.views.editor.pages;

+

+import org.eclipse.core.runtime.Assert;

+import org.eclipse.core.runtime.IConfigurationElement;

+import org.eclipse.core.runtime.IProgressMonitor;

+import org.eclipse.core.runtime.IStatus;

+import org.eclipse.core.runtime.Status;

+import org.eclipse.jface.dialogs.IMessageProvider;

+import org.eclipse.jface.viewers.ISelection;

+import org.eclipse.jface.viewers.SelectionChangedEvent;

+import org.eclipse.jface.viewers.StructuredSelection;

+import org.eclipse.osgi.util.NLS;

+import org.eclipse.tcf.te.runtime.nls.Messages;

+import org.eclipse.tcf.te.ui.jface.interfaces.IValidatingContainer;

+import org.eclipse.tcf.te.ui.views.activator.UIPlugin;

+import org.eclipse.tcf.te.ui.views.editor.Editor;

+import org.eclipse.tcf.te.ui.views.interfaces.IEditorPage;

+import org.eclipse.ui.IEditorInput;

+import org.eclipse.ui.forms.IManagedForm;

+import org.eclipse.ui.forms.editor.FormPage;

+import org.eclipse.ui.forms.widgets.ScrolledForm;

+import org.eclipse.ui.part.MultiPageSelectionProvider;

+

+/**

+ * Abstract details editor page implementation.

+ */

+public abstract class AbstractEditorPage extends FormPage implements IEditorPage, IValidatingContainer {

+	// The unique page id

+	private String id;

+

+	/**

+	 * Constructor.

+	 */

+	public AbstractEditorPage() {

+		super("", ""); // //$NON-NLS-1$ //$NON-NLS-2$

+	}

+

+	/*

+	 * (non-Javadoc)

+	 * @see org.eclipse.ui.part.EditorPart#setInitializationData(org.eclipse.core.runtime.

+	 * IConfigurationElement, java.lang.String, java.lang.Object)

+	 */

+	@Override

+	public void setInitializationData(IConfigurationElement config, String propertyName, Object data) {

+		super.setInitializationData(config, propertyName, data);

+

+		if (config != null) {

+			// Initialize the id field by reading the <id> extension attribute.

+			// Throws an exception if the id is empty or null.

+			id = config.getAttribute("id"); //$NON-NLS-1$

+			if (id == null || id.trim().length() == 0) {

+				IStatus status = new Status(IStatus.ERROR, UIPlugin.getUniqueIdentifier(), NLS

+				                .bind(Messages.Extension_error_missingRequiredAttribute, "id", config.getContributor().getName())); //$NON-NLS-1$

+				UIPlugin.getDefault().getLog().log(status);

+			}

+		}

+	}

+

+	/*

+	 * (non-Javadoc)

+	 * @see org.eclipse.ui.forms.editor.FormPage#getId()

+	 */

+	@Override

+	public String getId() {

+		return id;

+	}

+

+	/*

+	 * (non-Javadoc)

+	 * @see

+	 * org.eclipse.ui.forms.editor.FormPage#createFormContent(org.eclipse.ui.forms.IManagedForm)

+	 */

+	@Override

+	protected void createFormContent(IManagedForm managedForm) {

+		super.createFormContent(managedForm);

+		Assert.isNotNull(managedForm);

+		managedForm.setInput(getEditorInputNode());

+	}

+

+	/*

+	 * (non-Javadoc)

+	 * @see org.eclipse.ui.part.EditorPart#setInput(org.eclipse.ui.IEditorInput)

+	 */

+	@Override

+	protected void setInput(IEditorInput input) {

+		super.setInput(input);

+		// Update the managed form too

+		if (getManagedForm() != null) {

+			getManagedForm().setInput(getEditorInputNode());

+		}

+		getSite().getSelectionProvider()

+		                .setSelection(input != null ? new StructuredSelection(getEditorInputNode()) : null);

+	}

+

+	/*

+	 * (non-Javadoc)

+	 * @see org.eclipse.ui.part.EditorPart#setInputWithNotify(org.eclipse.ui.IEditorInput)

+	 */

+	@Override

+	protected void setInputWithNotify(IEditorInput input) {

+		super.setInputWithNotify(input);

+		// Update the managed form too

+		if (getManagedForm() != null) {

+			getManagedForm().setInput(getEditorInputNode());

+		}

+		getSite().getSelectionProvider()

+		                .setSelection(input != null ? new StructuredSelection(getEditorInputNode()) : null);

+	}

+

+	/*

+	 * (non-Javadoc)

+	 * @see org.eclipse.ui.forms.editor.FormPage#setActive(boolean)

+	 */

+	@Override

+	public void setActive(boolean active) {

+		super.setActive(active);

+		if (!active) {

+			ISelection selection = getEditorInput() != null ? new StructuredSelection(getEditorInputNode()) : null;

+			getSite().getSelectionProvider().setSelection(selection);

+			if (getSite().getSelectionProvider() instanceof MultiPageSelectionProvider) {

+				SelectionChangedEvent changedEvent = new SelectionChangedEvent(getSite()

+				                .getSelectionProvider(), selection);

+				((MultiPageSelectionProvider) getSite().getSelectionProvider())

+				                .firePostSelectionChanged(changedEvent);

+			}

+		}

+	}

+

+	/**

+	 * Returns the node associated with the current editor input.

+	 *

+	 * @return The node or <code>null</code>.

+	 */

+	public Object getEditorInputNode() {

+		IEditorInput input = getEditorInput();

+		return input != null ? input.getAdapter(Object.class) : null;

+	}

+

+	/**

+	 * Called from the parent properties editor <code>doSave(IProgressMonitor)</code> method.

+	 *

+	 * @param monitor The progress monitor or <code>null</code>

+	 * @see Editor#doSave(IProgressMonitor)

+	 */

+	public void preDoSave(IProgressMonitor monitor) {

+		// do nothing

+	}

+

+	/**

+	 * Called from the parent properties editor <code>doSave(IProgressMonitor)</code> method.

+	 *

+	 * @param monitor The progress monitor or <code>null</code>

+	 * @see Editor#doSave(IProgressMonitor)

+	 */

+	public void postDoSave(IProgressMonitor monitor) {

+		// do nothing

+	}

+

+	/*

+	 * (non-Javadoc)

+	 * @see org.eclipse.tcf.te.ui.jface.interfaces.IValidatingContainer#validate()

+	 */

+	@Override

+	public final void validate() {

+		// Get the scrolled form

+		if (getManagedForm() != null) {

+			ScrolledForm form = getManagedForm().getForm();

+

+			ValidationResult result = doValidate();

+			if (result != null) {

+				form.setMessage(result.getMessage(), result.getMessageType());

+			}

+			else {

+				form.setMessage(null, IMessageProvider.NONE);

+			}

+		}

+	}

+

+	/**

+	 * Do the validation.

+	 *

+	 * @return The validation result or <code>null</code>.

+	 */

+	protected abstract ValidationResult doValidate();

+}