Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2013-11-11 15:08:08 +0000
committerLars Vogel2013-11-11 15:08:08 +0000
commit80933675ac47de684bbc3ee859a808a5eddfb166 (patch)
treeb1afcc77e160293179b0a1da8f59fe8355a9089f /bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat
parenta933cd60515d47fb76c33e81b328d71b3dcbc06b (diff)
downloadeclipse.platform.ui.tools-80933675ac47de684bbc3ee859a808a5eddfb166.tar.gz
eclipse.platform.ui.tools-80933675ac47de684bbc3ee859a808a5eddfb166.tar.xz
eclipse.platform.ui.tools-80933675ac47de684bbc3ee859a808a5eddfb166.zip
Bug 421453 - Code cleanup in the e4 tools projects
Change-Id: I0a2100222f73a4cd986099b2d7126f7992a82987 Signed-off-by: Lars Vogel <Lars.Vogel@gmail.com>
Diffstat (limited to 'bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat')
-rw-r--r--bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/ContextServiceFactory.java10
-rw-r--r--bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/DefaultLoggerProvider.java2
-rw-r--r--bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/WorkbenchLogger.java11
-rw-r--r--bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/parts/DISaveableViewPart.java1
4 files changed, 18 insertions, 6 deletions
diff --git a/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/ContextServiceFactory.java b/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/ContextServiceFactory.java
index f487fdef..e7b2ccb7 100644
--- a/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/ContextServiceFactory.java
+++ b/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/ContextServiceFactory.java
@@ -97,20 +97,20 @@ public class ContextServiceFactory extends AbstractServiceFactory {
public void setClassname(Object widget, String classname) {
((Widget) widget).setData(
"org.eclipse.e4.ui.css.CssClassName", classname); //$NON-NLS-1$
- engine.applyStyles((Widget) widget, true);
+ engine.applyStyles(widget, true);
}
public void setId(Object widget, String id) {
((Widget) widget).setData("org.eclipse.e4.ui.css.id", id); //$NON-NLS-1$
- engine.applyStyles((Widget) widget, true);
+ engine.applyStyles(widget, true);
}
public void style(Object widget) {
- engine.applyStyles((Widget) widget, true);
+ engine.applyStyles(widget, true);
}
public CSSStyleDeclaration getStyle(Object widget) {
- return engine.getStyle((Widget) widget);
+ return engine.getStyle(widget);
}
public void setClassnameAndId(Object widget, String classname,
@@ -118,7 +118,7 @@ public class ContextServiceFactory extends AbstractServiceFactory {
((Widget) widget).setData(
"org.eclipse.e4.ui.css.CssClassName", classname); //$NON-NLS-1$
((Widget) widget).setData("org.eclipse.e4.ui.css.id", id); //$NON-NLS-1$
- engine.applyStyles((Widget) widget, true);
+ engine.applyStyles(widget, true);
}
});
diff --git a/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/DefaultLoggerProvider.java b/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/DefaultLoggerProvider.java
index b3f922b0..5f0a7a6b 100644
--- a/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/DefaultLoggerProvider.java
+++ b/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/DefaultLoggerProvider.java
@@ -15,6 +15,6 @@ public class DefaultLoggerProvider implements ILoggerProvider {
public Logger getClassLogger(Class<?> clazz) {
IEclipseContext childContext = context.createChild();
childContext.set("logger.bundlename", FrameworkUtil.getBundle(clazz).getSymbolicName()); //$NON-NLS-1$
- return (Logger) ContextInjectionFactory.make(WorkbenchLogger.class, childContext);
+ return ContextInjectionFactory.make(WorkbenchLogger.class, childContext);
}
} \ No newline at end of file
diff --git a/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/WorkbenchLogger.java b/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/WorkbenchLogger.java
index ff8cbf85..eb14dfa4 100644
--- a/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/WorkbenchLogger.java
+++ b/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/internal/WorkbenchLogger.java
@@ -30,14 +30,17 @@ public final class WorkbenchLogger extends Logger {
super();
}
+ @Override
public void debug(Throwable t) {
debug(t, null);
}
+ @Override
public void debug(Throwable t, String message) {
trace(t, message);
}
+ @Override
public void error(Throwable t, String message) {
log(new Status(IStatus.ERROR, bundle.getSymbolicName(),
message, t));
@@ -73,27 +76,33 @@ public final class WorkbenchLogger extends Logger {
status.getMessage(), stackCode, t, children);
}
+ @Override
public void info(Throwable t, String message) {
log(new Status(IStatus.INFO, bundle.getSymbolicName(), message,
t));
}
+ @Override
public boolean isDebugEnabled() {
return false;
}
+ @Override
public boolean isErrorEnabled() {
return true;
}
+ @Override
public boolean isInfoEnabled() {
return true;
}
+ @Override
public boolean isTraceEnabled() {
return false;
}
+ @Override
public boolean isWarnEnabled() {
return true;
}
@@ -129,6 +138,7 @@ public final class WorkbenchLogger extends Logger {
this.log = log;
}
+ @Override
public void trace(Throwable t, String message) {
if (trace != null) {
trace.trace(null, message, t);
@@ -138,6 +148,7 @@ public final class WorkbenchLogger extends Logger {
}
}
+ @Override
public void warn(Throwable t, String message) {
log(new Status(IStatus.WARNING, bundle.getSymbolicName(),
message, t));
diff --git a/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/parts/DISaveableViewPart.java b/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/parts/DISaveableViewPart.java
index b9cb94eb..b3e591c0 100644
--- a/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/parts/DISaveableViewPart.java
+++ b/bundles/org.eclipse.e4.tools.compat/src/org/eclipse/e4/tools/compat/parts/DISaveableViewPart.java
@@ -51,6 +51,7 @@ public abstract class DISaveableViewPart<C> extends DIViewPart<C> implements ISa
return dirtyState;
}
+ @Override
public void init(IViewSite site) throws PartInitException {
super.init(site);

Back to the top