diff options
| author | Andrey Loskutov | 2021-06-12 11:38:18 +0000 |
|---|---|---|
| committer | Andrey Loskutov | 2021-06-12 15:12:53 +0000 |
| commit | 77c35d0a02395d7540cb3c3fd7bfeae3bcf68cac (patch) | |
| tree | 0bf3fec17169c6b2ce224c326739a28e671b48d3 | |
| parent | 69d5676e077ebfd73e50672d2a7a90461f9dc979 (diff) | |
| download | eclipse.platform.ui-77c35d0a02395d7540cb3c3fd7bfeae3bcf68cac.tar.gz eclipse.platform.ui-77c35d0a02395d7540cb3c3fd7bfeae3bcf68cac.tar.xz eclipse.platform.ui-77c35d0a02395d7540cb3c3fd7bfeae3bcf68cac.zip | |
Bug 574158 - ResourceFilterGroup leaks FontsY20210615-0910Y20210615-0900Y20210614-0420I20210615-1800I20210614-1800I20210613-1800I20210612-1800
Dispose the bold font on group disposal.
Change-Id: I5491c6f7cebb430fb21a94c2c1ed34f551a43531
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/181863
Tested-by: Platform Bot <platform-bot@eclipse.org>
| -rw-r--r-- | bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ResourceFilterGroup.java | 29 |
1 files changed, 16 insertions, 13 deletions
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ResourceFilterGroup.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ResourceFilterGroup.java index bc459fe30ad..a32b1cc86c4 100644 --- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ResourceFilterGroup.java +++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ResourceFilterGroup.java @@ -132,12 +132,12 @@ import org.eclipse.ui.internal.ide.misc.StringFileInfoMatcher; */ public class ResourceFilterGroup { - private Button addButton = null; - private Button addGroupButton = null; - private Button removeButton = null; - private Button upButton = null; - private Button downButton = null; - private Button editButton = null; + private Button addButton; + private Button addGroupButton; + private Button removeButton; + private Button upButton; + private Button downButton; + private Button editButton; private TreeViewer filterView; private TreeContentProvider filterViewContentProvider; @@ -146,13 +146,13 @@ public class ResourceFilterGroup { private LabelProvider labelProvider; private Font boldFont; private Font plainFont; - private Image fileIcon = null; - private Image folderIcon = null; - private Image fileFolderIcon = null; - private Image includeIcon = null; - private Image excludeIcon = null; - private Image inheritableIcon = null; - private boolean tableViewCellEditorAdequatlyUsable = false; + private Image fileIcon; + private Image folderIcon; + private Image fileFolderIcon; + private Image includeIcon; + private Image excludeIcon; + private Image inheritableIcon; + private boolean tableViewCellEditorAdequatlyUsable; private Shell shell; private IContainer nonExistantResource = getNonExistantResource(); private IContainer resource = nonExistantResource; @@ -1215,6 +1215,9 @@ public class ResourceFilterGroup { */ public void dispose() { disposeIcons(); + if (boldFont != null) { + boldFont.dispose(); + } } private void disposeIcons() { |