diff options
| author | Lars Vogel | 2020-06-05 16:23:34 +0000 |
|---|---|---|
| committer | Lars Vogel | 2020-06-09 20:59:12 +0000 |
| commit | e425860e08de4c8fa630f1fa1d3fea2c3902c9be (patch) | |
| tree | fbef97031999ada54b549deed261627d8c4b730e /org.eclipse.search/search/org/eclipse/search | |
| parent | 0b1d19dc35efaae8fb304ca256ee291281c321c0 (diff) | |
| download | eclipse.platform.text-e425860e08de4c8fa630f1fa1d3fea2c3902c9be.tar.gz eclipse.platform.text-e425860e08de4c8fa630f1fa1d3fea2c3902c9be.tar.xz eclipse.platform.text-e425860e08de4c8fa630f1fa1d3fea2c3902c9be.zip | |
Bug 564063 - Using ArrayContentProvider.getInstance() instead of newI20200612-0400I20200611-1800I20200610-1800I20200609-1800
instance
ArrayContentProvider does not hold any data, hence it can be shared
across instances.
Change-Id: I2defc10db7bdb8f3a2083e59f335743915d92f88
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Diffstat (limited to 'org.eclipse.search/search/org/eclipse/search')
3 files changed, 4 insertions, 3 deletions
diff --git a/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchDialog.java b/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchDialog.java index 4e388408d78..a9bccded9f1 100644 --- a/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchDialog.java +++ b/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchDialog.java @@ -333,7 +333,8 @@ public class SearchDialog extends ExtendedDialogWindow implements ISearchPageCon String message= SearchMessages.SearchPageSelectionDialog_message; - ListSelectionDialog dialog= new ListSelectionDialog(getShell(), input, new ArrayContentProvider(), labelProvider, message) { + ListSelectionDialog dialog = new ListSelectionDialog(getShell(), input, ArrayContentProvider.getInstance(), + labelProvider, message) { Button fLastUsedPageButton; @Override diff --git a/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchResultViewer.java b/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchResultViewer.java index 490996747ec..6d8c7960efd 100644 --- a/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchResultViewer.java +++ b/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchResultViewer.java @@ -114,7 +114,7 @@ public class SearchResultViewer extends TableViewer { fPotentialMatchFgColor= new Color(SearchPlugin.getActiveWorkbenchShell().getDisplay(), SearchPreferencePage.getPotentialMatchForegroundColor()); setUseHashlookup(true); - setContentProvider(new ArrayContentProvider()); + setContentProvider(ArrayContentProvider.getInstance()); ILabelProvider labelProvider= new SearchResultLabelProvider(new FileLabelProvider(FileLabelProvider.SHOW_LABEL)); setLabelProvider(labelProvider); diff --git a/org.eclipse.search/search/org/eclipse/search/internal/ui/ShowSearchesAction.java b/org.eclipse.search/search/org/eclipse/search/internal/ui/ShowSearchesAction.java index 9343be8a449..16889b7bc88 100644 --- a/org.eclipse.search/search/org/eclipse/search/internal/ui/ShowSearchesAction.java +++ b/org.eclipse.search/search/org/eclipse/search/internal/ui/ShowSearchesAction.java @@ -126,7 +126,7 @@ class ShowSearchesAction extends Action { ListDialog dlg= new ListDialog(SearchPlugin.getActiveWorkbenchShell()); dlg.setInput(input); dlg.setTitle(title); - dlg.setContentProvider(new ArrayContentProvider()); + dlg.setContentProvider(ArrayContentProvider.getInstance()); dlg.setLabelProvider(labelProvider); dlg.setMessage(message); if (selectedAction != null) { |