Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/bundles/org.eclipse.swt/Eclipse SWT PI
AgeCommit message (Collapse)AuthorFilesLines
2017-07-24Bug 455854: Text field with SWT.SEARCH style ignores setBackgroundStefan Winkler6-2/+53
Implemented custom SWTSearchFieldCell to handle non-default background color. Change-Id: I80db1fa0c42ca3ad194e8416ef1793aa6328f992 Signed-off-by: Stefan Winkler <stefan@winklerweb.net>
2017-07-18v4807Arun Thondapu1-1/+1
2017-07-17Bug 494565: [GTK] Snippet243 doesn't work because Text#insert(String)I20170717-2000Eric Williams4-0/+37
modifies topIndex Methods that insert or select text should not modify the topIndex of the viewer. To avoid this issue we calculate the visible area, positions of the topIndex, and the insertion/selection points. If the insertion/selection points are outside the visible area, then scroll to them. Otherwise do nothing, which preserves the topIndex. Tested on GTK3.22, 3.20, 3.18, 3.16, 3.14, 3.10, and 2.24. No additional AllNonBrowser JUnit test failures occur. Change-Id: Ib020473a5a31d535fb0b1b84f8b13e087fa16c62 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-10Bug 518276 Code documentation - OS.java gtk typesLeo Ufimtsev1-1/+1
Fixing minor error in documentation. Change-Id: Id6ba0bab427f842193e6d90d29cbd491f6792487 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-06Bug 519124 – Add SWT variable to print versions of underlying librariesLeo Ufimtsev1-1/+9
Adding code to print gtk/webkit versions if SWT_LIB_VERSIONS is specified. This is helpful for bug report investigations. Note, SWT_LIB_ prefix is for easier grep-ing of console output in the situation if there is a lot of console output. Console output is like: SWT_LIB_Gtk:3.22.15 SWT_LIB_WebkitGtk:2.16.0 (Version >=2.5 is Webkit2) Change-Id: I753e006d8f0464ca51035400327c43550a3f3c31 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-05Bug 419757: HTML5 database doesn't work for embedded webkit browserLakshmi Shanmugam1-1/+3
under Mac OSX Implement WebUIDelegate method - webView:frame:exceededDatabaseQuotaForSecurityOrigin:database: and increase the quota as desired when that method is called Change-Id: Icf8fa3682134ae2d4796ba1f07d0dcdf5ac42b35 Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
2017-07-01v4806Arun Thondapu1-1/+1
2017-06-30Bug 519056 - Change *DragSourceEffect to do cairo drawing onlyAlexander Kurtakov5-39/+34
Change-Id: I25faed14503508665cabe948b449ccdec7929c3c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-30Bug 518532 - Drop GDK drawingAlexander Kurtakov9-284/+0
Now that cairo is enforced remove non-cairo drawing from Composite background drawing. Change-Id: Iea94e6254da215edd59befcbee241bc02835c198 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-30Bug 518532 - Drop GDK drawingAlexander Kurtakov5-227/+0
Cairo drawing is mandatory now so remove non-cairo drawing from TextLayout. Change-Id: Ie1f182fc24d227a7dc04971cca1b3c8877660921 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-30Bug 518532 - Drop GDK drawingAlexander Kurtakov5-376/+0
Now that cairo is enforced remove the non-cairo drawing in GC. Change-Id: Ie54a318c7b2f8dbb297b6f6a46fd710e88eead3e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-30Bug 519026 - Make Canvas scroll use only cairo drawing Alexander Kurtakov5-33/+0
Cairo drawing was used only on GTK3 but it works without modifications on GTK 2 too. Unused bindings removed. Change-Id: Ic41799460d360ebca4bf2c3e95d1ccf95718b0bb Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-30Bug 518532 - Drop GDK drawingAlexander Kurtakov1-10/+0
Unconditional Cairo drawing in GC and remove the USE_CAIRO variable from OS - it doesn't serve us anymore. Change-Id: I388d90e01e8f0fc505ca0765a4c99e11dfd80ce3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-30Bug 518532 - Drop GDK drawingAlexander Kurtakov1-1/+0
Unconditional Image and ImageList Cairo drawing. Change-Id: Ia4d385d414f5aa6edba7ace16f95b35f28ec8552 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-30v4805Arun Thondapu1-1/+1
2017-06-29Bug 518532 - Drop GDK drawingAlexander Kurtakov7-167/+2
Remove non-cairo drawing in various components. Change-Id: I8ffb3b3759ffb638c0056c5bba710922d3841516 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-29Bug 477950: [GTK3] Port SWT colors from using GdkColor to GdkRGBA soEric Williams6-0/+36
alpha is not lost Fix some cases where GdkColor/Color.handle was being invoked on GTK3. Change-Id: I356028b52f029415ebe8ade4821471cc4e567cc6 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-06-29Bug 518532 - Drop GDK drawingAlexander Kurtakov1-6/+1
Remove INIT_CAIRO. Cairo is mandatory now. Change-Id: I1a5cd1ea736cb2393d8fc0c7a3be1d9c6da169ba Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-29v4804Arun Thondapu1-1/+1
2017-06-28Bug 514719: [Browser][Webkit2] port Browser.getText() to webkit2I20170628-2000Leo Ufimtsev4-0/+57
Webkit2 implementation of getText(). Implementation is similar to evaluate(), in that it converts async call to sync by waiting for async callback. It piggybacks on evaluate's async-callback framework. As both use the same framework, I abstracted the framework from being specific to 'evaluate' to a generic 'asyncToSync'. Test: - Checkout this patch - Cherry pick jUnit patch: (if not merged yet). https://git.eclipse.org/r/#/c/96984/ - Run Test_org_eclipse_swt_browser_Browser - All newly added getText() jUnits pass on Webkit2. Gtk3.22, Webkit2.16.1 Change-Id: I0a1d4e94b3a78abba4be9acb5a3f43311d023059 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=514719 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-06-28v4803Arun Thondapu1-1/+1
2017-06-27Bug 518855 - Remove workarounds for Cairo older than 1.8.0I20170627-2000Alexander Kurtakov4-29/+3
Change-Id: I63655797878979b0f1452e2c288079b5c15c6d3e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-27Bug 477950: [GTK3] Port SWT colors from using GdkColor to GdkRGBA soEric Williams7-2/+296
alpha is not lost This patch overhauls the SWT color system to use only GdkRGBA on GTK3 and only GdkColor on GTK2. This allows GTK3 to have transparency support without breaking backwards compatibility for GTK2. All GTK3 color functions should use GdkRGBA. Assert statements have been placed in functions that should be using only GTK3/GTK2. This should help identify bugs more quickly. NOTE: -GdkColor Java objects (i.e. GdkColor.java) should not be initialized on GTK3, as GdkColor.java contains a call to GdkColor_sizeof(). -GdkRGBA Java objects (i.e. GdkRGBA.java) CANNOT be initialized on GTK2, as GdkColor.java contains a call to GdkRGBA_sizeof(), which does not exist on GTK2. For both of the reasons above, GdkColor objects are only created on GTK2 and GdkRGBA objects are only created on GTK3. GTK3.0 - 3.16 uses GtkStyleContext machinery. GTK3.16+ uses GTK CSS for styling. Both are compatible with GdkRGBA colors. Tested on all versions of GTK3, and GTK2.24. No additional AllNonBrowser JUnit tests fail. Following this patch I will submit JUnit tests that test with alpha enabled. Change-Id: Ieb2dc3ab0758d4788600954095503463bcc59031 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-06-26Bug 506030 – [GTK] clean up dynamic function callsLeo Ufimtsev1-56/+112
Native methods are parsed by SWT tools. They should not contain user comments. Moving note about function being deprecated into javadoc of non-native equivalent. Change-Id: I1bfe0c920a67678e097745f692de437d81cf34d1 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-06-23v4802Arun Thondapu1-1/+1
2017-06-22Bug 516805: Change MACOSX_DEPLOYMENT_TARGET from 10.7 to 10.10Lakshmi Shanmugam1-1/+1
Change-Id: Ifbf8182b81fe23a8881e1e3380c7e13d71296f96
2017-06-21v4801Arun Thondapu1-1/+1
2017-06-21Bug 518545 - Remove 32 bit ppc binary fragments Alexander Kurtakov1-19/+0
Remove support from build scripts. Change-Id: I758ca6154d88c801c6dba55b7f996ae4ac1e0f4a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-20Bug 502104 - [GTK3] gtk_style_context_get_font() is deprecatedI20170620-2000Alexander Kurtakov2-7/+7
Fix 32bit compile. Change-Id: Ia27f0451f217fecae71b2471f10864e7e4008120 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-20Bug 505992 - [Gtk] Replace deprecated gtk_menu_popupIan Pun5-0/+47
Using gtk_menu_popup_at_pointer() instead of gtk_menu_popup() for >GTK3.22. Previous implementation had the popup event be put into the display stack, whereas the new implementation handles it during the GdkEvent. If no GdkEvent exists, it will create one. Tested with snippets that use setVisible() : Snippet 67, 97, 131. Some snippets such as 140 and 143 were not working prior to this fix caused by unrelated issues. Also tested on Eclipse instance with no issues. Tested using AllNonBrowserTests for GTK2 to GTK3.22 and Wayland. Change-Id: I723bdfa929df6a966b53382bd2eee4f2c1ee0576 Signed-off-by: Ian Pun <ipun@redhat.com>
2017-06-20Bug 502104 - [GTK3] gtk_style_context_get_font() is deprecatedEric Williams5-1/+44
gtk_style_context_get_font() is deprecated. Instead, we should use gtk_style_context_get() with pair value lookup. Tested on GTK 3.22, 3.20, 3.18, 3.16, 3.14, 3.10, and 2.24. No additional AllNonBrowser JUnit test failures occur. Change-Id: I4483852b0a8742cd81c2887995dd4e1202e61076 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-06-20v4800Arun Thondapu1-1/+1
2017-06-20Bug 518443: Stop building XULRunner libraries on Linux/GTKLakshmi Shanmugam7-658/+2
Remove xulrunner related code & targets from build files. Change-Id: I6274dd444f2005a07ae3e3c55dc573402546223a
2017-06-20Bug 506092 - Drop support for Mozilla XULRunnerGunnar Wagenknecht2-32/+1
Stop building the xulrunner library on mac. Remove the xulrunner related targets & code from build files. Change-Id: I8a12b1291d86385ff8ddc39a83b432866a64183c Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
2017-06-20Bug 518442: Stop building XULRunner libraries on WindowsLakshmi Shanmugam2-79/+0
Remove related code & targets in build files. Change-Id: Ib71f26569622fb496a97b15ef16daafeb616f601
2017-06-19v4760Arun Thondapu1-1/+1
2017-06-19Bug 518276 Code documentation - OS.java gtk typesLeo Ufimtsev1-0/+23
It's sometimes not straight forward as to how java types map on to gtk/C types and vice versa. I've been keeping a translation table in my notes, I figured it would be useful to have it in the code. Change-Id: Idf8ec682a605a083e67718513a55c192ff30e956 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-06-15v4759Arun Thondapu1-1/+1
2017-06-14v4758Arun Thondapu1-1/+1
2017-06-09Bug 517508 – SWT.ICON_SEARCH is ugly under LinuxLeo Ufimtsev1-2/+4
Replacing regular search icons with symbolic icons to make them look more consistent with the rest of gtk3. Note other icons (defined a few lines below) are also symbolic). See screenshot. Awaiting oxygen release. Change-Id: I13301cf4d5f15e30d1d3d36ff3c333e827062854 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-05-26v4757Arun Thondapu1-1/+1
2017-05-02v4756Arun Thondapu1-1/+1
2017-05-02Bug 515610 - [GTK] SWT generates incorrect fall-through for memmove()Martin Oberhuber2-36/+72
An incorrect fall-through in generated C code for memmove() led to producing code which could memmove() to NULL pointer destination or from a NULL pointer source. Even in case this was just dead code and could never execute, it led to an unnecessary inefficiency in the default case (an extra jmp instruction to jump over the dead code). This is resolved by a better generator, which generates an earlier jump to fail: thus avoiding the undesired fall-through. Patchset 4: (Leo) - Win32's OS.java doesn't have memmove, only MoveMemory, so Win32 not affected. - Adding Cocoa's resulting os.c of this patch. (I launched a child eclipse with this patch to have newest SWT tools, then set .classpath_cocoa -> .classpath and modified OS.java for cocoa) Change-Id: I9f9153ae3f41f4aea3a9f9439e92a892224b1475 Signed-off-by: Martin Oberhuber <martin.oberhuber@windriver.com> Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-04-22v4755Arun Thondapu1-1/+1
2017-04-22Bug 515155 - Avoid memcpy@GLIBC_2.14 for old Linux compatibilityMartin Oberhuber1-0/+4
GCC by default optimizes memmove() calls to use __builtin_memmove(), which in turn uses memcpy() from the system GLIBC if source and target regions are known to not overlap. When compiling on a modern Linux host, this leads to pulling memcpy@GLIBC_2.14, which is not available on older Linux hosts. In order to be compatible with RHEL6/Centos6 level systems, we avoid the memcpy@GLIBC_2.14 symbol by -fno-builtin-memmove when compiling. This is only done for gtk2; we do not care about gtk3, since systems that have gtk3 are supposed to also have memcpy@GLIBC_2.14. Change-Id: I50fec4cbb7d662f27a28693543b2f2024a8ea375 Signed-off-by: Martin Oberhuber <martin.oberhuber@windriver.com>
2017-04-21v4754Arun Thondapu1-1/+1
2017-04-21Bug 514509: [Gtk] Organise swt gtk developer scripts and add buildLeo Ufimtsev1-1/+1
scripts Adding wrapper script (rebuild_swt_natives_wrapper.sh). You can put this into your path (and name it like 'swtb' and it will make a local copy of rebuild_swt_natives.sh and run it. This way you can build swt even when you checkout an old version of SWT. See inside script for details. Technical notes: - Removing common_func dependency to make rebuild_swt_natives.sh more independent, (i.e, it can run from any directory now and find it's way). - The wrapper automatically updates the local copy if rebuild_swt_natives.sh in the repo is newer. - Made various improvements in rebuild_swt_natives, to allow it to function from another directory and included support for whitespaces in path. - Small bugfix in build.sh, output-dir print should not have whitespace at beginning. Change-Id: I97a23665c560999cb3da78383f3f8793bcd88def Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=514509 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-04-18Bug 515035 - [Wayland] DnD on text causes null pointer exceptionIan Pun1-0/+1
Fixed issue that causes a null pointer exception called on GTKText (SWT Text) widget. Reasoning behind the changes is that in GTK3.14 there was a change to how GTK handles DnD automatically for GTKText, causing drag detection from SWT to fight over GTK. In the case that GTK were to win the DnD, SWT was not signaled about that event, thus causing a null pointer when the target item is copied/moved as the target item was never instantiated. From my investigation, the Text field was broken way before my patch, and seem to have been caused by GTK3.14 unnoticed. Change-Id: I23d102d49c97f9c8b138d355cd01ee49f3cfc19a Signed-off-by: Ian Pun <ipun@redhat.com>
2017-04-12v4753Arun Thondapu1-1/+1
2017-04-12Bug 514509 [Gtk] Organise swt gtk developer scripts and add buildLeo Ufimtsev1-0/+10
scripts Script that performs a series of everyday tasks that an SWT developer goes through. It's well guarded to avoid problems. See description for details. Also slight modification to build.sh to make swt script platform-independent. [Patch set 4] - Fix situation where script continued even thou build failed [Patch set 5] - Fixed error check. (Success = 0, Failure != 0). Previously I checked via == -1, which is not true for all failures. [Patch set 6] - Ensuring I only use tabs for spacing instead of mix of spaces and tabs Change-Id: Ib1a3c0131107a9095bf7b0d28bdb27baef25fcdf Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>

Back to the top