Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
11 daysv4930r4genie.releng1-1/+1
12 daysBug 537896: [HiDPI][GTK] SWT to receive/handle DPI change notification from OSEric Williams5-0/+28
Connect the first Shell for a given Display to the "notify::scale-factor" signal, in order to detect changes in DPI from GTK. Calculate whether the DPI has changed, and notify listeners to the SWT.ZoomChanged event. Tested on GTK3.24, Fedora 30, X11 and Wayland on Snippet373. No AllNonBrowser JUnit tests fail. Change-Id: I73623667386f447e2071c1beac46e3213fb2bda3 Signed-off-by: Eric Williams <>
2019-09-25Bug 551438 - Fix files that have ended up with CRLF in the gitEd Merks1-33/+33
repository Change-Id: I0b73a52d66fc55656971ed0e78bd436d3e0bdecf Signed-off-by: Ed Merks <>
2019-09-20Bug 547373 - Progress view hides contents when pop-up menu is openedPaul Pazderski1-0/+4
The commit message is from the reported bug but the problem is a bit wider. SWT can not process deferred layout requests if events are processed in an external (modal) event loop. Examples for this are: any dialog like ColorDialog or FileDialog, DoDragDrop, TrackPopupMenu or any system provided menu and even window move and resize operations. The fix is to not defer layouts while an external event loop is running. Change-Id: I91b594d8f5a8a1b2575e13b4a1fa07890e275a3c Signed-off-by: Paul Pazderski <>
2019-09-11Bug 299550: [GTK] Make "Print Selection" workEric Williams4-0/+49
Implement selection printing on GTK. Note that the selection option is always available, even if no text is selected. In this case, a blank page will be printed. Tested on GTK3.24 with X11. Printing in the IDE works for all supported cases as expected. Change-Id: I540c0fe7ff5d5d5517ee1dc249c91bf9b83d4a1e Signed-off-by: Eric Williams <>
2019-08-19Bug 541427: [GTK3][X11] Tree with no items and the size of the header is blankEric Williams5-0/+27
A change in the GTK3.20 drawing model means that Trees without any items will have blank headers (not drawn). The fix is to ensure that a window-system native window is created for the Tree. Only X11 is affected by this bug, Trees on Wayland behave normally. Tested on GTK3.24 on X11 and Wayland, using the snippet attached and a child Eclipse. No AllNonBrowser JUnit tests fail. Change-Id: I5f8528b43a5ed41d652c663637673385d5eed945 Signed-off-by: Eric Williams <>
2019-08-16Bug 546248: [GTK3] Composite receives to much repaint eventsEric Williams1-0/+13
As of GTK3.16, GTK will send extra draw events to SwtFixed instances containing overlay scrollbars. This happens when the mouse leaves an SwtFixed instance that has overlay scrollbars attached to it. The fix is to check the dirty region in need of a redraw, and only sent an SWT.Paint event if the actual SwtFixed instance is in need of a redraw. Tested on GTK3.24 on X11 and Wayland. No AllNonBrowser JUnit tests fail. Change-Id: I958b4c16020a14f6f24e6e3d1ca67aba2ebec329 Signed-off-by: Eric Williams <>
2019-08-15Bug 549661 - [Win32][DND] FileTransfer can not drop on Portable DevicePaul Pazderski1-4/+9
First problem: dropping on Portable Device does not like the fake PIDLs which were used before. Second problem: dropping on Portable Device query for the data after the drag and drop operation is finished. Change-Id: Ic5f17e12c070759fb957d5010cd8cec5165fc8ff Signed-off-by: Paul Pazderski <>
2019-08-12Bug 549913 - [win32][extract method] Extract "readRegistryDword" methodNiraj Modi1-0/+17
from Display to OS Change-Id: I2c0a08dcb8aef2e34ad43ffee618369f182654ed Signed-off-by: Niraj Modi <>
2019-08-08Bug 549733: [GTK] [API] Query the current system setting for dark modeEric Williams4-13/+36
Adjust the original patch such that it works with both GTK_THEME and the system GTK theme. Change-Id: I9e0db81274123ea054539c343a58a1d9fe221740 Signed-off-by: Eric Williams <>
2019-07-22Bug 507020: [WAYLAND] [HiDPI] Some icons scaled incorrectEric Williams1-0/+15
Using gdk_get_default_root_window() isn't reliable enough to give us an accurate scale factor. Instead, we can check the scale factor of the Cairo surface provided in gtk_draw(). This information will let us know whether GTK has already scaled the Widget/Cairo surface, meaning SWT doesn't have to manually scale it again. This change only applies to GNOME. Tested on X11 and Wayland on GTK3.24. In both instances, no more double scaling is observed. Change-Id: I9271576e66af857962384264eb5645235aa88feb Signed-off-by: Eric Williams <>
2019-07-16Bug 549117: [GTK3.24] Compare editor button has no imageEric Williams5-1/+4
Revert some internal GTK theme changes to preserve compare editor arrow button. Only affects GTK3.24.5 and onward. This commit adds a "swt_theming_fixes_gtk_324" file, for GTK CSS fixes that only affect GTK3.24 and greater. No adverse effects are observed in the IDE. Change-Id: I4fc480ff082cd81c3f3f0e2c5ba43c54a1b0a384 Signed-off-by: Eric Williams <>
2019-07-08Bug 548982 - [GTK] Optimize bulk inserting items to TreeAlexandr Miloslavskiy4-0/+26
Change-Id: I1b6c19d043cc42ac244926129eef2ba71ef174ad Signed-off-by: Alexandr Miloslavskiy <>
2019-07-01Bug 548666 - [Win32] Remove unused COM constants, structures, functionsNikita Nemkin29-1360/+108
Change-Id: Id76974244ef0892ba286d6ac9c35f7d61844138d Signed-off-by: Nikita Nemkin <>
2019-07-01Bug 548458 - [Win32] Move VtblCalls from OS to COMNikita Nemkin44-1486/+444
Change-Id: Ice1d5eec2af98f38244d2baf922c30c6c5dedfbd Signed-off-by: Nikita Nemkin <>
2019-06-30Bug 547634 - [win32] Add CFSTR_SHELLIDLIST transfer type to FileTransferPaul Pazderski14-22/+292
to support drop on taskbar CFSTR_SHELLIDLIST transfer type is only added as drag source not as drop target. Like the existing CF_HDROP transfer type implementation the new transfer type allow dragging non existing file paths. Change-Id: I02c4f64081ec2b55073e1878f99b8e52eeabdd01 Signed-off-by: Paul Pazderski <>
2019-06-26Bug 548628: Wayland as Input method is accessible in X11Eric Williams4-34/+0
Remove input method menu all together as GTK no longer supports it. Use the desktop environment input selection instead. Change-Id: I8519e7eb7111060f2c56f1da335a9115c7fd8983 Signed-off-by: Eric Williams <>
2019-06-26Bug 548457 - [Win32] Replace direct vtable calls with interface wrappersNikita Nemkin23-106/+555
Also, move all GUID constants to COM. Change-Id: I57cc0e1cfdadcaac459323010aec4efbc726417b Signed-off-by: Nikita Nemkin <>
2019-06-25Bug 548491 - [regression][mac] Cheese in java editorTill Brychcy4-1/+10
Change-Id: I32415326801837c10bc4fb6d7e18d832c20b3645
2019-06-24Bug 548384 - [Win32] Simplify directory handling in TaskBarNikita Nemkin4-70/+0
Use Java IO instead of IFileOperation to create and clear the directory that stores JumpList icons. Change-Id: I784f4272ccfeafe845d66a794719e3f2d922a940 Signed-off-by: Nikita Nemkin <>
2019-06-21Bug 443089: Save Dialog doesn't handle files with multipart extensionsLakshmi Shanmugam4-0/+18
Reverted code changes made for Bug 347430. Don't use setAllowedFileType to set the filter extensions to the NSSavePanel as it doesn't support multi-part extensions such as tar.gz. Used delegate method panel:userEnteredFilename:confirmed: to handle the overwrite case when name field has filename without extension. Cocoa APIs in general don't support multi-part extensions. However, SWT FileDialog needs to support them. Hence, add the required extensions manually on save and selection change. Change-Id: I221f75476f1c1d263f64da239845c325b436bfca
2019-06-20Bug 548286: [GTK] Clean up system color CSS parsingAlexandr Miloslavskiy1-0/+1
Remove GTK CSS parsing in favour of GtkStyleContext color extraction. Many thanks to Alexandr Miloslavskiy for his help with this effort! Change-Id: Id8dc44ec4116386c9b1bd2021c681c9a3923a35b Signed-off-by: Eric Williams <> Signed-off-by: Alexandr Miloslavskiy <>
2019-06-18Bug 395296: [GTK] Incorrect ToolBar width on LinuxXi Yan4-0/+25
Set the "homogeneous" property to false by default for all ToolItems. This prevents a large ToolItem from dictating the size of all other ToolItems belonging to the same ToolBar. For some reason, this property is enabled by default in GTK3. Tested using a child Eclipse, the Git rebase interactive view, and the snippets attached to this Gerrit. No AllNonBrowser JUnit failures are observed. Environment: Fedora 30, GTK3.24. Change-Id: I437309217fb5e706bce04e82a63a227e1a2baef0 Signed-off-by: Eric Williams <>
2019-06-18Bug 548378: [Mac]Replace deprecated method used FileDialogLakshmi Shanmugam4-9/+36
Replace panel:shouldShowFilename: which has been deprecated in Mac 10.6. with NSOpenSavePanelDelegate.panel:shouldEnableURL: Change-Id: If2eba8a2b1bba959cda18a7ac56be5405d1ddfca
2019-06-18Bug 548277 - [Win32] Remove 32-bit code remnantsNikita Nemkin6-505/+25
Small structures passed by value use different convention between x86 and x64 ABI on Windows. We only need to conform to 64-bit ABI now. In particular, IAccessible required custom callback wrappers to convert by-value VARIANT structures to pointers. Under x64 ABI by-value VARIANTS actually are passed as pointers. Change-Id: I12efeddc3298f92367fd2739fb11f6fa572b31dd Signed-off-by: Nikita Nemkin <>
2019-06-18Bug 548277 - [Win32] Remove 32-bit code commentsNikita Nemkin145-9939/+4403
This change is completely automated. The script is attached to the issue. Change-Id: Iad1ce2378a76f0474800f3ef907b9d9fa657bfbe Signed-off-by: Nikita Nemkin <>
2019-06-18Use String.contains instead of indexOfLars Vogel1-1/+1
Change-Id: Ib5e9ae7e066f809a0223299b5708462fcf6b66f9 Signed-off-by: Lars Vogel <>
2019-06-14Bug 547304 - [cleanup] Fix wrong space/tab indentationPaul Pazderski21-280/+280
This change fixes space or mixed tab/space indentations in all Java files. This also includes two or three space indentations and even fix most stray single spaces in indentations. The change includes only whitespace formatting and no code changes. Change-Id: Ib7b260691acee06845cc580dd8cb859de0da8bf1
2019-06-14Bug 547192 - [Cocoa] Replace deprecated Carbon functions (Part 1)Nikita Nemkin13-7/+222
Deprecated function | Modern equivalent ------------------------------------------------------------------- Gestalt | NSProcessInfo.operatingSystemVersion GetDblTime | NSEvent.doubleClickInterval GetCurrentEventButtonState | NSEvent.pressedMouseButtons ATSFontActivateFromFileReference | CTFontManagerRegisterFontsForURL Change-Id: I7ba3e3da6c73117bc7800d022b8eba9fb3cc907a Signed-off-by: Nikita Nemkin <>
2019-06-12Bug 293230 - [Win32] Support SWT.ICON_SEARCH/CANCEL Text stylesNikita Nemkin7-0/+54
This reverts commit a551d9cf6c769c4e64f0c41f5cba6c7e8ef9d193. Change-Id: I92edf6a5dfd46b09547b2f97eaf5102c2663cd9c
2019-06-12Revert "Bug 293230 - [Win32] Support SWT.ICON_SEARCH/CANCEL Text styles"Niraj Modi7-54/+0
- Reverting the change to fix the author. This reverts commit bf374552cac5b50f6b86727909611fb3d0aafce9. Change-Id: Ie132e0fe1356d676ea8c7c46bd1cdbaf44292811
2019-06-12Revert "Revert "Bug 293230 - [Win32] Support SWT.ICON_SEARCH/CANCEL Text ↵Niraj Modi7-0/+54
styles"" This reverts commit 6434e727aafcb8d724a9bab0c65f18e15e6b596b. Change-Id: I5381fb97b8f8917480a63008e7b4aa8192f6f454
2019-06-12Revert "Bug 293230 - [Win32] Support SWT.ICON_SEARCH/CANCEL Text styles"Niraj Modi7-54/+0
This reverts commit c4446b5e7d895c1bbe3231a1b6440910c7c14932. Change-Id: Id549fa6d76f0a785c97b5448f554d172067dda8b
2019-06-11Bug 547557: [GTK] Shell.print(GC) not implementedEric Williams5-0/+28
Implement Shell.print(GC) using a GdkPixbuf obtained from the root GdkWindow. This only works on GTK3 + X11, Wayland and GTK4 will likely need a different approach which will take more time to investigate. Tested on GTK3.24 on X11, both inside a flatpak and not. Output behaves as expected, no AllNonBrowser JUnit tests fail. Change-Id: Ibf39d60f2e97c1ecf8e45c9cdda6da3e9d7e160e Signed-off-by: Eric Williams <>

Back to the top