diff options
| author | Eric Williams | 2015-12-03 15:41:45 +0000 |
|---|---|---|
| committer | Alexander Kurtakov | 2015-12-04 06:23:39 +0000 |
| commit | ed379c8003d9bfaba97b8e0f47ce7d98047e8a17 (patch) | |
| tree | e8df02fbc7c1ca53ff3b7f0a2cbeb639a9781abd /bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java | |
| parent | 0485eee07ae0ceae38088f2d3e0d37caf0ad1104 (diff) | |
| download | eclipse.platform.swt-ed379c8003d9bfaba97b8e0f47ce7d98047e8a17.tar.gz eclipse.platform.swt-ed379c8003d9bfaba97b8e0f47ce7d98047e8a17.tar.xz eclipse.platform.swt-ed379c8003d9bfaba97b8e0f47ce7d98047e8a17.zip | |
Bug 483115: Scrollbar size wrongly reported
Previously, the macro GTK_SCROLLED_WINDOW_SCROLLBAR_SPACING()
responsible for returning scrollbar spacing was returning a value of 3.
This should be zero on the default GNOME theme.
According to the GTK team we should be accessing the "scrollbar-padding"
property differently. This style property belonging to GtkScrolledWindow
should now be accessed with a call to gtk_widget_get_style(). Using
this method instead will return the correct value. This eliminates some
extra padding that was being added to the bottom of the text editor in
Eclipse.
Tested on GTK3.18, GTK3.16, GTK3.14, and GTK2.24. AllNonBrowser JUnit
tests pass on GTK3 and GTK2.
Change-Id: I21c321688fa91af191e005f1aaf325a2cbae5cea
Signed-off-by: Eric Williams <ericwill@redhat.com>
Diffstat (limited to 'bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java')
| -rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java b/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java index a1795dd37e..b47c738f22 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java +++ b/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java @@ -672,6 +672,7 @@ public class OS extends C { public static final byte[] margin_bottom = ascii("margin-bottom"); public static final byte[] margin_top = ascii("margin-top"); public static final byte[] GTK_PRINT_SETTINGS_OUTPUT_URI = ascii("output-uri"); + public static final byte[] scrollbar_spacing = ascii("scrollbar-spacing"); /* * Needed to tell GTK 3 to prefer a dark or light theme in the UI. @@ -833,8 +834,6 @@ public static final native void G_OBJECT_CLASS_SET_CONSTRUCTOR(long /*int*/ obje public static final native int GTK_RANGE_SLIDER_START(long /*int*/ widget); /** @param widget cast=(GtkRange *) */ public static final native int GTK_RANGE_SLIDER_END(long /*int*/ widget); -/** @param widget cast=(GtkScrolledWindow *) */ -public static final native int GTK_SCROLLED_WINDOW_SCROLLBAR_SPACING(long /*int*/ widget); /** * @param acce_label cast=(GtkAccelLabel *) * @param string cast=(gchar *) |