Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIan Pun2017-04-11 19:03:51 +0000
committerAlexander Kurtakov2017-04-18 07:20:10 +0000
commit70514a80262b38f5ef57c53d18cc3f840bdd8c9d (patch)
treec984e893f62b92f007e33a1734d4679dfbf1bd7c /bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
parent1efd0242e92f0b837bc0bfc5bcc80085d15d9d8d (diff)
downloadeclipse.platform.swt-70514a80262b38f5ef57c53d18cc3f840bdd8c9d.tar.gz
eclipse.platform.swt-70514a80262b38f5ef57c53d18cc3f840bdd8c9d.tar.xz
eclipse.platform.swt-70514a80262b38f5ef57c53d18cc3f840bdd8c9d.zip
Bug 515035 - [Wayland] DnD on text causes null pointer exception
Fixed issue that causes a null pointer exception called on GTKText (SWT Text) widget. Reasoning behind the changes is that in GTK3.14 there was a change to how GTK handles DnD automatically for GTKText, causing drag detection from SWT to fight over GTK. In the case that GTK were to win the DnD, SWT was not signaled about that event, thus causing a null pointer when the target item is copied/moved as the target item was never instantiated. From my investigation, the Text field was broken way before my patch, and seem to have been caused by GTK3.14 unnoticed. Change-Id: I23d102d49c97f9c8b138d355cd01ee49f3cfc19a Signed-off-by: Ian Pun <ipun@redhat.com>
Diffstat (limited to 'bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java')
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java1
1 files changed, 1 insertions, 0 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java b/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
index 5c1836764f..7b3e69eb2e 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
@@ -553,6 +553,7 @@ public class OS extends C {
public static final byte[] delete_range = ascii("delete-range");
public static final byte[] delete_text = ascii("delete-text");
public static final byte[] direction_changed = ascii("direction-changed");
+ public static final byte[] drag_begin = ascii("drag_begin");
public static final byte[] drag_data_delete = ascii("drag_data_delete");
public static final byte[] drag_data_get = ascii("drag_data_get");
public static final byte[] drag_data_received = ascii("drag_data_received");

Back to the top