Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeo Ufimtsev2016-11-09 17:51:04 +0000
committerAlexander Kurtakov2016-11-10 07:00:22 +0000
commit40cb272af51e68257747a70536bec80228362b68 (patch)
treef7fcb2671fe780d4ebdd0a3d6ea8bbccd732a1c5 /bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
parent04862c5f2af9148ae0d045ae927e8d64de4bd5b4 (diff)
downloadeclipse.platform.swt-40cb272af51e68257747a70536bec80228362b68.tar.gz
eclipse.platform.swt-40cb272af51e68257747a70536bec80228362b68.tar.xz
eclipse.platform.swt-40cb272af51e68257747a70536bec80228362b68.zip
Bug 507235: Clean up of Converter.java
- Remove redundant codePage parameter from Converter.java. It is not being used by the function body. (It was last used 15 years ago in: 5fbe5d6518706b4f002ddbbebf7e1f63d1877af8) - Remove unused defaultCodePage() method from codebase. - Move wcsToMbcs and mbcsToWcs for single characters from Display.java into Converter.java class, next to their siblings. Display.java should not be responsible for platform level type conversion. - Document functions to explain their necessity. Change-Id: Ie19b76259247d4d200c679852b8165e465f4e53b Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=507235 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com> Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Diffstat (limited to 'bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java')
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java b/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
index ea1fde8c05..a6086e8625 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
@@ -16585,7 +16585,7 @@ public static final String getThemeName() {
byte[] themeNameBytes = getThemeNameBytes();
String themeName = "unknown";
if (themeNameBytes != null && themeNameBytes.length > 0) {
- themeName = new String (Converter.mbcsToWcs (null, themeNameBytes));
+ themeName = new String (Converter.mbcsToWcs (themeNameBytes));
}
return themeName;
}

Back to the top