weird double-click behavior for workspace plug-insv20070206-0011

1 files changed, 9 insertions, 8 deletions

diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/plugins/PluginsView.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/plugins/PluginsView.java
index f108c2d1d1..179d743e80 100644
--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/plugins/PluginsView.java
+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/plugins/PluginsView.java
@@ -594,14 +594,17 @@ public class PluginsView extends ViewPart implements IPluginModelListener{
 	private void handleDoubleClick() {
 		Object obj = getSelectedObject();
 		if (obj instanceof IPluginModelBase) {
-            boolean expanded = fTreeViewer.getExpandedState(obj);
-            fTreeViewer.setExpandedState(obj, !expanded);
+            boolean expanded = false;
+            // only expand target models
+            if (((IPluginModelBase)obj).getUnderlyingResource() == null) {
+            	expanded = fTreeViewer.getExpandedState(obj);
+            	fTreeViewer.setExpandedState(obj, !expanded);
+            }
             if (fTreeViewer.getExpandedState(obj) == expanded) {
                 // not expandable, open editor
                 ManifestEditor.openPluginEditor((IPluginModelBase)obj);
             }
-		}
-		if (obj instanceof FileAdapter) {
+		} else if (obj instanceof FileAdapter) {
 			FileAdapter adapter = (FileAdapter) obj;
 			if (adapter.isDirectory()) {
 				fTreeViewer.setExpandedState(
@@ -614,11 +617,9 @@ public class PluginsView extends ViewPart implements IPluginModelListener{
 				handleOpenSystemEditor(adapter);
 			else
 				handleOpenTextEditor(adapter, editorId);
-		}
-		if (obj instanceof IClassFile) {
+		} else if (obj instanceof IClassFile) {
 			fOpenClassFileAction.run();
-		}
-		if (obj instanceof IStorage) {
+		} else if (obj instanceof IStorage) {
 			handleOpenStorage((IStorage) obj);
 		}
 	}