fixes to issues flagged by find bugs

3 files changed, 8 insertions, 5 deletions

diff --git a/plugins/org.eclipse.osee.ote.client.msg/src/org/eclipse/osee/ote/client/msg/core/internal/MessageReference.java b/plugins/org.eclipse.osee.ote.client.msg/src/org/eclipse/osee/ote/client/msg/core/internal/MessageReference.java
index 5d24e99cfb3..85c7429e77f 100644
--- a/plugins/org.eclipse.osee.ote.client.msg/src/org/eclipse/osee/ote/client/msg/core/internal/MessageReference.java
+++ b/plugins/org.eclipse.osee.ote.client.msg/src/org/eclipse/osee/ote/client/msg/core/internal/MessageReference.java
@@ -51,7 +51,7 @@ public class MessageReference {
 	@Override

 	public boolean equals(Object obj) {
 		if (obj == null) {
-			throw new NullPointerException();
+			return false;
 		}

 		MessageReference otherRef = (MessageReference) obj;

 		return msgClassName.equals(otherRef.msgClassName) && type == otherRef.type && mode == otherRef.mode;

diff --git a/plugins/org.eclipse.osee.ote.ui/src/org/eclipse/osee/ote/ui/navigate/OteNavigateViewItems.java b/plugins/org.eclipse.osee.ote.ui/src/org/eclipse/osee/ote/ui/navigate/OteNavigateViewItems.java
index 39857c47352..2c9bd244d8e 100644
--- a/plugins/org.eclipse.osee.ote.ui/src/org/eclipse/osee/ote/ui/navigate/OteNavigateViewItems.java
+++ b/plugins/org.eclipse.osee.ote.ui/src/org/eclipse/osee/ote/ui/navigate/OteNavigateViewItems.java
@@ -16,6 +16,7 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.logging.Level;
+
 import org.eclipse.osee.framework.logging.OseeLog;
 import org.eclipse.osee.framework.ui.plugin.PluginUiImage;
 import org.eclipse.osee.framework.ui.plugin.xnavigate.XNavigateContributionManager;
@@ -71,11 +72,12 @@ public class OteNavigateViewItems extends XNavigateViewItems {
       for (XNavigateExtensionPointData data : oteNavigateItemExtensions) {
          if (!categoryToNavigateItem.containsKey(data.getCategory())) {
             String[] path = data.getItemPath();
-            String key = "";
+            StringBuilder keyBuilder = new StringBuilder(256);
             XNavigateItem lastItem = null;
             for (int i = 0; i < path.length; i++) {
 
-               key += path[i];
+               keyBuilder.append(path[i]);
+               String key = keyBuilder.toString();
                XNavigateItem foundItem = categoryToNavigateItem.get(key);
                if (foundItem == null) {
                   foundItem = new XNavigateItem(lastItem, path[i], PluginUiImage.FOLDER);
@@ -88,7 +90,7 @@ public class OteNavigateViewItems extends XNavigateViewItems {
                   }
                }
                lastItem = foundItem;
-               key += ".";
+               keyBuilder.append('.');
             }
          }
       }
diff --git a/plugins/org.eclipse.osee.ote.ui/src/org/eclipse/osee/ote/ui/navigate/WorkspaceSetupViewItems.java b/plugins/org.eclipse.osee.ote.ui/src/org/eclipse/osee/ote/ui/navigate/WorkspaceSetupViewItems.java
index f7978c1df17..5db330efc30 100644
--- a/plugins/org.eclipse.osee.ote.ui/src/org/eclipse/osee/ote/ui/navigate/WorkspaceSetupViewItems.java
+++ b/plugins/org.eclipse.osee.ote.ui/src/org/eclipse/osee/ote/ui/navigate/WorkspaceSetupViewItems.java
@@ -15,6 +15,7 @@ import java.net.URL;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.logging.Level;
+
 import org.eclipse.core.runtime.FileLocator;
 import org.eclipse.core.runtime.IConfigurationElement;
 import org.eclipse.core.runtime.IExtension;
@@ -85,7 +86,7 @@ public class WorkspaceSetupViewItems implements IXNavigateContainer {
       return getResource(bundleName, configName);
    }
 
-   private final class XNavigateItemRunnable extends XNavigateItem {
+   private static final class XNavigateItemRunnable extends XNavigateItem {
       private URL projectSetFile;
       private String jobName;