NEW - bug 195450: improve documentation for APIs and extension point definitions

https://bugs.eclipse.org/bugs/show_bug.cgi?id=195450

2 files changed, 8 insertions, 12 deletions

diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/data/TaskDataManager.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/data/TaskDataManager.java
index 8351c8bd4..e4e3613f4 100644
--- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/data/TaskDataManager.java
+++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/data/TaskDataManager.java
@@ -359,21 +359,17 @@ public class TaskDataManager implements ITaskDataManager {
 	}
 
 	private File getFile(String repositoryUrl, ITask task, String kind) {
-		try {
 //			String pathName = task.getConnectorKind() + "-"
 //					+ URLEncoder.encode(task.getRepositoryUrl(), ENCODING_UTF_8);
 //			String fileName = kind + "-" + URLEncoder.encode(task.getTaskId(), ENCODING_UTF_8) + EXTENSION;
-			String repositoryPath = task.getConnectorKind() + "-" + encode(repositoryUrl);
-			String fileName = encode(task.getTaskId()) + EXTENSION;
-			File path = new File(dataPath + File.separator + FOLDER_TASKS + File.separator + repositoryPath
-					+ File.separator + FOLDER_DATA);
-			return new File(path, fileName);
-		} catch (UnsupportedEncodingException e) {
-			throw new RuntimeException(e);
-		}
+		String repositoryPath = task.getConnectorKind() + "-" + encode(repositoryUrl);
+		String fileName = encode(task.getTaskId()) + EXTENSION;
+		File path = new File(dataPath + File.separator + FOLDER_TASKS + File.separator + repositoryPath
+				+ File.separator + FOLDER_DATA);
+		return new File(path, fileName);
 	}
 
-	private String encode(String text) throws UnsupportedEncodingException {
+	private static String encode(String text) {
 		StringBuffer sb = new StringBuffer(text.length());
 		char[] chars = text.toCharArray();
 		for (char c : chars) {
diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/AbstractRepositoryConnector.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/AbstractRepositoryConnector.java
index 64b9c4712..e7056f0ef 100644
--- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/AbstractRepositoryConnector.java
+++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/AbstractRepositoryConnector.java
@@ -248,12 +248,12 @@ public abstract class AbstractRepositoryConnector {
 	 * 
 	 * @since 3.0
 	 */
-	public abstract void updateRepositoryConfiguration(TaskRepository repository, IProgressMonitor monitor)
+	public abstract void updateRepositoryConfiguration(TaskRepository taskRepository, IProgressMonitor monitor)
 			throws CoreException;
 
 	/**
 	 * @since 3.0
 	 */
-	public abstract void updateTaskFromTaskData(TaskRepository repository, ITask task, TaskData taskData);
+	public abstract void updateTaskFromTaskData(TaskRepository taskRepository, ITask task, TaskData taskData);
 
 }