REOPENED - bug 166608: Asynchronous saving of the task list

https://bugs.eclipse.org/bugs/show_bug.cgi?id=166608

2 files changed, 9 insertions, 2 deletions

diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TaskListSaveManager.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TaskListSaveManager.java
index 5f64b8a49..78327ae1d 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TaskListSaveManager.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TaskListSaveManager.java
@@ -125,7 +125,7 @@ public class TaskListSaveManager implements ITaskListChangeListener, IBackground
 		}
 	}
 	
-	private void internalSaveTaskList() {
+	private synchronized void internalSaveTaskList() {
 		TaskListManager taskListManager = TasksUiPlugin.getTaskListManager();
 		taskListManager.getTaskListWriter().writeTaskList(taskListManager.getTaskList(),
 				taskListManager.getTaskListFile());
@@ -339,7 +339,6 @@ public class TaskListSaveManager implements ITaskListChangeListener, IBackground
 				}
 			}
 		}
-
 	}
 	
 }
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/TasksUiPlugin.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/TasksUiPlugin.java
index ead8c8071..0fe4679a9 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/TasksUiPlugin.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/TasksUiPlugin.java
@@ -520,6 +520,7 @@ public class TasksUiPlugin extends AbstractUIPlugin implements IStartup {
 	public void setDataDirectory(String newPath) {
 		getTaskListManager().saveTaskList(); 
 //		getTaskListSaveManager().saveTaskList(true);
+//		taskListSaveManager.saveTaskList(true, false);
 		ContextCorePlugin.getContextManager().saveActivityHistoryContext();
 		getPreferenceStore().setValue(MylarPreferenceContstants.PREF_DATA_DIR, newPath);
 		ContextCorePlugin.getDefault().getContextStore().notifyContextStoreMoved();
@@ -815,4 +816,11 @@ public class TasksUiPlugin extends AbstractUIPlugin implements IStartup {
 	public boolean isEclipse_3_3_workbench() {
 		return eclipse_3_3_workbench;
 	}
+
+	/**
+	 * Public for testing.
+	 */
+	public TaskListSaveManager getTaskListSaveManager() {
+		return taskListSaveManager;
+	}
 }