diff options
author | Sam Davis | 2012-09-24 22:47:13 +0000 |
---|---|---|
committer | Steffen Pingel | 2012-10-06 09:40:24 +0000 |
commit | d398d25d6d2342652b9637850334abef48fa39f5 (patch) | |
tree | 613b07098e0a789f503efd9b51a8822eda636ddb /org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/ExtensionPointReader.java | |
parent | 9ca41a88ac078defb074f51a737c0f94c358874b (diff) | |
download | org.eclipse.mylyn.commons-d398d25d6d2342652b9637850334abef48fa39f5.tar.gz org.eclipse.mylyn.commons-d398d25d6d2342652b9637850334abef48fa39f5.tar.xz org.eclipse.mylyn.commons-d398d25d6d2342652b9637850334abef48fa39f5.zip |
389946: ExtensionPointReader ignores priorityAttributeId value
Change-Id: I4c657e6131ca26bc9ad07e426ab40a9095ed2b23
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=389946
Diffstat (limited to 'org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/ExtensionPointReader.java')
-rw-r--r-- | org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/ExtensionPointReader.java | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/ExtensionPointReader.java b/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/ExtensionPointReader.java index 467589de..06e6c2bc 100644 --- a/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/ExtensionPointReader.java +++ b/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/ExtensionPointReader.java @@ -32,21 +32,19 @@ import org.eclipse.osgi.util.NLS; * @since 3.7 */ public class ExtensionPointReader<T> { - - private static final class PriorityComparator implements Comparator<IConfigurationElement> { - + private final class PriorityComparator implements Comparator<IConfigurationElement> { public int compare(IConfigurationElement arg0, IConfigurationElement arg1) { double p0 = 0; double p1 = 0; try { - String priorityAttribute = arg0.getAttribute(DEFAULT_ATTRIBUTE_ID_PRIORITY); + String priorityAttribute = arg0.getAttribute(getPriorityAttributeId()); if (priorityAttribute != null) { p0 = Double.parseDouble(priorityAttribute); } } catch (NumberFormatException e) { } try { - String priorityAttribute = arg1.getAttribute(DEFAULT_ATTRIBUTE_ID_PRIORITY); + String priorityAttribute = arg1.getAttribute(getPriorityAttributeId()); if (priorityAttribute != null) { p1 = Double.parseDouble(priorityAttribute); } @@ -66,7 +64,7 @@ public class ExtensionPointReader<T> { private static final String DEFAULT_ATTRIBUTE_ID_PRIORITY = "priority"; //$NON-NLS-1$ - private static final PriorityComparator PRIORITY_COMPARATOR = new PriorityComparator(); + private final PriorityComparator priorityComparator = new PriorityComparator(); private String classAttributeId; @@ -147,7 +145,7 @@ public class ExtensionPointReader<T> { IExtension[] extensions = extensionPoint.getExtensions(); for (IExtension extension : extensions) { IConfigurationElement[] elements = extension.getConfigurationElements(); - Arrays.sort(elements, PRIORITY_COMPARATOR); + Arrays.sort(elements, priorityComparator); for (IConfigurationElement element : elements) { if (element.getName().equals(elementId) && shouldRead(element)) { T item = readElement(element, result); |