Found valid Unicode URI that fails ValidUrlRule

1 files changed, 40 insertions, 0 deletions

diff --git a/jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/ValidUrlRuleTest.java b/jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/ValidUrlRuleTest.java
index 1ba760721a..839fcf021f 100644
--- a/jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/ValidUrlRuleTest.java
+++ b/jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/ValidUrlRuleTest.java
@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
 import junit.framework.Assert;
 
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 
 public class ValidUrlRuleTest extends AbstractRuleTestCase
@@ -71,6 +72,45 @@ public class ValidUrlRuleTest extends AbstractRuleTestCase
     }
     
     @Test
+    public void testInvalidJsp() throws Exception
+    {
+        _rule.setCode("405");
+        _rule.setReason("foo");
+        _request.setRequestURI("/jsp/bean1.jsp%00");
+        
+        String result = _rule.matchAndApply(_request.getRequestURI(), _request, _response);
+
+        assertEquals(405,_response.getStatus());
+        assertEquals("foo",_response.getReason());
+    }
+    
+    @Test
+    public void testInvalidShamrock() throws Exception
+    {
+        _rule.setCode("405");
+        _rule.setReason("foo");
+        _request.setRequestURI("/jsp/shamrock-%002618.jsp");
+        
+        String result = _rule.matchAndApply(_request.getRequestURI(), _request, _response);
+
+        assertEquals(405,_response.getStatus());
+        assertEquals("foo",_response.getReason());
+    }
+
+    @Ignore("Not passing (yet)")
+    @Test
+    public void testValidShamrock() throws Exception
+    {
+        _rule.setCode("405");
+        _rule.setReason("foo");
+        _request.setRequestURI("/jsp/shamrock-%00%E2%98%98.jsp");
+        
+        String result = _rule.matchAndApply(_request.getRequestURI(), _request, _response);
+
+        assertEquals(200,_response.getStatus());
+    }
+
+    @Test
     public void testCharacters() throws Exception
     {
         // space