diff options
author | Carsten Hammer | 2020-04-19 10:26:33 +0000 |
---|---|---|
committer | Fabrice Tiercelin | 2020-04-21 04:25:42 +0000 |
commit | 736d5f2083bfe9a6a7d544d445a62653182fde1c (patch) | |
tree | 83313c3c5818e1c86e56d0042cff3abe5ba28239 | |
parent | 7fffd7f05c980097e30c7e0ed2f53fdea8f4114f (diff) | |
download | eclipse.jdt.ui-736d5f2083bfe9a6a7d544d445a62653182fde1c.tar.gz eclipse.jdt.ui-736d5f2083bfe9a6a7d544d445a62653182fde1c.tar.xz eclipse.jdt.ui-736d5f2083bfe9a6a7d544d445a62653182fde1c.zip |
Bug 548309 - Manual array copy
Use System.arraycopy instead of copying array in a for loop
Change-Id: Ic8b63e55df34c85c509bf167b21082e99346da5e
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
-rw-r--r-- | org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/template/java/JavaPostfixContext.java | 38 |
1 files changed, 16 insertions, 22 deletions
diff --git a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/template/java/JavaPostfixContext.java b/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/template/java/JavaPostfixContext.java index cc500a6fa3..ee82ca8df9 100644 --- a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/template/java/JavaPostfixContext.java +++ b/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/template/java/JavaPostfixContext.java @@ -26,6 +26,19 @@ import java.util.regex.Pattern; import org.eclipse.core.runtime.NullProgressMonitor; +import org.eclipse.text.edits.MalformedTreeException; +import org.eclipse.text.edits.TextEdit; + +import org.eclipse.jface.text.BadLocationException; +import org.eclipse.jface.text.IDocument; +import org.eclipse.jface.text.Position; +import org.eclipse.jface.text.Region; +import org.eclipse.jface.text.templates.Template; +import org.eclipse.jface.text.templates.TemplateBuffer; +import org.eclipse.jface.text.templates.TemplateContextType; +import org.eclipse.jface.text.templates.TemplateException; +import org.eclipse.jface.text.templates.TemplateVariable; + import org.eclipse.jdt.core.CompletionContext; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaProject; @@ -65,32 +78,16 @@ import org.eclipse.jdt.core.dom.WildcardType; import org.eclipse.jdt.core.dom.rewrite.ASTRewrite; import org.eclipse.jdt.internal.core.manipulation.StubUtility; +import org.eclipse.jdt.internal.core.manipulation.dom.ASTResolving; import org.eclipse.jdt.internal.corext.dom.ASTNodeFactory; import org.eclipse.jdt.internal.corext.dom.ASTNodes; import org.eclipse.jdt.internal.corext.dom.IASTSharedValues; -import org.eclipse.jdt.internal.corext.template.java.JavaContext; - -import org.eclipse.jdt.internal.core.manipulation.dom.ASTResolving; - -import org.eclipse.jface.text.BadLocationException; -import org.eclipse.jface.text.IDocument; -import org.eclipse.jface.text.Position; -import org.eclipse.jface.text.Region; -import org.eclipse.jface.text.templates.Template; -import org.eclipse.jface.text.templates.TemplateBuffer; -import org.eclipse.jface.text.templates.TemplateContextType; -import org.eclipse.jface.text.templates.TemplateException; -import org.eclipse.jface.text.templates.TemplateVariable; - -import org.eclipse.text.edits.MalformedTreeException; -import org.eclipse.text.edits.TextEdit; /** * This class is an extension to the existing {@link JavaContext} and includes/provides additional * information on the current node which the code completion was invoked on. */ public class JavaPostfixContext extends JavaContext { - private static final Object CONTEXT_TYPE_ID= "postfix"; //$NON-NLS-1$ private static final String OBJECT_SIGNATURE= "java.lang.Object"; //$NON-NLS-1$ @@ -420,11 +417,8 @@ public class JavaPostfixContext extends JavaContext { int[] outOfRangeOffsets= variableOutOfRangeOffsets.get(tv); if (outOfRangeOffsets != null && outOfRangeOffsets.length > 0) { int[] offsets= tv.getOffsets(); - int[] newOffsets= new int[outOfRangeOffsets.length + offsets.length]; - System.arraycopy(offsets, 0, newOffsets, 0, offsets.length); - for (int i= 0; i < outOfRangeOffsets.length; i++) { - newOffsets[i + offsets.length]= outOfRangeOffsets[i]; - } + int[] newOffsets= Arrays.copyOf(offsets, offsets.length + outOfRangeOffsets.length); + System.arraycopy(outOfRangeOffsets, 0, newOffsets, offsets.length, outOfRangeOffsets.length); tv.setOffsets(newOffsets); } } |