Fixed Bug 428845 - eclipse compiler does not flag ambiguous method call

in some cases

Signed-off-by: Sasikanth Bharadwaj<saammana@in.ibm.com>

2 files changed, 34 insertions, 1 deletions

diff --git a/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/AmbiguousMethodTest.java b/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/AmbiguousMethodTest.java
index dac4c2021d..9595fce585 100644
--- a/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/AmbiguousMethodTest.java
+++ b/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/AmbiguousMethodTest.java
@@ -4464,4 +4464,37 @@ public void testBug426521() {
 		"The method m(List<Object>, Object) is ambiguous for the type Test\n" + 
 		"----------\n");
 }
+// https://bugs.eclipse.org/bugs/show_bug.cgi?id=428845
+public void testBug428845() {
+	runNegativeTest(
+			new String[] {
+				"AmbiguousTest.java",
+				"import java.io.File;\n" + 
+				"public class AmbiguousTest {\n" + 
+				"  static interface IInterface {\n" + 
+				"    public void method(File file);\n" + 
+				"  }\n" + 
+				"  static abstract class AbstractClass implements IInterface {\n" + 
+				"    public void method(File file) {\n" + 
+				"      System.err.println(\"file\");\n" + 
+				"    }\n" + 
+				"    public void method(String string) {\n" + 
+				"      System.err.println(\"string\");\n" + 
+				"    }\n" + 
+				"  }\n" + 
+				"  private static AbstractClass newAbstractClass() {\n" + 
+				"    return new AbstractClass() {};\n" + 
+				"  }\n" + 
+				"  public static void main(String[] args) {\n" + 
+				"    newAbstractClass().method(null);\n" + 
+				"  }\n" + 
+				"}"
+			},
+			"----------\n" + 
+			"1. ERROR in AmbiguousTest.java (at line 18)\n" + 
+			"	newAbstractClass().method(null);\n" + 
+			"	                   ^^^^^^\n" + 
+			"The method method(File) is ambiguous for the type AmbiguousTest.AbstractClass\n" + 
+			"----------\n");
+}
 }
diff --git a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java b/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java
index 501c8ab740..29a28b44f7 100644
--- a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java
+++ b/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java
@@ -1276,7 +1276,7 @@ public abstract class Scope {
 									continue; // can skip this method since concreteMatch overrides it
 							}
 						}
-						if (sourceLevel18) {
+						if (sourceLevel18 || !(compatibleMethod.isVarargs() && compatibleMethod instanceof ParameterizedGenericMethodBinding)) {
 							for (int j = 0; j < startFoundSize; j++) {
 								MethodBinding classMethod = (MethodBinding) found.elementAt(j);
 								if (classMethod != null && methodVerifier.areMethodsCompatible(classMethod, compatibleMethod))