Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Wolf2017-06-29 10:18:03 +0000
committerMatthias Sohn2017-06-30 21:02:57 +0000
commit47ce5ae6d4a6b6e092bf87d1de09043de8d4611a (patch)
tree17387e57875f67e393cc7a74e4f2c5b5fb9ea3bb /org.eclipse.egit.ui.test/src/org/eclipse/egit
parentef0f5bc8aef098f20bb57c9c338678ede4999e79 (diff)
downloadegit-47ce5ae6d4a6b6e092bf87d1de09043de8d4611a.tar.gz
egit-47ce5ae6d4a6b6e092bf87d1de09043de8d4611a.tar.xz
egit-47ce5ae6d4a6b6e092bf87d1de09043de8d4611a.zip
FetchGerritChangePage: auto-supply highest patch set number
If the change field contains only a change number but no patch set number, automatically fill in the highest patch set number obtained from Gerrit once we have the results of the ls-remote. If the field is the focus control and its contents have changed since we started the content assist, the user might be typing: don't interfere and do not auto-update the field. Bug: 518492 Change-Id: I5fa348aed4b6881c87749bbed6789f97d3e4e1d9 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Diffstat (limited to 'org.eclipse.egit.ui.test/src/org/eclipse/egit')
-rw-r--r--org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/fetch/FetchGerritChangeTest.java19
1 files changed, 18 insertions, 1 deletions
diff --git a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/fetch/FetchGerritChangeTest.java b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/fetch/FetchGerritChangeTest.java
index 82055f4f83..373a7b3ebe 100644
--- a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/fetch/FetchGerritChangeTest.java
+++ b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/fetch/FetchGerritChangeTest.java
@@ -152,10 +152,16 @@ public class FetchGerritChangeTest {
public void testChangeRefs() {
assertEquals(Change.create(65510, 6), FetchGerritChangePage
.determineChangeFromString("refs/changes/10/65510/6"));
- assertNull(FetchGerritChangePage
+ assertEquals(Change.create(65510), FetchGerritChangePage
.determineChangeFromString("refs/changes/10/65510/"));
+ assertEquals(Change.create(65510), FetchGerritChangePage
+ .determineChangeFromString("refs/changes/10/65510"));
assertNull(FetchGerritChangePage
.determineChangeFromString("refs/changes/10/"));
+ assertNull(FetchGerritChangePage
+ .determineChangeFromString("refs/changes/1/1/1"));
+ assertEquals(Change.create(1, 1), FetchGerritChangePage
+ .determineChangeFromString("refs/changes/01/1/1"));
assertEquals(Change.create(65510, 6), FetchGerritChangePage
.determineChangeFromString("refs/changes/42/65510/6"));
}
@@ -168,4 +174,15 @@ public class FetchGerritChangeTest {
assertEquals(Change.create(65510, 6),
Change.fromRef("refs/changes/10/65510/6"));
}
+
+ @Test
+ public void testRefFromChange() {
+ assertEquals("refs/changes/00/98000/2",
+ Change.create(98000, 2).getRefName());
+ assertEquals("refs/changes/01/98001/2",
+ Change.create(98001, 2).getRefName());
+ assertEquals("refs/changes/01/1/1", Change.create(1, 1).getRefName());
+ assertEquals("refs/changes/10/65510/6",
+ Change.create(65510, 6).getRefName());
+ }
}

Back to the top