Bug 309032: Need APIs to support memory pages (add ability for backend to indicate a memory space qualification is necessary)

2 files changed, 17 insertions, 1 deletions

diff --git a/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/model/provisional/IMemorySpaceAwareMemoryBlockRetrieval.java b/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/model/provisional/IMemorySpaceAwareMemoryBlockRetrieval.java
index 812c77ee9e5..ad4837a0dea 100644
--- a/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/model/provisional/IMemorySpaceAwareMemoryBlockRetrieval.java
+++ b/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/model/provisional/IMemorySpaceAwareMemoryBlockRetrieval.java
@@ -92,5 +92,12 @@ public interface IMemorySpaceAwareMemoryBlockRetrieval extends IMemoryBlockRetri
 	 *             if unable to retrieve the specified memory
 	 */
 	public IMemorySpaceAwareMemoryBlock getMemoryBlock(String expression, Object context, String memorySpaceID) throws DebugException;
-	
+
+	/**
+	 * Return true if creating a memory block with a null memory space ID is NOT
+	 * supported. Some debuggers may not have the ability to infer the memory
+	 * space from an expression, in which case the user should be forced to
+	 * select a memory space when being prompted for a memory location.
+	 */
+	public boolean creatingBlockRequiresMemorySpaceID();
 }
diff --git a/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/CMemoryBlockRetrievalExtension.java b/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/CMemoryBlockRetrievalExtension.java
index cd38ad9c30c..c0a64fc6127 100644
--- a/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/CMemoryBlockRetrievalExtension.java
+++ b/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/CMemoryBlockRetrievalExtension.java
@@ -473,4 +473,13 @@ public class CMemoryBlockRetrievalExtension extends PlatformObject implements IM
 		// Nope; use default decoding
 		return decodeAddressDefault(str);
 	}
+
+	/* (non-Javadoc)
+	 * @see org.eclipse.cdt.debug.core.model.provisional.IMemorySpaceAwareMemoryBlockRetrieval#creatingBlockRequiresMemorySpaceID()
+	 */
+	public boolean creatingBlockRequiresMemorySpaceID() {
+		// A behavioral control we're not extending to CDI clients, but is being
+		// extended to DSF ones.
+		return false;
+	}
 }