just refactoring some methods (to make it more readable)
diff --git a/bundles/org.eclipse.jst.jsp.core/src/org/eclipse/jst/jsp/core/internal/java/search/JSPIndexManager.java b/bundles/org.eclipse.jst.jsp.core/src/org/eclipse/jst/jsp/core/internal/java/search/JSPIndexManager.java
index aefff40..b32e5cb 100644
--- a/bundles/org.eclipse.jst.jsp.core/src/org/eclipse/jst/jsp/core/internal/java/search/JSPIndexManager.java
+++ b/bundles/org.eclipse.jst.jsp.core/src/org/eclipse/jst/jsp/core/internal/java/search/JSPIndexManager.java
@@ -120,28 +120,10 @@
boolean removed = (kind & IResourceDelta.REMOVED) == IResourceDelta.REMOVED;
if (added || isInterestingChange) {
- // https://w3.opensource.ibm.com/bugzilla/show_bug.cgi?id=3553
- // quick check if it's even JSP related to improve
- // performance
- // checking name from the delta before getting
- // resource because it's lighter
- int numSegments = delta.getFullPath().segmentCount();
- String filename = delta.getFullPath().segment(numSegments - 1);
- if (getJspContentType().isAssociatedWith(filename)) {
- IResource r = delta.getResource();
- if (r != null && r.exists() && r.getType() == IResource.FILE) {
- this.jspFiles.put(r.getFullPath(), r);
- }
- }
+ visitAdded(delta);
}
else if (removed) {
- // handle cleanup
- if (delta.getResource() != null) {
- IResource r = delta.getResource();
- if (r.getType() == IResource.FOLDER && r.exists()) {
- deleteIndex((IFile) r);
- }
- }
+ visitRemoved(delta);
}
}
}
@@ -155,6 +137,32 @@
return true;
}
+ private void visitRemoved(IResourceDelta delta) {
+ // handle cleanup
+ if (delta.getResource() != null) {
+ IResource r = delta.getResource();
+ if (r.getType() == IResource.FOLDER && r.exists()) {
+ deleteIndex((IFile) r);
+ }
+ }
+ }
+
+ private void visitAdded(IResourceDelta delta) {
+ // https://w3.opensource.ibm.com/bugzilla/show_bug.cgi?id=3553
+ // quick check if it's even JSP related to improve
+ // performance
+ // checking name from the delta before getting
+ // resource because it's lighter
+ int numSegments = delta.getFullPath().segmentCount();
+ String filename = delta.getFullPath().segment(numSegments - 1);
+ if (getJspContentType().isAssociatedWith(filename)) {
+ IResource r = delta.getResource();
+ if (r != null && r.exists() && r.getType() == IResource.FILE) {
+ this.jspFiles.put(r.getFullPath(), r);
+ }
+ }
+ }
+
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=93463
private boolean isHiddenResource(IPath p) {
String[] segments = p.segments();