commit 9620621126544e44e41604e0ca8466f20e9e6189
author kchong <kchong> Tue Sep 13 18:10:19 2005 +0000
committer kchong <kchong> Tue Sep 13 18:10:19 2005 +0000
tree 94afea3a4c5c674d09e45375ed33e87f5c5eabf2
parent 459c3b6aec13cb72e0ca8c1be9872093ddfe6bf8

[107680] Error updating "Other" properties tab when two XSD editors are open

bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/XSDTextEditor.java

diff --git a/bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/XSDTextEditor.java b/bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/XSDTextEditor.java
index 35f7c77..ac2a393 100644
--- a/bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/XSDTextEditor.java
+++ b/bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/XSDTextEditor.java
@@ -78,7 +78,8 @@
   {
     super.dispose();
     xsdSelectionManager.removeSelectionChangedListener(this);
-    adapterFactoryLabelProvider = null;
+    // Why is this static?  TODO Make it non-static...
+    //    adapterFactoryLabelProvider = null;
     xsdModelAdapterFactory = null;
   }
   

bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/properties/section/OtherAttributesSection.java

diff --git a/bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/properties/section/OtherAttributesSection.java b/bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/properties/section/OtherAttributesSection.java
index 1ab1582..2b934bc 100644
--- a/bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/properties/section/OtherAttributesSection.java
+++ b/bundles/org.eclipse.wst.xsd.ui/src/org/eclipse/wst/xsd/ui/internal/properties/section/OtherAttributesSection.java
@@ -73,8 +73,11 @@
   public void dispose()
   {
     super.dispose();
-    propertySheetPage.dispose();
-    propertySheetPage = null;
+    if (propertySheetPage != null)
+    {
+      propertySheetPage.dispose();
+      propertySheetPage = null;
+    }
   }
 
   /* (non-Javadoc)