More API cleanup
- really make MethodData/FieldData internal and really use the interfaces instead
- add missing x-internal in manifest
- create API problem filters for incompatibilities between 0.7.1 (3.6.1) and current
Resolve many warnings:
- none left in OT API packages
- almost none in compiler.ast
diff --git a/plugins/org.eclipse.objectteams.otdt.refactoring/src/org/eclipse/objectteams/otdt/internal/refactoring/adaptor/RenameTypeAdaptor.java b/plugins/org.eclipse.objectteams.otdt.refactoring/src/org/eclipse/objectteams/otdt/internal/refactoring/adaptor/RenameTypeAdaptor.java
index 0d489db..940f9f5 100644
--- a/plugins/org.eclipse.objectteams.otdt.refactoring/src/org/eclipse/objectteams/otdt/internal/refactoring/adaptor/RenameTypeAdaptor.java
+++ b/plugins/org.eclipse.objectteams.otdt.refactoring/src/org/eclipse/objectteams/otdt/internal/refactoring/adaptor/RenameTypeAdaptor.java
@@ -44,9 +44,9 @@
 import org.eclipse.ltk.core.refactoring.participants.CheckConditionsContext;

 import org.eclipse.text.edits.ReplaceEdit;

 import org.eclipse.objectteams.otdt.core.IOTType;

+import org.eclipse.objectteams.otdt.core.IPhantomType;

 import org.eclipse.objectteams.otdt.core.IRoleType;

 import org.eclipse.objectteams.otdt.core.OTModelManager;

-import org.eclipse.objectteams.otdt.core.PhantomType;

 import org.eclipse.objectteams.otdt.core.TypeHelper;

 import org.eclipse.objectteams.otdt.core.hierarchy.OTTypeHierarchies;

 

@@ -599,8 +599,8 @@
 		private IType getTeam(IType roleType) {

 			IType enclosingTeam;

 			IOTType otElement;

-			if(roleType instanceof PhantomType){

-				enclosingTeam = (IType) ((PhantomType)roleType).getParent();

+			if(roleType instanceof IPhantomType){

+				enclosingTeam = (IType) ((IPhantomType)roleType).getParent();

 			}else{

 				otElement = OTModelManager.getOTElement(roleType);

 				enclosingTeam = ((IRoleType)otElement).getTeam();

diff --git a/plugins/org.eclipse.objectteams.otdt.refactoring/src/org/eclipse/objectteams/otdt/internal/refactoring/adaptor/pushdown/PushDownAdaptor.java b/plugins/org.eclipse.objectteams.otdt.refactoring/src/org/eclipse/objectteams/otdt/internal/refactoring/adaptor/pushdown/PushDownAdaptor.java
index 2462ad6..0c1697e 100644
--- a/plugins/org.eclipse.objectteams.otdt.refactoring/src/org/eclipse/objectteams/otdt/internal/refactoring/adaptor/pushdown/PushDownAdaptor.java
+++ b/plugins/org.eclipse.objectteams.otdt.refactoring/src/org/eclipse/objectteams/otdt/internal/refactoring/adaptor/pushdown/PushDownAdaptor.java
@@ -34,7 +34,7 @@
 import org.eclipse.objectteams.otdt.core.ICallinMapping;

 import org.eclipse.objectteams.otdt.core.ICalloutMapping;

 import org.eclipse.objectteams.otdt.core.ICalloutToFieldMapping;

-import org.eclipse.objectteams.otdt.core.PhantomType;

+import org.eclipse.objectteams.otdt.core.IPhantomType;

 import org.eclipse.objectteams.otdt.core.TypeHelper;

 import org.eclipse.objectteams.otdt.core.hierarchy.OTTypeHierarchies;

 import org.eclipse.objectteams.otdt.internal.refactoring.util.IAmbuguityMessageCreator;

@@ -270,7 +270,7 @@
 			IType[] subTypes = hier.getSubtypes(getDeclaringType());

 			for (int i = 0; i < subTypes.length; i++) {

 				IType subType = subTypes[i];

-				if(subType instanceof PhantomType){

+				if(subType instanceof IPhantomType){

 					String msg = Messages.format("An implicit sub role of ''{0}'' is a phantom role, therefore the pushed down members cannot be moved to ''{1}''.", new String[] { getDeclaringType().getFullyQualifiedName('.'), subType.getFullyQualifiedName('.') });

 					status.addError(msg, JavaStatusContext.create(subType));

 				}