Revert "Releng: still better decoupling of boot/base location: - let
p2helper use director from base location"

This reverts commit 7b50a17e9b1b6e67c45b800a7e97fc35594744f2.

Instead: distinguish versions of equinox.launcher
diff --git a/releng/build-scripts/build/p2helper.xml b/releng/build-scripts/build/p2helper.xml
index 8910382..28ebef5 100644
--- a/releng/build-scripts/build/p2helper.xml
+++ b/releng/build-scripts/build/p2helper.xml
@@ -35,7 +35,7 @@
                 dir="${targetEclipseDir}"
                 fork="true"
                 classname="org.eclipse.equinox.launcher.Main"
-                classpath="${directorLocation}/plugins/${org.eclipse.equinox.launcher_jar}">
+                classpath="${targetEclipseDir}/plugins/${org.eclipse.equinox.launcher_jar}">
             <jvmarg value="-Declipse.p2.MD5Check=false" />
             <arg value="-consoleLog"/>
             <arg value="-application"/>
@@ -56,7 +56,7 @@
                 dir="${targetEclipseDir}"
                 fork="true"
                 classname="org.eclipse.equinox.launcher.Main"
-                classpath="${directorLocation}/plugins/${org.eclipse.equinox.launcher_jar}">
+                classpath="${targetEclipseDir}/plugins/${org.eclipse.equinox.launcher_jar}">
             <jvmarg value="-Declipse.p2.MD5Check=false" />
             <arg value="-consoleLog"/>
             <arg value="-application"/>
diff --git a/releng/build-scripts/build/run.properties b/releng/build-scripts/build/run.properties
index 6c6613f..9179d86 100644
--- a/releng/build-scripts/build/run.properties
+++ b/releng/build-scripts/build/run.properties
@@ -20,6 +20,7 @@
 # ------------- insert current versions here ---------------
 # Details of the boot Eclipse SDK:
 run.eclipseScriptDir=plugins/org.eclipse.pde.build_3.10.300.v20190305-0856/scripts
+boot.org.eclipse.equinox.launcher_jar=org.eclipse.equinox.launcher_1.5.300.v20190213-1655.jar
 # Details of the Eclipse SDK built upon:
 org.eclipse.equinox.launcher_jar=org.eclipse.equinox.launcher_1.5.400.v20190515-0925.jar
 
diff --git a/releng/build-scripts/build/run.xml b/releng/build-scripts/build/run.xml
index bca6d0a..d235040 100644
--- a/releng/build-scripts/build/run.xml
+++ b/releng/build-scripts/build/run.xml
@@ -235,10 +235,10 @@
 		<echo message="Invoke pdebuild for creating the OT-Compiler"/>
 <!-- Re-use the compiler from the previous published build: -->
         <ant antfile="${OTScriptDir}/p2helper.xml" target="installFeatureFromUrl" dir="${bootLocation}">
-       		<property name="directorLocation" value="${baseLocation}"/>
             <property name="feature" value="org.eclipse.objectteams.otdt.core.patch.feature.group"/>
             <property name="sourceUpdatesUrl" value="${compilerUpdatesDir}"/>
             <property name="targetEclipseDir" value="${bootLocation}"/>
+        	<property name="org.eclipse.equinox.launcher_jar" value="${boot.org.eclipse.equinox.launcher_jar}"/>
         </ant>
 		<delete>
 		    <fileset dir="${bootLocation}/plugins/" includes="org.eclipse.jdt.core_*.v* org.eclipse.jdt.core.source_*.v*" />
@@ -255,7 +255,6 @@
         <mkdir dir="${testsUpdatesDirBase}/eclipse"/>
         <unzip dest="${testsUpdatesDirBase}/eclipse" src="${eclipse.tests.zip}"/> 
         <ant antfile="${OTScriptDir}/p2helper.xml" target="installFeature" dir="${baseLocation}">
-       		<property name="directorLocation" value="${baseLocation}"/>
             <property name="feature" value="org.eclipse.test.feature.group"/>
             <property name="sourceUpdatesDir" value="${testsUpdatesDirBase}/eclipse"/>
             <property name="targetEclipseDir" value="${baseLocation}"/>
@@ -330,10 +329,8 @@
 		</java>
 		<!-- At this point a local update site exists, thanks to p2gathering=true -->
 		
-        <ant antfile="${OTScriptDir}/p2helper.xml" target="patchMetadata" dir="${otdtUpdatesDir}">
-       		<property name="directorLocation" value="${baseLocation}"/>
-		</ant>
-        	
+        <ant antfile="${OTScriptDir}/p2helper.xml" target="patchMetadata" dir="${otdtUpdatesDir}"/>
+		
 		<property name="_hasCreatedOTDTEclipse" value="true" />
 	</target>
 	
diff --git a/releng/build-scripts/build/test.xml b/releng/build-scripts/build/test.xml
index 0fb8551..64b3c2b 100644
--- a/releng/build-scripts/build/test.xml
+++ b/releng/build-scripts/build/test.xml
@@ -37,10 +37,8 @@
 		<echo message="### Build Test Eclipse ###"/>

 

 		<echo message="Installing OTDT..."/>

-		<ant antfile="${OTScriptDir}/p2helper.xml" target="installOTDT" dir="${test.eclipseDir}">

-       		<property name="directorLocation" value="${baseLocation}"/>

-		</ant>

-

+		<ant antfile="${OTScriptDir}/p2helper.xml" target="installOTDT" dir="${test.eclipseDir}"/>

+		

 		<property name="otdt-eclipse.is.setup" value="true"/>

 	</target>

 

@@ -49,9 +47,7 @@
 	>

 		<echo message="Setting up tests in ${test.eclipseDir}"/>

 		<!-- do install using p2: -->

-		<ant antfile="${OTScriptDir}/p2helper.xml" target="installTests" dir="${test.eclipseDir}">

-       		<property name="directorLocation" value="${baseLocation}"/>

-		</ant>

+		<ant antfile="${OTScriptDir}/p2helper.xml" target="installTests" dir="${test.eclipseDir}"/>

 

 		<echo message="get library.xml"/>

 		<get src="http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/plain/eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests/src/main/scripts/library.xml"