Bug 579588 - wrong setting of relevance for created type proposal
- fix JavaTypeCompletionProposalComputer.createTypeProposal() method
to use the relevance passed to set relevance of the lazy completion
proposals directly and not for the wrapped proposal
Change-Id: Ie7fd7b187309cd8e1e8d4db877b60e4853a3678e
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/192524
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaTypeCompletionProposalComputer.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaTypeCompletionProposalComputer.java
index aa8ae0e..c00f9bb 100644
--- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaTypeCompletionProposalComputer.java
+++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaTypeCompletionProposalComputer.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2005, 2018 IBM Corporation and others.
+ * Copyright (c) 2005, 2022 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
@@ -121,14 +121,18 @@
proposal.setCompletion(fullyQualifiedType.toCharArray());
proposal.setDeclarationSignature(type.getPackageFragment().getElementName().toCharArray());
proposal.setFlags(type.getFlags());
- proposal.setRelevance(relevance);
proposal.setReplaceRange(context.getInvocationOffset(), context.getInvocationOffset());
proposal.setSignature(Signature.createTypeSignature(fullyQualifiedType, true).toCharArray());
- if (shouldProposeGenerics(context.getProject()))
- return new LazyGenericTypeProposal(proposal, context);
- else
- return new LazyJavaTypeCompletionProposal(proposal, context);
+ if (shouldProposeGenerics(context.getProject())) {
+ LazyGenericTypeProposal p= new LazyGenericTypeProposal(proposal, context);
+ p.setRelevance(relevance);
+ return p;
+ } else {
+ LazyJavaTypeCompletionProposal p= new LazyJavaTypeCompletionProposal(proposal, context);
+ p.setRelevance(relevance);
+ return p;
+ }
}
/**