| commit | 9bc3b085832b48a2649f89d48d24075751e382b1 | [log] [tgz] |
|---|---|---|
| author | Lars Vogel <Lars.Vogel@vogella.com> | Thu Jul 01 14:06:32 2021 +0200 |
| committer | Lars Vogel <Lars.Vogel@vogella.com> | Mon Jul 26 05:43:07 2021 -0400 |
| tree | c1a6474e6ee677502014ef926a6b9664087091ae | |
| parent | 1f14ea8659bac6709fd4939490e462ed118cd44e [diff] |
[dogfooding][cleanup] Use new StringBuffer -> StringBuilder cleanup for tests.model To ensure that the new JDT cleanup works correctly for clients we should run it also on our own code base. This help to ensure that the cleanup works fine and helps us to cleanup our own code base. From the commit message of the cleanup: - create a cleanup to replace usage of StringBuffer with StringBuilder. The two are equivalent, but StringBuffer is thread-safe and synchronized which makes it slower than StringBuilder which was introduced in Java 1.5. To avoid API changes, we should only use the local variable change. Change-Id: Ie6c677c4ac8d0c3a7fa4305d2770fe5783df6473 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.bundles/+/182678 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
diff --git a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/EclipsePreferences.java b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/EclipsePreferences.java index a5eb8ad..e039a9b 100644 --- a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/EclipsePreferences.java +++ b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/EclipsePreferences.java
@@ -1217,7 +1217,7 @@ } public String toDeepDebugString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); IPreferenceNodeVisitor visitor = (IEclipsePreferences node) -> { buffer.append(node); buffer.append('\n');
diff --git a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/CryptoData.java b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/CryptoData.java index 4e9703b..c7e59a2 100644 --- a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/CryptoData.java +++ b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/CryptoData.java
@@ -93,7 +93,7 @@ @Override public String toString() { - StringBuffer encryptedText = (moduleID == null) ? new StringBuffer() : new StringBuffer(moduleID); + StringBuilder encryptedText = (moduleID == null) ? new StringBuilder() : new StringBuilder(moduleID); encryptedText.append(MODULE_ID_SEPARATOR); if (iv != null) { encryptedText.append(Base64.encode(iv));