Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabrice Tiercelin2020-11-19 11:52:24 +0000
committerFabrice Tiercelin2020-11-19 17:20:08 +0000
commitf7377d6c1350b735d5ffe0cde2fce8dd8de9f694 (patch)
tree041bca363cb95c8d8fb4571242a0927b8b2e2f38
parent15fe9c6dce966be8c0a9b47dc6c78a905c7a9123 (diff)
downloadnews-f7377d6c1350b735d5ffe0cde2fce8dd8de9f694.tar.gz
news-f7377d6c1350b735d5ffe0cde2fce8dd8de9f694.tar.xz
news-f7377d6c1350b735d5ffe0cde2fce8dd8de9f694.zip
Bug 568050 - [AutoRefactor immigration #36/141] [cleanup & saveaction]
Break loop Change-Id: I5e58b0bfe220236a66a213201010220d9909212d Signed-off-by: Fabrice Tiercelin <fabrice.tiercelin@yahoo.fr> Depends-On: I468c93096ae66230d97e6d96ef013e6395e42097
-rw-r--r--4.18/images/break-loop-after.pngbin0 -> 13251 bytes
-rw-r--r--4.18/images/break-loop-before.pngbin0 -> 10187 bytes
-rw-r--r--4.18/jdt.html24
3 files changed, 24 insertions, 0 deletions
diff --git a/4.18/images/break-loop-after.png b/4.18/images/break-loop-after.png
new file mode 100644
index 00000000..bd7321cf
--- /dev/null
+++ b/4.18/images/break-loop-after.png
Binary files differ
diff --git a/4.18/images/break-loop-before.png b/4.18/images/break-loop-before.png
new file mode 100644
index 00000000..e7988825
--- /dev/null
+++ b/4.18/images/break-loop-before.png
Binary files differ
diff --git a/4.18/jdt.html b/4.18/jdt.html
index dc3317bd..d13e20d2 100644
--- a/4.18/jdt.html
+++ b/4.18/jdt.html
@@ -558,6 +558,30 @@ ul {padding-left: 13px;}
</td>
</tr>
+ <tr id="break-loop"> <!-- https://bugs.eclipse.org/bugs/show_bug.cgi?id=568050 -->
+ <td class="title"><a href="#break-loop">Exit loop earlier</a></td>
+ <td class="content">
+ A new clean up has been added that adds a <code>break</code> to avoid passive <code>for</code> loop iterations.
+ <p>
+ The inner assignments must not do other different assignments after (assign other values or assign into other variables).
+ </p>
+ <p>
+ There must be no side effects after the first assignments.
+ </p>
+ <p>
+ To apply the clean up, invoke <b>Source &gt; Clean Up...</b>, use a custom profile, and on the <b>Configure...</b> dialog, select <b>Exit loop earlier</b> check box on the <b>Optimization</b> tab.
+ </p>
+ <p>
+ For the given code:
+ </p>
+ <p><img src="images/break-loop-before.png" alt="Before"/></p>
+ <p>
+ One gets:
+ </p>
+ <p><img src="images/break-loop-after.png" alt="After"/></p>
+ </td>
+ </tr>
+
<tr id="boolean-literal"> <!-- https://bugs.eclipse.org/bugs/show_bug.cgi?id=567560 -->
<td class="title"><a href="#boolean-literal">Prefer boolean literal</a></td>
<td class="content">

Back to the top