[Bug 437263] new website download button confusing

Signed-off-by: Christopher Guindon <chris.guindon@eclipse.org>

2 files changed, 30 insertions, 6 deletions

diff --git a/system/breadcrumbs.class.php b/system/breadcrumbs.class.php
index f68ae0b6..6f15fbfc 100644
--- a/system/breadcrumbs.class.php
+++ b/system/breadcrumbs.class.php
@@ -59,6 +59,7 @@ class Breadcrumb extends Menu {
     "screenshots" => "Screenshots",
     "site_login" => "My Account",
     "users"  => "Getting started",
+    "" => "", //Homepage
   );
 
   function getCrumbList() {
@@ -151,11 +152,15 @@ class Breadcrumb extends Menu {
 
   function addCrumb($_Text, $_URL, $_Target) {
     $_Text = strip_tags($_Text);
-    # Menu Items must be added at position 1
-    $Crumb = new Link($_Text, $_URL, $_Target, 0);
 
-    # Add incoming menuitem
-    $this->CrumbList[count($this->CrumbList)] = $Crumb;
+    // We don't need to add a crumb if there is no text for it.
+    if (!empty($_Text)) {
+      # Menu Items must be added at position 1
+      $Crumb = new Link($_Text, $_URL, $_Target, 0);
+
+      # Add incoming menuitem
+      $this->CrumbList[count($this->CrumbList)] = $Crumb;
+    }
   }
 
   function getCrumbCount() {
@@ -163,9 +168,14 @@ class Breadcrumb extends Menu {
   }
 
   function getCrumbAt($_Pos) {
-    if($_Pos < $this->getCrumbCount()) {
+    if ($_Pos < $this->getCrumbCount()) {
       return $this->CrumbList[$_Pos];
     }
+    // If link does not exist, return an empty link object
+    else {
+      $Crumb = new Link('', '', '', 0);
+      return $Crumb;
+    }
   }
 
   /**
diff --git a/themes/solstice/app.php b/themes/solstice/app.php
index ea014412..e4a163cc 100644
--- a/themes/solstice/app.php
+++ b/themes/solstice/app.php
@@ -104,10 +104,24 @@ class Solstice {
       $variables['theme_variables']['breadcrumbs_classes'] = 'defaut-breadcrumbs hidden-print';
     }
 
-    $classes = array();
+   $classes = array();
+   $crumb1 = $Breadcrumb->getCrumbAt(1)->getText();
+   $url_parts = explode('/', str_ireplace(array('http://', 'https://'), '', $_SERVER['REQUEST_URI']));
+   $directory = strtolower($url_parts[1]);
     if (!empty($variables['theme_variables']['btn_cfa']['hide']) && $variables['theme_variables']['btn_cfa']['hide'] === TRUE) {
       $classes[] = 'hidden-cfa-button';
     }
+    // Make sure this is a project and not the project sub-directory on
+    // eclipse.org
+    elseif ($crumb1 === 'Projects' && $directory != 'projects') {
+      // If the user is not trying to override this button, let's change
+      // it for all of our project websites.
+      if (empty($variables['theme_variables']['btn_cfa']['text']) && empty($variables['theme_variables']['btn_cfa']['url'])) {
+        $variables['theme_variables']['btn_cfa']['text'] = 'Donate';
+        $variables['theme_variables']['btn_cfa']['href'] = 'https://www.eclipse.org/donate/';
+        $variables['theme_variables']['btn_cfa']['class'] = 'btn btn-huge btn-info';
+      }
+    }
 
     $deprecated = "";
     $items = array();