Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGlyn Normington2011-06-02 10:50:59 +0000
committerGlyn Normington2011-06-02 10:50:59 +0000
commit2a381605e437c9dd3187b7bcfccd7e8099e114e4 (patch)
tree04670a0b3fad938ff8db1d8b253e0a077061fa74 /org.eclipse.virgo.medic/src/main
parent420de9de167d1ce05181c962024e65112875b316 (diff)
downloadorg.eclipse.virgo.medic-2a381605e437c9dd3187b7bcfccd7e8099e114e4.tar.gz
org.eclipse.virgo.medic-2a381605e437c9dd3187b7bcfccd7e8099e114e4.tar.xz
org.eclipse.virgo.medic-2a381605e437c9dd3187b7bcfccd7e8099e114e4.zip
Bug 328033: remove entry/exit advice from hashCode(), equals(), and toString() methods
Diffstat (limited to 'org.eclipse.virgo.medic/src/main')
-rw-r--r--org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj9
1 files changed, 6 insertions, 3 deletions
diff --git a/org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj b/org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj
index a48462c..762118f 100644
--- a/org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj
+++ b/org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj
@@ -39,13 +39,16 @@ public aspect EntryExitTrace pertypewithin(*) {
pointcut logback() : within(ch.qos.logback..*) || within(org.slf4j.impl..*);
+ // avoid common methods with little benefit of entry/exit trace logging
pointcut setter() : execution(* set*(..));
-
pointcut getter() : execution(* get*(..));
+ pointcut hashCode() : execution(public int hashCode());
+ pointcut equals() : execution(public boolean equals(Object));
+ pointcut toString() : execution(public String toString());
- pointcut debugCandidate() : execution(public * *(..)) && !setter() && !getter() && !medic() && !util() && !repository() && !kernelUserRegion() && !webClassLoading() && !logback();
+ pointcut debugCandidate() : execution(public * *(..)) && !setter() && !getter() && !hashCode() && !equals() && !toString() && !medic() && !util() && !repository() && !kernelUserRegion() && !webClassLoading() && !logback();
- pointcut traceCandidate() : execution(!public * *(..)) && !setter() && !getter() && !medic() && !util() && !repository() && !kernelUserRegion() && !webClassLoading() && !logback();
+ pointcut traceCandidate() : execution(!public * *(..)) && !setter() && !getter() && !hashCode() && !equals() && !toString() && !medic() && !util() && !repository() && !kernelUserRegion() && !webClassLoading() && !logback();
before() : debugCandidate() {
getLogger(thisJoinPointStaticPart).debug("{} {}", ">",

Back to the top