Bug 328033: remove entry/exit advice from hashCode(), equals(), and toString() methods

1 files changed, 6 insertions, 3 deletions

diff --git a/org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj b/org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj
index a48462c..762118f 100644
--- a/org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj
+++ b/org.eclipse.virgo.medic/src/main/java/org/eclipse/virgo/medic/log/EntryExitTrace.aj
@@ -39,13 +39,16 @@ public aspect EntryExitTrace pertypewithin(*) {
 
 	pointcut logback() : within(ch.qos.logback..*) || within(org.slf4j.impl..*);
 
+    // avoid common methods with little benefit of entry/exit trace logging
 	pointcut setter() : execution(* set*(..));
-
 	pointcut getter() : execution(* get*(..));
+	pointcut hashCode() : execution(public int hashCode());
+	pointcut equals() : execution(public boolean equals(Object));
+	pointcut toString() : execution(public String toString());
 
-	pointcut debugCandidate() : execution(public * *(..)) && !setter() && !getter() && !medic() && !util() && !repository() && !kernelUserRegion() && !webClassLoading() && !logback();
+	pointcut debugCandidate() : execution(public * *(..)) && !setter() && !getter() && !hashCode() && !equals() && !toString() && !medic() && !util() && !repository() && !kernelUserRegion() && !webClassLoading() && !logback();
 
-	pointcut traceCandidate() : execution(!public * *(..)) && !setter() && !getter() && !medic() && !util() && !repository() && !kernelUserRegion() && !webClassLoading() && !logback();
+	pointcut traceCandidate() : execution(!public * *(..)) && !setter() && !getter() && !hashCode() && !equals() && !toString() && !medic() && !util() && !repository() && !kernelUserRegion() && !webClassLoading() && !logback();
 
 	before() : debugCandidate() {
 		getLogger(thisJoinPointStaticPart).debug("{} {}", ">",