Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--admin/findbugs-exclude.xml9
-rw-r--r--target_explorer/plugins/org.eclipse.tcf.te.launch.core/src/org/eclipse/tcf/te/launch/core/persistence/AbstractItemListXMLParser.java4
-rw-r--r--target_explorer/plugins/org.eclipse.tcf.te.runtime/src/org/eclipse/tcf/te/runtime/callback/Callback.java2
3 files changed, 12 insertions, 3 deletions
diff --git a/admin/findbugs-exclude.xml b/admin/findbugs-exclude.xml
index 0193e04f0..1d9899b40 100644
--- a/admin/findbugs-exclude.xml
+++ b/admin/findbugs-exclude.xml
@@ -23,6 +23,15 @@
</Or>
</Match>
+ <!-- Ignore all inner class should be static violations -->
+ <Match>
+ <Or>
+ <Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
+ <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON"/>
+ <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS"/>
+ </Or>
+ </Match>
+
<!-- Ignore all ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD violations in bundle activators -->
<Match>
<Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
diff --git a/target_explorer/plugins/org.eclipse.tcf.te.launch.core/src/org/eclipse/tcf/te/launch/core/persistence/AbstractItemListXMLParser.java b/target_explorer/plugins/org.eclipse.tcf.te.launch.core/src/org/eclipse/tcf/te/launch/core/persistence/AbstractItemListXMLParser.java
index 4d553ced4..e56ab4d5c 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.launch.core/src/org/eclipse/tcf/te/launch/core/persistence/AbstractItemListXMLParser.java
+++ b/target_explorer/plugins/org.eclipse.tcf.te.launch.core/src/org/eclipse/tcf/te/launch/core/persistence/AbstractItemListXMLParser.java
@@ -34,8 +34,8 @@ import org.xml.sax.helpers.DefaultHandler;
* AbstractItemListXMLParser
*/
public abstract class AbstractItemListXMLParser<ItemType> extends DefaultHandler {
- private final int IN_ITEMS_DEFINITION = 1;
- private final int IN_ITEM_DEFINITION = 2;
+ private final static int IN_ITEMS_DEFINITION = 1;
+ private final static int IN_ITEM_DEFINITION = 2;
private SAXParser parser;
diff --git a/target_explorer/plugins/org.eclipse.tcf.te.runtime/src/org/eclipse/tcf/te/runtime/callback/Callback.java b/target_explorer/plugins/org.eclipse.tcf.te.runtime/src/org/eclipse/tcf/te/runtime/callback/Callback.java
index 1b1cf7ec7..ed3340e61 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.runtime/src/org/eclipse/tcf/te/runtime/callback/Callback.java
+++ b/target_explorer/plugins/org.eclipse.tcf.te.runtime/src/org/eclipse/tcf/te/runtime/callback/Callback.java
@@ -38,7 +38,7 @@ public class Callback extends PropertiesContainer implements ICallback {
* Property: Asynchronous operations can store a result to the callback
* object they invoke once the operation has been finished.
*/
- protected final String PROPERTY_RESULT = "result"; //$NON-NLS-1$
+ protected static final String PROPERTY_RESULT = "result"; //$NON-NLS-1$
private static final String[] PROPERTY_KEYS_NOT_TO_COPY = {

Back to the top