Target Explorer: Fix Bug 412590 - NPE when I try to "Save All"

1 files changed, 130 insertions, 126 deletions

diff --git a/target_explorer/plugins/org.eclipse.tcf.te.tcf.filesystem.ui/src/org/eclipse/tcf/te/tcf/filesystem/ui/internal/autosave/SaveAllListener.java b/target_explorer/plugins/org.eclipse.tcf.te.tcf.filesystem.ui/src/org/eclipse/tcf/te/tcf/filesystem/ui/internal/autosave/SaveAllListener.java
index cc616e029..f5787b7c1 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.tcf.filesystem.ui/src/org/eclipse/tcf/te/tcf/filesystem/ui/internal/autosave/SaveAllListener.java
+++ b/target_explorer/plugins/org.eclipse.tcf.te.tcf.filesystem.ui/src/org/eclipse/tcf/te/tcf/filesystem/ui/internal/autosave/SaveAllListener.java
@@ -1,126 +1,130 @@
-/*******************************************************************************

- * Copyright (c) 2011, 2012 Wind River Systems, Inc. and others. All rights reserved.

- * This program and the accompanying materials are made available under the terms

- * of the Eclipse Public License v1.0 which accompanies this distribution, and is

- * available at http://www.eclipse.org/legal/epl-v10.html

- *

- * Contributors:

- * William Chen (Wind River) - [345552] Edit the remote files with a proper editor

- *******************************************************************************/

-package org.eclipse.tcf.te.tcf.filesystem.ui.internal.autosave;

-

-import java.io.File;

-import java.net.URI;

-import java.util.ArrayList;

-import java.util.List;

-

-import org.eclipse.core.commands.ExecutionEvent;

-import org.eclipse.core.commands.ExecutionException;

-import org.eclipse.core.commands.IExecutionListener;

-import org.eclipse.core.commands.NotHandledException;

-import org.eclipse.core.filesystem.EFS;

-import org.eclipse.core.filesystem.IFileStore;

-import org.eclipse.core.runtime.NullProgressMonitor;

-import org.eclipse.core.runtime.SafeRunner;

-import org.eclipse.jface.util.SafeRunnable;

-import org.eclipse.tcf.te.tcf.filesystem.core.internal.operations.IOpExecutor;

-import org.eclipse.tcf.te.tcf.filesystem.core.internal.operations.NullOpExecutor;

-import org.eclipse.tcf.te.tcf.filesystem.core.internal.operations.OpParsePath;

-import org.eclipse.tcf.te.tcf.filesystem.core.internal.operations.OpUpload;

-import org.eclipse.tcf.te.tcf.filesystem.core.model.FSTreeNode;

-import org.eclipse.tcf.te.tcf.filesystem.ui.activator.UIPlugin;

-import org.eclipse.tcf.te.tcf.filesystem.ui.internal.operations.UiExecutor;

-import org.eclipse.ui.IEditorInput;

-import org.eclipse.ui.IEditorPart;

-import org.eclipse.ui.IURIEditorInput;

-import org.eclipse.ui.IWorkbenchPage;

-import org.eclipse.ui.handlers.HandlerUtil;

-

-/**

- * The execution listener of command "SAVE ALL", which synchronizes the local

- * file with the one on the target server after it is saved.

- */

-public class SaveAllListener implements IExecutionListener {

-	// Dirty nodes that should be saved and synchronized.

-	List<FSTreeNode> fDirtyNodes;

-	/**

-	 * Create the listener listening to command "SAVE ALL".

-	 */

-	public SaveAllListener() {

-		this.fDirtyNodes = new ArrayList<FSTreeNode>();

-	}

-

-	/* (non-Javadoc)

-	 * @see org.eclipse.core.commands.IExecutionListener#postExecuteSuccess(java.lang.String, java.lang.Object)

-	 */

-	@Override

-	public void postExecuteSuccess(String commandId, Object returnValue) {

-		if (!fDirtyNodes.isEmpty()) {

-			if (UIPlugin.isAutoSaving()) {

-				FSTreeNode[] nodes = fDirtyNodes.toArray(new FSTreeNode[fDirtyNodes.size()]);

-				IOpExecutor executor = new UiExecutor();

-				executor.execute(new OpUpload(nodes));

-			}

-			else {

-				SafeRunner.run(new SafeRunnable(){

-					@Override

-                    public void handleException(Throwable e) {

-						// Ignore exception

-                    }

-					@Override

-                    public void run() throws Exception {

-						for (FSTreeNode dirtyNode : fDirtyNodes) {

-							dirtyNode.refresh();

-						}

-                    }});

-			}

-		}

-	}

-

-	/* (non-Javadoc)

-	 * @see org.eclipse.core.commands.IExecutionListener#preExecute(java.lang.String, org.eclipse.core.commands.ExecutionEvent)

-	 */

-	@Override

-	public void preExecute(String commandId, ExecutionEvent event) {

-		fDirtyNodes.clear();

-		IWorkbenchPage page = HandlerUtil.getActiveWorkbenchWindow(event).getActivePage();

-		IEditorPart[] editors = page.getDirtyEditors();

-		for (IEditorPart editor : editors) {

-			IEditorInput input = editor.getEditorInput();

-			FSTreeNode node = null;

-			if (input instanceof IURIEditorInput) {

-				//Get the file that is being edited.

-				IURIEditorInput fileInput = (IURIEditorInput) input;

-				URI uri = fileInput.getURI();

-				try {

-					IFileStore store = EFS.getStore(uri);

-					File localFile = store.toLocalFile(0, new NullProgressMonitor());

-					if (localFile != null) {

-						// Get the file's mapped FSTreeNode.

-						OpParsePath parser = new OpParsePath(localFile.getCanonicalPath());

-						new NullOpExecutor().execute(parser);

-						node = parser.getResult();

-						if (node != null) {

-							// If it is a modified node, add it to the dirty node list.

-							fDirtyNodes.add(node);

-						}

-					}

-				}catch(Exception e){}

-			}

-		}

-	}

-

-	/* (non-Javadoc)

-	 * @see org.eclipse.core.commands.IExecutionListener#notHandled(java.lang.String, org.eclipse.core.commands.NotHandledException)

-	 */

-	@Override

-	public void notHandled(String commandId, NotHandledException exception) {

-	}

-

-	/* (non-Javadoc)

-	 * @see org.eclipse.core.commands.IExecutionListener#postExecuteFailure(java.lang.String, org.eclipse.core.commands.ExecutionException)

-	 */

-	@Override

-	public void postExecuteFailure(String commandId, ExecutionException exception) {

-	}

-}

+/*******************************************************************************
+ * Copyright (c) 2011, 2012 Wind River Systems, Inc. and others. All rights reserved.
+ * This program and the accompanying materials are made available under the terms
+ * of the Eclipse Public License v1.0 which accompanies this distribution, and is
+ * available at http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ * William Chen (Wind River) - [345552] Edit the remote files with a proper editor
+ *******************************************************************************/
+package org.eclipse.tcf.te.tcf.filesystem.ui.internal.autosave;
+
+import java.io.File;
+import java.net.URI;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.eclipse.core.commands.ExecutionEvent;
+import org.eclipse.core.commands.ExecutionException;
+import org.eclipse.core.commands.IExecutionListener;
+import org.eclipse.core.commands.NotHandledException;
+import org.eclipse.core.filesystem.EFS;
+import org.eclipse.core.filesystem.IFileStore;
+import org.eclipse.core.runtime.NullProgressMonitor;
+import org.eclipse.core.runtime.SafeRunner;
+import org.eclipse.jface.util.SafeRunnable;
+import org.eclipse.tcf.te.tcf.filesystem.core.internal.operations.IOpExecutor;
+import org.eclipse.tcf.te.tcf.filesystem.core.internal.operations.NullOpExecutor;
+import org.eclipse.tcf.te.tcf.filesystem.core.internal.operations.OpParsePath;
+import org.eclipse.tcf.te.tcf.filesystem.core.internal.operations.OpUpload;
+import org.eclipse.tcf.te.tcf.filesystem.core.model.FSTreeNode;
+import org.eclipse.tcf.te.tcf.filesystem.ui.activator.UIPlugin;
+import org.eclipse.tcf.te.tcf.filesystem.ui.internal.operations.UiExecutor;
+import org.eclipse.ui.IEditorInput;
+import org.eclipse.ui.IEditorPart;
+import org.eclipse.ui.IURIEditorInput;
+import org.eclipse.ui.IWorkbenchPage;
+import org.eclipse.ui.IWorkbenchWindow;
+import org.eclipse.ui.PlatformUI;
+import org.eclipse.ui.handlers.HandlerUtil;
+
+/**
+ * The execution listener of command "SAVE ALL", which synchronizes the local
+ * file with the one on the target server after it is saved.
+ */
+public class SaveAllListener implements IExecutionListener {
+	// Dirty nodes that should be saved and synchronized.
+	List<FSTreeNode> fDirtyNodes;
+	/**
+	 * Create the listener listening to command "SAVE ALL".
+	 */
+	public SaveAllListener() {
+		this.fDirtyNodes = new ArrayList<FSTreeNode>();
+	}
+
+	/* (non-Javadoc)
+	 * @see org.eclipse.core.commands.IExecutionListener#postExecuteSuccess(java.lang.String, java.lang.Object)
+	 */
+	@Override
+	public void postExecuteSuccess(String commandId, Object returnValue) {
+		if (!fDirtyNodes.isEmpty()) {
+			if (UIPlugin.isAutoSaving()) {
+				FSTreeNode[] nodes = fDirtyNodes.toArray(new FSTreeNode[fDirtyNodes.size()]);
+				IOpExecutor executor = new UiExecutor();
+				executor.execute(new OpUpload(nodes));
+			}
+			else {
+				SafeRunner.run(new SafeRunnable(){
+					@Override
+                    public void handleException(Throwable e) {
+						// Ignore exception
+                    }
+					@Override
+                    public void run() throws Exception {
+						for (FSTreeNode dirtyNode : fDirtyNodes) {
+							dirtyNode.refresh();
+						}
+                    }});
+			}
+		}
+	}
+
+	/* (non-Javadoc)
+	 * @see org.eclipse.core.commands.IExecutionListener#preExecute(java.lang.String, org.eclipse.core.commands.ExecutionEvent)
+	 */
+	@Override
+	public void preExecute(String commandId, ExecutionEvent event) {
+		fDirtyNodes.clear();
+		IWorkbenchWindow window = HandlerUtil.getActiveWorkbenchWindow(event);
+		if (window == null) window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
+		IWorkbenchPage page = window.getActivePage();
+		IEditorPart[] editors = page.getDirtyEditors();
+		for (IEditorPart editor : editors) {
+			IEditorInput input = editor.getEditorInput();
+			FSTreeNode node = null;
+			if (input instanceof IURIEditorInput) {
+				//Get the file that is being edited.
+				IURIEditorInput fileInput = (IURIEditorInput) input;
+				URI uri = fileInput.getURI();
+				try {
+					IFileStore store = EFS.getStore(uri);
+					File localFile = store.toLocalFile(0, new NullProgressMonitor());
+					if (localFile != null) {
+						// Get the file's mapped FSTreeNode.
+						OpParsePath parser = new OpParsePath(localFile.getCanonicalPath());
+						new NullOpExecutor().execute(parser);
+						node = parser.getResult();
+						if (node != null) {
+							// If it is a modified node, add it to the dirty node list.
+							fDirtyNodes.add(node);
+						}
+					}
+				}catch(Exception e){}
+			}
+		}
+	}
+
+	/* (non-Javadoc)
+	 * @see org.eclipse.core.commands.IExecutionListener#notHandled(java.lang.String, org.eclipse.core.commands.NotHandledException)
+	 */
+	@Override
+	public void notHandled(String commandId, NotHandledException exception) {
+	}
+
+	/* (non-Javadoc)
+	 * @see org.eclipse.core.commands.IExecutionListener#postExecuteFailure(java.lang.String, org.eclipse.core.commands.ExecutionException)
+	 */
+	@Override
+	public void postExecuteFailure(String commandId, ExecutionException exception) {
+	}
+}