Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
30 hours[563117] Temporarily deactivate the new feature testsHEADmasterFlorian Barbin1-14/+11
Bug: 563117 Change-Id: Iacd2d087cd510f16f602b1d173989ba376bc40fb Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
30 hours[563117] Handle multi-session configurationArnaud Dieumegard41-817/+4905
Update test cases to handle modification for multi-session tests. Fix code errors leading to NPE and StackOverflow errors. Add dedicated tests: update abstract tests to allow for multiple session files to be copied on the test workspace. Change-Id: I14cc899834193a356a1f0ad63fe6e3a3516b3908 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Filter test dataArnaud Dieumegard44-13758/+16790
Only save and compare elements provided in the correspondence map for all diagrams. Change-Id: If8ef1ec6fba66973739760665a3705218f7de497 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Handle filters and layersArnaud Dieumegard8-22/+1560
Apply filters and layer from source diagram to target diagram. Change-Id: I524f1e7ab96d654bc1d04de80f7a4705f4bb8da4 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Add API call arguments checksArnaud Dieumegard7-34/+792
Add checks for call arguments: diagrams, sessions, map, target diagram name. Add related tests. Add documentation. Bug: 563117 Change-Id: I162cc5f6d2245cd7c164ff3488c17232b75c4c98 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Merge Sequence diagram specific API into general APIArnaud Dieumegard9-545/+535
Previously implemented API required a specific aPI for sequence diagrams. Now we rely on IDiagramDescriptionProvider to check if we apply format for one or the other type of diagrams. Clean API code, update methods visibility and move utility methods to helper class. Bug: 563117 Change-Id: I241300b0ef8ec0b7b45c5423de26324ec19d90b5 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Copy depth position of nodesArnaud Dieumegard43-2772/+2597
Z-order may not be respected for some of the created diagram elements: synchronized mappings and notes. Notes are replicated after semantic DDiagramElements and thus may not be depth-ordered correctly. Implementation and test cases are added. Update test results with correct depth information. Bug: 563117 Change-Id: I60e9a37977143ced8e17aa0d66e38f21de1a6d0c Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Copy notes featureArnaud Dieumegard16-76/+4233
Add ability to copy notes and text notes from the source diagram to the target diagram. Add test cases Bug: 563117 Change-Id: I7993d35b93227e04f1e8a0838bd8e8cf7f1c4c54 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Mapping based format manager API for sequence diagramsArnaud Dieumegard28-3/+24633
- Application of format from a source sequence diagram to a new or an existing sequence diagram. - Use of a source semantic object to target semantic object map to choose which format to apply on which object representation. - Add tests and enable them in gerrit test suite. Bug: 563117 Change-Id: I5922b1f6585978055859b64fb636c661464ef089 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Mapping based format manager API for diagramsArnaud Dieumegard34-65/+13692
- Application of format on (existing or not) diagrams (not sequences) from a source diagram. - Use of a source semantic object to target semantic object map to choose which format to apply on which object representation. - Apply filtering on non-synchronized elements representation mappings based on the content of the semantic map. - Add tests and enable them in gerrit. - Set default font for tests to "Sans" Bug: 563117 Change-Id: Ifb90437a71fb5de7ec6b4f9b0d51d4a6c425cda4 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
30 hours[563117] Base implementation of mapping-based format managerArnaud Dieumegard5-3/+409
- Use of a <EObject,EObject> (source diagram to target diagram semantic element) map to resolve FormatData to apply on target diagram based on source diagram ones. - The switch is on the createKey method that resolves using the map when the semanticDecorator is contained in the source diagram. - Functional test for the FormatManager. - Harmonized AdvancedSiriusFormatDataManager interface. Bug: 563117 Change-Id: I87c073cbbe8b38014a9bd6534191e4ecea8a7726 Signed-off-by: Arnaud Dieumegard <arnaud.dieumegard@obeo.fr>
32 hours[568394] Add helper in SWTBotUtils to expand ExpandableCompositeGlenn Plouhinec1-1/+20
Wizards with ExpandableComposite requires a new helper in SWTBotUtils to expand and fold. Bug:568394 Change-Id: Ie3e16d3507a496015c8d30c4aa77591fd569be69 Signed-off-by: Glenn Plouhinec <glenn.plouhinec@obeo.fr>
34 hours[test] Make DeleteFromDiagramTest more reliableLaurent Redor1-7/+10
Sometimes, on some CI servers, the test DeleteFromDiagramTest.testDeleteFromDiagramAction() fails. The error was java.lang.AssertionError: expected:<50> but was:<0> at org.eclipse.sirius.tests.swtbot.DeleteFromDiagramTest.testDeleteFromDiagramAction(DeleteFromDiagramTest.java:83) It was like if the SWTBotTree in AbstractSiriusSwtBotGefTestCase.getNbStatusInErrorLog() has not the time to be fill before the method "tree.getAllItems().length" was called. To avoid this kind of problem, the way to detect new messages has been changed. It now relies on the existing "catch errors" and "catch messages" mechanism (instead of relying on UI). Change-Id: Ida0b9e6ac874e300f3e4c5f9c2e5f82908c14d33 Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
4 days[568308] Fix activation of copyFormat action.jmallet4-3/+110
Whatever the permission Authority for a diagram, copyFormat action is now enabled as this action does not edit anything on the diagram. Change-Id: Id03bee155ee5d07262e1321e5eaf76b1807955d7 Signed-off-by: jmallet <jessy.mallet@obeo.fr>
4 days[fix] Fix potential NPE when the DRepresentation is nullLaurent Fasani1-21/+17
Change-Id: I4e5a1bd4d66e84a1f9cf3674708e88e7a3de66df Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
4 days[568180] Enhance Sirius DAnalysisSelector to allow customizationLaurent Fasani5-79/+92
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=568180 Change-Id: I32861495267676ad2ab2550652ca4fe8cddf2b32 Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
8 days[567517] Identify reconnections candidates from the moved/final rangesMaxime Porhel1-1/+21
- Do not compute reconnections for all messages of the diagrams: the elements which are not in the range of the moved elements nor in the target result range might be shifted but not reconnected. Bug: 567517 Change-Id: I958b259fdc5555caa42b0de9c96163f68f826ee8 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Identify reparents candidates from the moved/final rangesNathalie Lepine2-6/+37
- Do not compute reparents for all nodes of the diagrams: the elements which are not in the range of the moved elements nor in the target result range might be shifted but not reparented. Bug: 567517 Change-Id: I52b5ec7bbc0507415689cdfe027b9096d51151ad Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr> Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Optimize SequenceMessageRouter.routeMaxime Porhel2-39/+48
- Store computed reflexive message width - Invalidate stored value on setVerticalRange calls and let the helper recompute the widht during Bendpoints update - Rework the route method to call isReflectiveMessage(part) only once. Bug: 567517 Change-Id: I33f46f75dc6459da1d1aa43247946a29c36aefd9 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Refresh each InstanceRoleEditPart only onceMaxime Porhel2-21/+39
Each ExecutionEditPart/StateEditPart used to call a refresh on its parent InstanceRoleEditPart for each single setBounds notification. On a diagram with 4 lifelines and several hundreds of Execution/State elements, a Sequence layout or an arrange all would trigger several hundreds of InstanceRoleEditPart.refresh(). With this patch only one InstanceRoleEditPart.refresh is triggered per impacted lifeline. The deleted notificationChanged method was called from the DiagramEventBroker which is installed before the post commit listener of the SequenceDiagramEditPart, that's why the refreshInstanceRoleEditPartsOnAbstractNodeEventSetBounds is called before the ZOrder refresh. This commits also reduce the number of decorators refresh. Bug: 567517 Change-Id: I3f6497e2c8eed64f9604c929f411faf95cb77e35 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Activate layout optimizations during arrange allMaxime Porhel2-22/+29
- Modify RefreshLayoutCommand to be able to launch a packing layout - Modify the SequenceLayoutProvider to use a packing RefreshLayoutCommand which enable the cache and optimize the computation of the eventEnds used by the refresh oredring operations. Bug: 567517 Change-Id: Ied36ac947b8bd837dc8f668c5a12768efac84084 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Add a cache for SequenceDiagram.getAllDelimitedEvents()Maxime Porhel1-8/+28
- Several other SequenceDiagram.getAllXXX methods already use a cache if the SequenceDiagram cache is enabled some of them use this getAllDelimitedEvents but it is also used in several other places with a lot of calls during some user actions like drag, move, resize and also during layout. Bug: 567517 Change-Id: Ie57919ae0a906c9c35904f523560c3385b5f7287 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Add a cache for EventEndHelper.findISequenceEvent(SEE, ISE)Maxime Porhel2-2/+28
Bug: 567517 Change-Id: I24c70cb4fd59b19bae0cf100330fed2d4c164eb3 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Refactor CacheHelperMaxime Porhel11-122/+88
- Identify structural and range dependant cache. - Clear range dependant caches as soon as a RangeSetter.setVerticalRange is called. - Rename the cache activator and tester methods Bug: 567517 Change-Id: I2a854fda59e7816fda4227ebd076e7fb97822605 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Activate Sequence caches from drag trackersNathalie Lepine7-29/+100
- Activate SequenceDiagram and CacheHelper between handleButtonDown and handleButtonUp in order to improve performances during all the "dragInProgress" computations (validtors, feedback, build command, ...) and disable cache before the command execution. - Customize all sequence event resize and move drag trackers. Bug: 567517 Change-Id: I113b078c748a8c936795c2072e7d8fe83025f548 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Add additional structural cachesMaxime Porhel6-6/+155
Add caches for to store computation result of : - AbstractNodeEvent.getHierarchicalParent() - ISequenceEvent.getParentOperand() - ISequenceEvent.getParentEvent() Bug: 567517 Change-Id: If2e3d4559b04b2686cd894c5012d64d4cc9cb3e2 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Optimize Sequence Observation LayoutMaxime Porhel1-5/+7
- Do not try to compute the ObservationPoints bounds if there is no ObservationPoint element Bug: 567517 Change-Id: I23aa5f37ccb70302d7524c48ab2b43128a411a2e Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Optimize Sequence Horizontal LayoutMaxime Porhel2-35/+38
- Compute Message.getParentOperand() only if a lost message end is found. - Fast return the default reflexive message width if there is no surrounded event on the same lifeline. Bug: 567517 Change-Id: I2fab94b454824ff7fc4832d777d21687e55851ac Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Optimize event ends computationMaxime Porhel5-88/+63
- Avoid duplicated calls to EventEndHelper.findEndsFromSemanticOdrering - Add a new EventEndHelper.findEndsFromSemanticOdrering method when the Sequence diagram is already known. - Replace SequenceDiagram.findEnds() implementation by a call to EventEndsHelper.findEndsFromSemanticOrdering. There is no need to look into the graphical ordering. This allows to make all "findEnds" calls beneficiate from the cached computation of EventEndHelper. Bug: 567517 Change-Id: I35a09355e08be9a7df4021a579f985d1fa6135b1 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Activate caches for layout refreshNathalie Lepine5-12/+63
Bug: 567517 Change-Id: Ibe10b77227430102c73a0db36ae4fdd756aec2b9 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Add a cache for ISequenceElement.getDiagramMaxime Porhel1-4/+12
There is no need to compute the GMF Diagram and the associated SequenceDiagram several times. Bug: 567517 Change-Id: Ifc64cea5a62ebb7457df8793ef45575e2eb4b6aa Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Avoid to call Execution.getSequenceDiagram several timesMaxime Porhel2-21/+21
Bug: 567517 Change-Id: I5ecd741794e30b4b65f7310ea34b3fb966766b93 Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Add a cache for ISequenceEvent.getLifelineNathalie Lepine2-33/+38
Bug: 567517 Change-Id: I8bf3ca2ba6c018aeb48caae85b8a94101aa5acab Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Reorganize ISequenceElement implementationsMaxime Porhel6-291/+165
- Remove duplicated code between Execution/State/EndOfLife which is already in their superclass. - Reorder methods in Execution and State to ease the comparison. - Move getParentLifeline() from AbstractSequenceElement to AbstractSequenceNode : the other sequence elements will not retrieve the lifeline in their parent views. Bug: 567517 Change-Id: I9135795e92be2fc7bb1333d4bdf93611de1da3ec Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Add an initial range function with cacheMaxime Porhel1-7/+23
Bug: 567517 Change-Id: Ib2623a71015cc088a329bc48be81ea0fb22a801c Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Add a cache for execution compound messagesNathalie Lepine2-49/+87
Bug: 567517 Change-Id: I71dbe79d25cf4b88ed0939fb6cd37aceb9ccbc2d Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Disable cache if RangeSetter.setVerticalRange is called.Maxime Porhel1-22/+38
Bug: 567517 Change-Id: I116bb2691855d82973dc4622ea905f2fe59a025b Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Add a cache for vertical rangeMaxime Porhel4-75/+102
Bug: 567517 Change-Id: I6127afd3150638e67cf82ebb6600abe955b0fbb9 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Add a cache for getSubEvents()Nathalie Lepine2-0/+23
Bug: 567517 Change-Id: Idabc46861c11e37d3e5d943752804af426204dbc Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Add a cache for abstract frames coverageNathalie Lepine2-7/+37
Bug: 567517 Change-Id: I42d04fc3ca7f4c592ceb51e0837d3f69d5f6a3e3 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Add a cache in SiriusDragEditPartsTrackerExNathalie Lepine14-79/+341
* add sequence SiriusDragEditPartsTrackerEx for all sequence elements * Init and clear caches in Sequence DragEditPartsTrackerEx * add CacheHelper to manager cache Bug: 567517 Change-Id: Iec6ccd235f691d43dd96c26d8c92e237af19f903 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Add a cache for EventEndHelper.findEndsFromSemanticOrderingMaxime Porhel2-32/+94
- This allows to have a EventEnds cache for each diagram. - The cache is cleared when the eventEnds list of the ordering changes - The adapter is created on the first call to findEndsFromSemanticOrdering Bug: 567517 Change-Id: I8756ab466e367a2e35f4732e443083f4bd0d2b10 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr> Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Better performance for EventFinder.findMostSpecificEventNathalie Lepine1-21/+36
Bug: 567517 Change-Id: I004a15b4e24df7c7070a5309cdb4341f79d8267c Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Reuse move/resize validators datas for feedbackNathalie Lepine3-51/+96
Bug: 567517 Change-Id: Ic5147ca69f366139f836ac52e319ed666cc564a4 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Remove some Lists.newArrayListNathalie Lepine2-24/+23
There is no need to create the list if we only need to filter or count the elements. Bug: 567517 Change-Id: I9e349fe245780c56f4fb606b5b4073db5eead776 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Only trigger SequenceCanonicalSynchronizerAdapter for modifiedMaxime Porhel2-15/+31
diagram Bug: 567517 Change-Id: Id9f6bf8a42f258de4a3e6820fd6b35b2b976f73e Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Do not trigger Sequence layout for non impacted diagramsMaxime Porhel6-1521/+2105
- Rework RefreshLayoutScope to check that the modified GMF View elements belongs to the Sequence Diagram which is concerned by the current RefreshLayoutScope or by a Sequence Diagram which has the same semantic target. - Rework RefreshLayoutScope notification analysis - Check that WorkspaceImage case concerns the current DDiagram (but containsSetWkpImgApplication continues to always return null). - Rework getValues in order to reduce code duplication. - Add shortcut if valueView corresponds to notifier view has it has already been analyzed. - Fix RefreshLayoutScopeAsserter to analyze the notifications in a "isAny" way instead of a "isFirst" way. - Add a test and rename RefreshLayoutNotExecutedOnNoSequenceChangesTests into RefreshLayoutScopeTests. Bug: 567517 Change-Id: Iac542f9eb23dbd6f21fef23a6dd5ce8f712092db Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
8 days[567517] Avoid doublons calls to Message.getVerticalRange()Maxime Porhel1-2/+3
Bug: 567517 Change-Id: I4e5c8aa04f04ac6bd06a883a20baffc42d4f8478 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Improve ISEComplexMoveValidator.checkOperandStabilityNathalie Lepine1-12/+13
- Do not compute getParentOperand() if the result is not used. Bug: 567517 Change-Id: Ia5e654dd565aaf7a03d018f6a8f8eddee13ac8d3 Signed-off-by: Nathalie Lepine <nathalie.lepine@obeo.fr>
8 days[567517] Rework decorator provider to avoid duplicated computationsMaxime Porhel3-38/+58
Bug: 567517 Change-Id: I7534ca1e0338bb468ba692da68368a14a1c49f8c Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>

Back to the top